2012-05-07 03:35:14

by Zero Lin

[permalink] [raw]
Subject: [PATCH] rt2x00:Add RT539B chipset support V2

From: "Zero.Lin" <[email protected]>

Signed-off-by: Zero.Lin <[email protected]>
---
drivers/net/wireless/rt2x00/rt2800pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
index 0c9b51d..cad25bf 100644
--- a/drivers/net/wireless/rt2x00/rt2800pci.c
+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
@@ -1192,8 +1192,8 @@ static DEFINE_PCI_DEVICE_TABLE(rt2800pci_device_table) = {
{ PCI_DEVICE(0x1814, 0x5390) },
{ PCI_DEVICE(0x1814, 0x5392) },
{ PCI_DEVICE(0x1814, 0x539a) },
- { PCI_DEVICE(0x1814, 0x539f) },
{ PCI_DEVICE(0x1814, 0x539b) },
+ { PCI_DEVICE(0x1814, 0x539f) },
#endif
{ 0, }
};
--
1.7.5.4



2012-05-07 12:39:50

by Gertjan van Wingerde

[permalink] [raw]
Subject: Re: [PATCH] rt2x00:Add RT539B chipset support V2

Hi,

On Mon, May 7, 2012 at 5:34 AM, Zero Lin <[email protected]> wrote:
> From: "Zero.Lin" <[email protected]>
>
> Signed-off-by: Zero.Lin <[email protected]>

I'm sorry, but you will have to do this as a complete new patch
replacing your old one, not as an incremental to your initial patch.

> ---
> ?drivers/net/wireless/rt2x00/rt2800pci.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
> index 0c9b51d..cad25bf 100644
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -1192,8 +1192,8 @@ static DEFINE_PCI_DEVICE_TABLE(rt2800pci_device_table) = {
> ? ? ? ?{ PCI_DEVICE(0x1814, 0x5390) },
> ? ? ? ?{ PCI_DEVICE(0x1814, 0x5392) },
> ? ? ? ?{ PCI_DEVICE(0x1814, 0x539a) },
> - ? ? ? { PCI_DEVICE(0x1814, 0x539f) },
> ? ? ? ?{ PCI_DEVICE(0x1814, 0x539b) },
> + ? ? ? { PCI_DEVICE(0x1814, 0x539f) },
> ?#endif
> ? ? ? ?{ 0, }
> ?};
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html



--
---
Gertjan

2012-05-09 16:33:20

by Anisse Astier

[permalink] [raw]
Subject: Re: [rt2x00-users] [PATCH] rt2x00:Add RT539B chipset support V2

On Mon, 7 May 2012 21:18:50 +0800, Zero Lin (林瑞青) <[email protected]> wrote :

> Dear Gertjan,
>
> I am sorry, what should I do now?
> Re-send a patch?

I think what Gertjan meant is that you should resend the first version of
you patch with the 0x539b in the correct position.

The problem with the V2 of your patch was that it was on top of your first
version, therefore not usable separately.

>
> BR,
> Zero
>
> -----Original Message-----
> From: Gertjan van Wingerde [mailto:[email protected]]
> Sent: Monday, May 07, 2012 8:40 PM
> To: Zero Lin
> Cc: [email protected]; [email protected]; John Linville; Zero Lin (林瑞青)
> Subject: Re: [PATCH] rt2x00:Add RT539B chipset support V2
>
> Hi,
>
> On Mon, May 7, 2012 at 5:34 AM, Zero Lin <[email protected]> wrote:
> > From: "Zero.Lin" <[email protected]>
> >
> > Signed-off-by: Zero.Lin <[email protected]>
>
> I'm sorry, but you will have to do this as a complete new patch replacing your old one, not as an incremental to your initial patch.

Regards,

Anisse

2012-05-09 19:01:31

by Gertjan van Wingerde

[permalink] [raw]
Subject: Re: [rt2x00-users] [PATCH] rt2x00:Add RT539B chipset support V2

On 9 mei 2012, at 18:33, Anisse Astier <[email protected]> wrote:

> On Mon, 7 May 2012 21:18:50 +0800, Zero Lin (林瑞青) <[email protected]> wrote :
>
>> Dear Gertjan,
>>
>> I am sorry, what should I do now?
>> Re-send a patch?
>
> I think what Gertjan meant is that you should resend the first version of
> you patch with the 0x539b in the correct position.
>
> The problem with the V2 of your patch was that it was on top of your first
> version, therefore not usable separately.

That is exactly what I meant.

And sorry for not responding earlier. I'm just very busy at the moment with very little time for my linux related hobby :-(


>>
>> BR,
>> Zero
>>
>> -----Original Message-----
>> From: Gertjan van Wingerde [mailto:[email protected]]
>> Sent: Monday, May 07, 2012 8:40 PM
>> To: Zero Lin
>> Cc: [email protected]; [email protected]; John Linville; Zero Lin (林瑞青)
>> Subject: Re: [PATCH] rt2x00:Add RT539B chipset support V2
>>
>> Hi,
>>
>> On Mon, May 7, 2012 at 5:34 AM, Zero Lin <[email protected]> wrote:
>>> From: "Zero.Lin" <[email protected]>
>>>
>>> Signed-off-by: Zero.Lin <[email protected]>
>>
>> I'm sorry, but you will have to do this as a complete new patch replacing your old one, not as an incremental to your initial patch.
>
> Regards,
>
> Anisse

2012-05-07 13:24:06

by Zero Lin (林瑞青)

[permalink] [raw]
Subject: RE: [PATCH] rt2x00:Add RT539B chipset support V2

RGVhciBHZXJ0amFuLA0KDQpJIGFtIHNvcnJ5LCB3aGF0IHNob3VsZCBJIGRvIG5vdz8NClJlLXNl
bmQgYSBwYXRjaD8NCg0KQlIsDQpaZXJvDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpG
cm9tOiBHZXJ0amFuIHZhbiBXaW5nZXJkZSBbbWFpbHRvOmd3aW5nZXJkZUBnbWFpbC5jb21dIA0K
U2VudDogTW9uZGF5LCBNYXkgMDcsIDIwMTIgODo0MCBQTQ0KVG86IFplcm8gTGluDQpDYzogdXNl
cnNAcnQyeDAwLnNlcmlhbG1vbmtleS5jb207IGxpbnV4LXdpcmVsZXNzQHZnZXIua2VybmVsLm9y
ZzsgSm9obiBMaW52aWxsZTsgWmVybyBMaW4gKOael+eRnumdkikNClN1YmplY3Q6IFJlOiBbUEFU
Q0hdIHJ0MngwMDpBZGQgUlQ1MzlCIGNoaXBzZXQgc3VwcG9ydCBWMg0KDQpIaSwNCg0KT24gTW9u
LCBNYXkgNywgMjAxMiBhdCA1OjM0IEFNLCBaZXJvIExpbiA8emVyby5saW4uMDIwM0BnbWFpbC5j
b20+IHdyb3RlOg0KPiBGcm9tOiAiWmVyby5MaW4iIDxaZXJvLkxpbkBtZWRpYXRlay5jb20+DQo+
DQo+IFNpZ25lZC1vZmYtYnk6IFplcm8uTGluIDxaZXJvLkxpbkBtZWRpYXRlay5jb20+DQoNCkkn
bSBzb3JyeSwgYnV0IHlvdSB3aWxsIGhhdmUgdG8gZG8gdGhpcyBhcyBhIGNvbXBsZXRlIG5ldyBw
YXRjaCByZXBsYWNpbmcgeW91ciBvbGQgb25lLCBub3QgYXMgYW4gaW5jcmVtZW50YWwgdG8geW91
ciBpbml0aWFsIHBhdGNoLg0KDQo+IC0tLQ0KPiDCoGRyaXZlcnMvbmV0L3dpcmVsZXNzL3J0Mngw
MC9ydDI4MDBwY2kuYyB8IMKgIMKgMiArLQ0KPiDCoDEgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRp
b25zKCspLCAxIGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2ly
ZWxlc3MvcnQyeDAwL3J0MjgwMHBjaS5jIA0KPiBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL3J0Mngw
MC9ydDI4MDBwY2kuYw0KPiBpbmRleCAwYzliNTFkLi5jYWQyNWJmIDEwMDY0NA0KPiAtLS0gYS9k
cml2ZXJzL25ldC93aXJlbGVzcy9ydDJ4MDAvcnQyODAwcGNpLmMNCj4gKysrIGIvZHJpdmVycy9u
ZXQvd2lyZWxlc3MvcnQyeDAwL3J0MjgwMHBjaS5jDQo+IEBAIC0xMTkyLDggKzExOTIsOCBAQCBz
dGF0aWMgDQo+IERFRklORV9QQ0lfREVWSUNFX1RBQkxFKHJ0MjgwMHBjaV9kZXZpY2VfdGFibGUp
ID0gew0KPiDCoCDCoCDCoCDCoHsgUENJX0RFVklDRSgweDE4MTQsIDB4NTM5MCkgfSwNCj4gwqAg
wqAgwqAgwqB7IFBDSV9ERVZJQ0UoMHgxODE0LCAweDUzOTIpIH0sDQo+IMKgIMKgIMKgIMKgeyBQ
Q0lfREVWSUNFKDB4MTgxNCwgMHg1MzlhKSB9LA0KPiAtIMKgIMKgIMKgIHsgUENJX0RFVklDRSgw
eDE4MTQsIDB4NTM5ZikgfSwNCj4gwqAgwqAgwqAgwqB7IFBDSV9ERVZJQ0UoMHgxODE0LCAweDUz
OWIpIH0sDQo+ICsgwqAgwqAgwqAgeyBQQ0lfREVWSUNFKDB4MTgxNCwgMHg1MzlmKSB9LA0KPiDC
oCNlbmRpZg0KPiDCoCDCoCDCoCDCoHsgMCwgfQ0KPiDCoH07DQo+IC0tDQo+IDEuNy41LjQNCj4N
Cj4gLS0NCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVu
c3Vic2NyaWJlIA0KPiBsaW51eC13aXJlbGVzcyIgaW4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRv
IG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcgDQo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgwqBo
dHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwNCg0KDQoNCi0tDQotLS0N
CkdlcnRqYW4NCgoqKioqKioqKioqKioqIEVtYWlsIENvbmZpZGVudGlhbGl0eSBOb3RpY2UgKioq
KioqKioqKioqKioqKioqKioNClRoZSBpbmZvcm1hdGlvbiBjb250YWluZWQgaW4gdGhpcyBlLW1h
aWwgbWVzc2FnZSAoaW5jbHVkaW5nIGFueSANCmF0dGFjaG1lbnRzKSBtYXkgYmUgY29uZmlkZW50
aWFsLCBwcm9wcmlldGFyeSwgcHJpdmlsZWdlZCwgb3Igb3RoZXJ3aXNlDQpleGVtcHQgZnJvbSBk
aXNjbG9zdXJlIHVuZGVyIGFwcGxpY2FibGUgbGF3cy4gSXQgaXMgaW50ZW5kZWQgdG8gYmUgDQpj
b252ZXllZCBvbmx5IHRvIHRoZSBkZXNpZ25hdGVkIHJlY2lwaWVudChzKS4gQW55IHVzZSwgZGlz
c2VtaW5hdGlvbiwgDQpkaXN0cmlidXRpb24sIHByaW50aW5nLCByZXRhaW5pbmcgb3IgY29weWlu
ZyBvZiB0aGlzIGUtbWFpbCAoaW5jbHVkaW5nIGl0cyANCmF0dGFjaG1lbnRzKSBieSB1bmludGVu
ZGVkIHJlY2lwaWVudChzKSBpcyBzdHJpY3RseSBwcm9oaWJpdGVkIGFuZCBtYXkgDQpiZSB1bmxh
d2Z1bC4gSWYgeW91IGFyZSBub3QgYW4gaW50ZW5kZWQgcmVjaXBpZW50IG9mIHRoaXMgZS1tYWls
LCBvciBiZWxpZXZlIA0KdGhhdCB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIGUtbWFpbCBpbiBlcnJv
ciwgcGxlYXNlIG5vdGlmeSB0aGUgc2VuZGVyIA0KaW1tZWRpYXRlbHkgKGJ5IHJlcGx5aW5nIHRv
IHRoaXMgZS1tYWlsKSwgZGVsZXRlIGFueSBhbmQgYWxsIGNvcGllcyBvZiANCnRoaXMgZS1tYWls
IChpbmNsdWRpbmcgYW55IGF0dGFjaG1lbnRzKSBmcm9tIHlvdXIgc3lzdGVtLCBhbmQgZG8gbm90
DQpkaXNjbG9zZSB0aGUgY29udGVudCBvZiB0aGlzIGUtbWFpbCB0byBhbnkgb3RoZXIgcGVyc29u
LiBUaGFuayB5b3Uh