2012-10-03 23:21:15

by Daniel Golle

[permalink] [raw]

Subject: [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66.

---

This should be register 66 instead of 62.
(probably happened by copy&past'ing from the lines below)

Signed-off-by: Daniel Golle <[email protected]>

---
drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 540c94f..01dc889 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2252,9 +2252,9 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
*/
if (rt2x00_rt(rt2x00dev, RT3352)) {
rt2800_bbp_write(rt2x00dev, 27, 0x0);
- rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
+ rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
rt2800_bbp_write(rt2x00dev, 27, 0x20);
- rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
+ rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
} else {
rt2800_bbp_write(rt2x00dev, 62, 0x37 - rt2x00dev->lna_gain);
rt2800_bbp_write(rt2x00dev, 63, 0x37 - rt2x00dev->lna_gain);
--
1.7.12.2

---

Attachments:

(No filename) (1.07 kB)
(No filename) (836.00 B)
Download all attachments

2012-10-04 09:37:27

by Gertjan van Wingerde

[permalink] [raw]

Subject: Re: [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66.

---

On Thu, Oct 4, 2012 at 1:20 AM, Daniel Golle <[email protected]> wrote:
> This should be register 66 instead of 62.
> (probably happened by copy&past'ing from the lines below)
>
> Signed-off-by: Daniel Golle <[email protected]>

Acked-by: Gertjan van Wingerde <[email protected]>

John, please apply to the wireless tree for inclusion in 3.7.

>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 540c94f..01dc889 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2252,9 +2252,9 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
> */
> if (rt2x00_rt(rt2x00dev, RT3352)) {
> rt2800_bbp_write(rt2x00dev, 27, 0x0);
> - rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> + rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
> rt2800_bbp_write(rt2x00dev, 27, 0x20);
> - rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> + rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
> } else {
> rt2800_bbp_write(rt2x00dev, 62, 0x37 - rt2x00dev->lna_gain);
> rt2800_bbp_write(rt2x00dev, 63, 0x37 - rt2x00dev->lna_gain);
> --
> 1.7.12.2
>



--
---
Gertjan

2012-10-04 18:58:20

by Ivo Van Doorn

[permalink] [raw]

Subject: Re: [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66.

---

On Thu, Oct 4, 2012 at 1:20 AM, Daniel Golle <[email protected]> wrote:
> This should be register 66 instead of 62.
> (probably happened by copy&past'ing from the lines below)
>
> Signed-off-by: Daniel Golle <[email protected]>

Acked-by: Ivo van Doorn <[email protected]>

>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 540c94f..01dc889 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2252,9 +2252,9 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
> */
> if (rt2x00_rt(rt2x00dev, RT3352)) {
> rt2800_bbp_write(rt2x00dev, 27, 0x0);
> - rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> + rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
> rt2800_bbp_write(rt2x00dev, 27, 0x20);
> - rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> + rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
> } else {
> rt2800_bbp_write(rt2x00dev, 62, 0x37 - rt2x00dev->lna_gain);
> rt2800_bbp_write(rt2x00dev, 63, 0x37 - rt2x00dev->lna_gain);
> --
> 1.7.12.2
>