This series touches some minor stuff in both drivers. The first
change was a report from Dan Carpenter which gets rid of smatch
warning/error. In brcmsmac I extended the hardware info file
contents in debugfs. The last patch solves a problem in brcmfmac
that I came across during testing.
The series is intended for 3.19 and applies to the master branch
of the wireless-next repository.
Arend van Spriel (4):
brcmfmac: fix static checker warning in pmklist handling
brcmutil: add helper function to format board revision
brcmsmac: extend hardware info shown in debugfs
brcmfmac: correct .disconnect() callback while connecting
drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 8 ++---
drivers/net/wireless/brcm80211/brcmsmac/debug.c | 40 +++++++++++++++-------
drivers/net/wireless/brcm80211/brcmutil/utils.c | 16 +++++++++
.../net/wireless/brcm80211/include/brcmu_utils.h | 2 ++
4 files changed, 49 insertions(+), 17 deletions(-)
--
1.9.1
On 11/25/14 13:12, Arend van Spriel wrote:
> On 11/24/14 22:50, John W. Linville wrote:
>> Hmmm...I'm not sure why, but this is causing problems for me...
>>
>> ERROR: "brcmu_boardrev_str"
>> [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
>
> I am confused as well. I did not have such an issue. The function is
> provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added
> it to the include file. Missing something? Also I don't see this issue
> over here. I will do a clean build on the wireless-next tree and see if
> I can reproduce this.
So I did a fresh checkout of wireless-next/master and applied patch 2
and 3. Here is my build output:
$ make M=drivers/net/wireless/brcm80211 modules
CC [M] drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/ucode_loader.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/ampdu.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/antsel.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/channel.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/main.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy_shim.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/pmu.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/rate.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/stf.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/aiutils.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phytbl_lcn.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phytbl_n.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_qmath.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/dma.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/brcms_trace_events.o
CC [M] drivers/net/wireless/brcm80211/brcmsmac/debug.o
LD [M] drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.o
CC [M] drivers/net/wireless/brcm80211/brcmutil/utils.o
CC [M] drivers/net/wireless/brcm80211/brcmutil/d11.o
LD [M] drivers/net/wireless/brcm80211/brcmutil/brcmutil.o
Building modules, stage 2.
MODPOST 2 modules
CC drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.mod.o
LD [M] drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko
CC drivers/net/wireless/brcm80211/brcmutil/brcmutil.mod.o
LD [M] drivers/net/wireless/brcm80211/brcmutil/brcmutil.ko
Anything else I should try over here?
Regards,
Arend
> Regards,
> Arend
>
>> On Thu, Nov 20, 2014 at 10:27:01PM +0100, Arend van Spriel wrote:
>>> The hardware info now also include radio and phy information, which
>>> can be helpful in debugging issues.
>>>
>>> Reviewed-by: Hante Meuleman<[email protected]>
>>> Reviewed-by: Pieter-Paul Giesberts<[email protected]>
>>> Signed-off-by: Arend van Spriel<[email protected]>
>>> ---
>>> drivers/net/wireless/brcm80211/brcmsmac/debug.c | 40
>>> +++++++++++++++++--------
>>> 1 file changed, 27 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/debug.c
>>> b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
>>> index 19740c1..c9a8b93 100644
>>> --- a/drivers/net/wireless/brcm80211/brcmsmac/debug.c
>>> +++ b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
>>> @@ -30,6 +30,7 @@
>>> #include "main.h"
>>> #include "debug.h"
>>> #include "brcms_trace_events.h"
>>> +#include "phy/phy_int.h"
>>>
>>> static struct dentry *root_folder;
>>>
>>> @@ -74,20 +75,33 @@ static
>>> int brcms_debugfs_hardware_read(struct seq_file *s, void *data)
>>> {
>>> struct brcms_pub *drvr = s->private;
>>> + struct brcms_hardware *hw = drvr->wlc->hw;
>>> + struct bcma_device *core = hw->d11core;
>>> + struct bcma_bus *bus = core->bus;
>>> + char boardrev[10];
>>>
>>> - seq_printf(s, "board vendor: %x\n"
>>> - "board type: %x\n"
>>> - "board revision: %x\n"
>>> - "board flags: %x\n"
>>> - "board flags2: %x\n"
>>> - "firmware revision: %x\n",
>>> - drvr->wlc->hw->d11core->bus->boardinfo.vendor,
>>> - drvr->wlc->hw->d11core->bus->boardinfo.type,
>>> - drvr->wlc->hw->boardrev,
>>> - drvr->wlc->hw->boardflags,
>>> - drvr->wlc->hw->boardflags2,
>>> - drvr->wlc->ucode_rev);
>>> -
>>> + seq_printf(s, "chipnum 0x%x\n"
>>> + "chiprev 0x%x\n"
>>> + "chippackage 0x%x\n"
>>> + "corerev 0x%x\n"
>>> + "boardid 0x%x\n"
>>> + "boardvendor 0x%x\n"
>>> + "boardrev %s\n"
>>> + "boardflags 0x%x\n"
>>> + "boardflags2 0x%x\n"
>>> + "ucoderev 0x%x\n"
>>> + "radiorev 0x%x\n"
>>> + "phytype 0x%x\n"
>>> + "phyrev 0x%x\n"
>>> + "anarev 0x%x\n"
>>> + "nvramrev %d\n",
>>> + bus->chipinfo.id, bus->chipinfo.rev, bus->chipinfo.pkg,
>>> + core->id.rev, bus->boardinfo.type, bus->boardinfo.vendor,
>>> + brcmu_boardrev_str(hw->boardrev, boardrev),
>>> + drvr->wlc->hw->boardflags, drvr->wlc->hw->boardflags2,
>>> + drvr->wlc->ucode_rev, hw->band->radiorev,
>>> + hw->band->phytype, hw->band->phyrev, hw->band->pi->ana_rev,
>>> + hw->sromrev);
>>> return 0;
>>> }
>>>
>>> --
>>> 1.9.1
>>>
>>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
> On 11/24/14 22:50, John W. Linville wrote:
> >Hmmm...I'm not sure why, but this is causing problems for me...
> >
> >ERROR: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
>
> I am confused as well. I did not have such an issue. The function is
> provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added it
> to the include file. Missing something? Also I don't see this issue over
> here. I will do a clean build on the wireless-next tree and see if I can
> reproduce this.
I did a clean build after applying the patches in question, and I
still got the same issue at link time. I'll attach my .config for
you to try.
FWIW, I am building wireless-testing at commit
733ea24c8c98d99c747b89710e520ac6e9f3951b.
John
> Regards,
> Arend
>
> >On Thu, Nov 20, 2014 at 10:27:01PM +0100, Arend van Spriel wrote:
> >>The hardware info now also include radio and phy information, which
> >>can be helpful in debugging issues.
> >>
> >>Reviewed-by: Hante Meuleman<[email protected]>
> >>Reviewed-by: Pieter-Paul Giesberts<[email protected]>
> >>Signed-off-by: Arend van Spriel<[email protected]>
> >>---
> >> drivers/net/wireless/brcm80211/brcmsmac/debug.c | 40 +++++++++++++++++--------
> >> 1 file changed, 27 insertions(+), 13 deletions(-)
> >>
> >>diff --git a/drivers/net/wireless/brcm80211/brcmsmac/debug.c b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
> >>index 19740c1..c9a8b93 100644
> >>--- a/drivers/net/wireless/brcm80211/brcmsmac/debug.c
> >>+++ b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
> >>@@ -30,6 +30,7 @@
> >> #include "main.h"
> >> #include "debug.h"
> >> #include "brcms_trace_events.h"
> >>+#include "phy/phy_int.h"
> >>
> >> static struct dentry *root_folder;
> >>
> >>@@ -74,20 +75,33 @@ static
> >> int brcms_debugfs_hardware_read(struct seq_file *s, void *data)
> >> {
> >> struct brcms_pub *drvr = s->private;
> >>+ struct brcms_hardware *hw = drvr->wlc->hw;
> >>+ struct bcma_device *core = hw->d11core;
> >>+ struct bcma_bus *bus = core->bus;
> >>+ char boardrev[10];
> >>
> >>- seq_printf(s, "board vendor: %x\n"
> >>- "board type: %x\n"
> >>- "board revision: %x\n"
> >>- "board flags: %x\n"
> >>- "board flags2: %x\n"
> >>- "firmware revision: %x\n",
> >>- drvr->wlc->hw->d11core->bus->boardinfo.vendor,
> >>- drvr->wlc->hw->d11core->bus->boardinfo.type,
> >>- drvr->wlc->hw->boardrev,
> >>- drvr->wlc->hw->boardflags,
> >>- drvr->wlc->hw->boardflags2,
> >>- drvr->wlc->ucode_rev);
> >>-
> >>+ seq_printf(s, "chipnum 0x%x\n"
> >>+ "chiprev 0x%x\n"
> >>+ "chippackage 0x%x\n"
> >>+ "corerev 0x%x\n"
> >>+ "boardid 0x%x\n"
> >>+ "boardvendor 0x%x\n"
> >>+ "boardrev %s\n"
> >>+ "boardflags 0x%x\n"
> >>+ "boardflags2 0x%x\n"
> >>+ "ucoderev 0x%x\n"
> >>+ "radiorev 0x%x\n"
> >>+ "phytype 0x%x\n"
> >>+ "phyrev 0x%x\n"
> >>+ "anarev 0x%x\n"
> >>+ "nvramrev %d\n",
> >>+ bus->chipinfo.id, bus->chipinfo.rev, bus->chipinfo.pkg,
> >>+ core->id.rev, bus->boardinfo.type, bus->boardinfo.vendor,
> >>+ brcmu_boardrev_str(hw->boardrev, boardrev),
> >>+ drvr->wlc->hw->boardflags, drvr->wlc->hw->boardflags2,
> >>+ drvr->wlc->ucode_rev, hw->band->radiorev,
> >>+ hw->band->phytype, hw->band->phyrev, hw->band->pi->ana_rev,
> >>+ hw->sromrev);
> >> return 0;
> >> }
> >>
> >>--
> >>1.9.1
> >>
> >>
> >
>
>
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
I am holding patches 2-4 until we resolve the brcmu_boardrev_str
build thing...
On Thu, Nov 20, 2014 at 10:27:00PM +0100, Arend van Spriel wrote:
> The board revision that is available in hardware can be translated
> so it matches the labelling on the board. This is accomplished by
> this helper function.
>
> Reviewed-by: Hante Meuleman <[email protected]>
> Reviewed-by: Pieter-Paul Giesberts <[email protected]>
> Signed-off-by: Arend van Spriel <[email protected]>
> ---
> drivers/net/wireless/brcm80211/brcmutil/utils.c | 16 ++++++++++++++++
> drivers/net/wireless/brcm80211/include/brcmu_utils.h | 2 ++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
> index 0f7e1c7..af97f8b 100644
> --- a/drivers/net/wireless/brcm80211/brcmutil/utils.c
> +++ b/drivers/net/wireless/brcm80211/brcmutil/utils.c
> @@ -292,4 +292,20 @@ void brcmu_dbg_hex_dump(const void *data, size_t size, const char *fmt, ...)
> print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, data, size);
> }
> EXPORT_SYMBOL(brcmu_dbg_hex_dump);
> +
> +/* Produce a human-readable string for boardrev */
> +char *brcmu_boardrev_str(u32 brev, char *buf)
> +{
> + char c;
> +
> + if (brev < 0x100) {
> + snprintf(buf, 8, "%d.%d", (brev & 0xf0) >> 4, brev & 0xf);
> + } else {
> + c = (brev & 0xf000) == 0x1000 ? 'P' : 'A';
> + snprintf(buf, 8, "%c%03x", c, brev & 0xfff);
> + }
> + return buf;
> +}
> +EXPORT_SYMBOL(brcmu_boardrev_str);
> +
> #endif /* defined(DEBUG) */
> diff --git a/drivers/net/wireless/brcm80211/include/brcmu_utils.h b/drivers/net/wireless/brcm80211/include/brcmu_utils.h
> index 8ba445b..a043e29 100644
> --- a/drivers/net/wireless/brcm80211/include/brcmu_utils.h
> +++ b/drivers/net/wireless/brcm80211/include/brcmu_utils.h
> @@ -218,4 +218,6 @@ void brcmu_dbg_hex_dump(const void *data, size_t size, const char *fmt, ...)
> }
> #endif
>
> +char *brcmu_boardrev_str(u32 brev, char *buf);
> +
> #endif /* _BRCMU_UTILS_H_ */
> --
> 1.9.1
>
>
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
Hmmm...I'm not sure why, but this is causing problems for me...
ERROR: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
On Thu, Nov 20, 2014 at 10:27:01PM +0100, Arend van Spriel wrote:
> The hardware info now also include radio and phy information, which
> can be helpful in debugging issues.
>
> Reviewed-by: Hante Meuleman <[email protected]>
> Reviewed-by: Pieter-Paul Giesberts <[email protected]>
> Signed-off-by: Arend van Spriel <[email protected]>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/debug.c | 40 +++++++++++++++++--------
> 1 file changed, 27 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/debug.c b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
> index 19740c1..c9a8b93 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/debug.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
> @@ -30,6 +30,7 @@
> #include "main.h"
> #include "debug.h"
> #include "brcms_trace_events.h"
> +#include "phy/phy_int.h"
>
> static struct dentry *root_folder;
>
> @@ -74,20 +75,33 @@ static
> int brcms_debugfs_hardware_read(struct seq_file *s, void *data)
> {
> struct brcms_pub *drvr = s->private;
> + struct brcms_hardware *hw = drvr->wlc->hw;
> + struct bcma_device *core = hw->d11core;
> + struct bcma_bus *bus = core->bus;
> + char boardrev[10];
>
> - seq_printf(s, "board vendor: %x\n"
> - "board type: %x\n"
> - "board revision: %x\n"
> - "board flags: %x\n"
> - "board flags2: %x\n"
> - "firmware revision: %x\n",
> - drvr->wlc->hw->d11core->bus->boardinfo.vendor,
> - drvr->wlc->hw->d11core->bus->boardinfo.type,
> - drvr->wlc->hw->boardrev,
> - drvr->wlc->hw->boardflags,
> - drvr->wlc->hw->boardflags2,
> - drvr->wlc->ucode_rev);
> -
> + seq_printf(s, "chipnum 0x%x\n"
> + "chiprev 0x%x\n"
> + "chippackage 0x%x\n"
> + "corerev 0x%x\n"
> + "boardid 0x%x\n"
> + "boardvendor 0x%x\n"
> + "boardrev %s\n"
> + "boardflags 0x%x\n"
> + "boardflags2 0x%x\n"
> + "ucoderev 0x%x\n"
> + "radiorev 0x%x\n"
> + "phytype 0x%x\n"
> + "phyrev 0x%x\n"
> + "anarev 0x%x\n"
> + "nvramrev %d\n",
> + bus->chipinfo.id, bus->chipinfo.rev, bus->chipinfo.pkg,
> + core->id.rev, bus->boardinfo.type, bus->boardinfo.vendor,
> + brcmu_boardrev_str(hw->boardrev, boardrev),
> + drvr->wlc->hw->boardflags, drvr->wlc->hw->boardflags2,
> + drvr->wlc->ucode_rev, hw->band->radiorev,
> + hw->band->phytype, hw->band->phyrev, hw->band->pi->ana_rev,
> + hw->sromrev);
> return 0;
> }
>
> --
> 1.9.1
>
>
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
The board revision that is available in hardware can be translated
so it matches the labelling on the board. This is accomplished by
this helper function.
Reviewed-by: Hante Meuleman <[email protected]>
Reviewed-by: Pieter-Paul Giesberts <[email protected]>
Signed-off-by: Arend van Spriel <[email protected]>
---
drivers/net/wireless/brcm80211/brcmutil/utils.c | 16 ++++++++++++++++
drivers/net/wireless/brcm80211/include/brcmu_utils.h | 2 ++
2 files changed, 18 insertions(+)
diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
index 0f7e1c7..af97f8b 100644
--- a/drivers/net/wireless/brcm80211/brcmutil/utils.c
+++ b/drivers/net/wireless/brcm80211/brcmutil/utils.c
@@ -292,4 +292,20 @@ void brcmu_dbg_hex_dump(const void *data, size_t size, const char *fmt, ...)
print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, data, size);
}
EXPORT_SYMBOL(brcmu_dbg_hex_dump);
+
+/* Produce a human-readable string for boardrev */
+char *brcmu_boardrev_str(u32 brev, char *buf)
+{
+ char c;
+
+ if (brev < 0x100) {
+ snprintf(buf, 8, "%d.%d", (brev & 0xf0) >> 4, brev & 0xf);
+ } else {
+ c = (brev & 0xf000) == 0x1000 ? 'P' : 'A';
+ snprintf(buf, 8, "%c%03x", c, brev & 0xfff);
+ }
+ return buf;
+}
+EXPORT_SYMBOL(brcmu_boardrev_str);
+
#endif /* defined(DEBUG) */
diff --git a/drivers/net/wireless/brcm80211/include/brcmu_utils.h b/drivers/net/wireless/brcm80211/include/brcmu_utils.h
index 8ba445b..a043e29 100644
--- a/drivers/net/wireless/brcm80211/include/brcmu_utils.h
+++ b/drivers/net/wireless/brcm80211/include/brcmu_utils.h
@@ -218,4 +218,6 @@ void brcmu_dbg_hex_dump(const void *data, size_t size, const char *fmt, ...)
}
#endif
+char *brcmu_boardrev_str(u32 brev, char *buf);
+
#endif /* _BRCMU_UTILS_H_ */
--
1.9.1
On Tue, Nov 25, 2014 at 02:00:38PM +0100, Arend van Spriel wrote:
> On 11/25/14 13:12, Arend van Spriel wrote:
> >On 11/24/14 22:50, John W. Linville wrote:
> >>Hmmm...I'm not sure why, but this is causing problems for me...
> >>
> >>ERROR: "brcmu_boardrev_str"
> >>[drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
> >
> >I am confused as well. I did not have such an issue. The function is
> >provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added
> >it to the include file. Missing something? Also I don't see this issue
> >over here. I will do a clean build on the wireless-next tree and see if
> >I can reproduce this.
>
> So I did a fresh checkout of wireless-next/master and applied patch 2 and 3.
> Here is my build output:
>
> $ make M=drivers/net/wireless/brcm80211 modules
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/ucode_loader.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/ampdu.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/antsel.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/channel.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/main.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy_shim.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/pmu.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/rate.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/stf.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/aiutils.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phytbl_lcn.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phytbl_n.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/phy/phy_qmath.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/dma.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/brcms_trace_events.o
> CC [M] drivers/net/wireless/brcm80211/brcmsmac/debug.o
> LD [M] drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.o
> CC [M] drivers/net/wireless/brcm80211/brcmutil/utils.o
> CC [M] drivers/net/wireless/brcm80211/brcmutil/d11.o
> LD [M] drivers/net/wireless/brcm80211/brcmutil/brcmutil.o
> Building modules, stage 2.
> MODPOST 2 modules
> CC drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.mod.o
> LD [M] drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko
> CC drivers/net/wireless/brcm80211/brcmutil/brcmutil.mod.o
> LD [M] drivers/net/wireless/brcm80211/brcmutil/brcmutil.ko
>
> Anything else I should try over here?
/home/linville/git/wireless-testing
[linville-x1.hq.tuxdriver.com]:> make M=drivers/net/wireless/brcm80211 modules
Building modules, stage 2.
MODPOST 3 modules
WARNING: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
CC drivers/net/wireless/brcm80211/brcmfmac/brcmfmac.mod.o
LD [M] drivers/net/wireless/brcm80211/brcmfmac/brcmfmac.ko
CC drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.mod.o
LD [M] drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko
CC drivers/net/wireless/brcm80211/brcmutil/brcmutil.mod.o
LD [M] drivers/net/wireless/brcm80211/brcmutil/brcmutil.ko
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On 11/25/14 20:23, Arend van Spriel wrote:
> On 11/25/14 20:16, Arend van Spriel wrote:
>> On 11/25/14 20:05, John W. Linville wrote:
>>> On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote:
>>>> On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
>>>>> On 11/24/14 22:50, John W. Linville wrote:
>>>>>> Hmmm...I'm not sure why, but this is causing problems for me...
>>>>>>
>>>>>> ERROR: "brcmu_boardrev_str"
>>>>>> [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
>>>>>
>>>>> I am confused as well. I did not have such an issue. The function is
>>>>> provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and
>>>>> added it
>>>>> to the include file. Missing something? Also I don't see this issue
>>>>> over
>>>>> here. I will do a clean build on the wireless-next tree and see if I
>>>>> can
>>>>> reproduce this.
>>>>
>>>> I did a clean build after applying the patches in question, and I
>>>> still got the same issue at link time. I'll attach my .config for
>>>> you to try.
>>>
>>> I think that was too big...trying the compressed version...
>>
>> I received both. I assume he commit mentioned below is without the
>> patches.
>
> Nevermind. Just saw that commit is before the reverts.
Crap. I unintentionally put the function in #ifdef section. Will fix
that and send a v2 patch.
Regards,
Arend
> Thanks,
> Arend
>
>> Regards,
>> Arend
>>
>>>> FWIW, I am building wireless-testing at commit
>>>> 733ea24c8c98d99c747b89710e520ac6e9f3951b.
>>>
>>> John
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-wireless" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote:
> On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
> > On 11/24/14 22:50, John W. Linville wrote:
> > >Hmmm...I'm not sure why, but this is causing problems for me...
> > >
> > >ERROR: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
> >
> > I am confused as well. I did not have such an issue. The function is
> > provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added it
> > to the include file. Missing something? Also I don't see this issue over
> > here. I will do a clean build on the wireless-next tree and see if I can
> > reproduce this.
>
> I did a clean build after applying the patches in question, and I
> still got the same issue at link time. I'll attach my .config for
> you to try.
I think that was too big...trying the compressed version...
> FWIW, I am building wireless-testing at commit
> 733ea24c8c98d99c747b89710e520ac6e9f3951b.
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
When the driver has sent a join iovar to the firmware it waits
for the events to report result of the connection. However, the
wpa_supplicant will request a .disconnect() after a timeout. So
upon calling .disconnect() the interface state may still be
CONNECTING. Clear the CONNECTING bit as well.
Reviewed-by: Hante Meuleman <[email protected]>
Reviewed-by: Pieter-Paul Giesberts <[email protected]>
Signed-off-by: Arend van Spriel <[email protected]>
---
drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
index d1928de..0ea3125 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
@@ -1815,6 +1815,7 @@ brcmf_cfg80211_disconnect(struct wiphy *wiphy, struct net_device *ndev,
return -EIO;
clear_bit(BRCMF_VIF_STATUS_CONNECTED, &ifp->vif->sme_state);
+ clear_bit(BRCMF_VIF_STATUS_CONNECTING, &ifp->vif->sme_state);
cfg80211_disconnected(ndev, reason_code, NULL, 0, GFP_KERNEL);
memcpy(&scbval.ea, &profile->bssid, ETH_ALEN);
--
1.9.1
On 11/25/14 20:16, Arend van Spriel wrote:
> On 11/25/14 20:05, John W. Linville wrote:
>> On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote:
>>> On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
>>>> On 11/24/14 22:50, John W. Linville wrote:
>>>>> Hmmm...I'm not sure why, but this is causing problems for me...
>>>>>
>>>>> ERROR: "brcmu_boardrev_str"
>>>>> [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
>>>>
>>>> I am confused as well. I did not have such an issue. The function is
>>>> provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and
>>>> added it
>>>> to the include file. Missing something? Also I don't see this issue
>>>> over
>>>> here. I will do a clean build on the wireless-next tree and see if I
>>>> can
>>>> reproduce this.
>>>
>>> I did a clean build after applying the patches in question, and I
>>> still got the same issue at link time. I'll attach my .config for
>>> you to try.
>>
>> I think that was too big...trying the compressed version...
>
> I received both. I assume he commit mentioned below is without the patches.
Nevermind. Just saw that commit is before the reverts.
Thanks,
Arend
> Regards,
> Arend
>
>>> FWIW, I am building wireless-testing at commit
>>> 733ea24c8c98d99c747b89710e520ac6e9f3951b.
>>
>> John
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
The hardware info now also include radio and phy information, which
can be helpful in debugging issues.
Reviewed-by: Hante Meuleman <[email protected]>
Reviewed-by: Pieter-Paul Giesberts <[email protected]>
Signed-off-by: Arend van Spriel <[email protected]>
---
drivers/net/wireless/brcm80211/brcmsmac/debug.c | 40 +++++++++++++++++--------
1 file changed, 27 insertions(+), 13 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/debug.c b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
index 19740c1..c9a8b93 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/debug.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
@@ -30,6 +30,7 @@
#include "main.h"
#include "debug.h"
#include "brcms_trace_events.h"
+#include "phy/phy_int.h"
static struct dentry *root_folder;
@@ -74,20 +75,33 @@ static
int brcms_debugfs_hardware_read(struct seq_file *s, void *data)
{
struct brcms_pub *drvr = s->private;
+ struct brcms_hardware *hw = drvr->wlc->hw;
+ struct bcma_device *core = hw->d11core;
+ struct bcma_bus *bus = core->bus;
+ char boardrev[10];
- seq_printf(s, "board vendor: %x\n"
- "board type: %x\n"
- "board revision: %x\n"
- "board flags: %x\n"
- "board flags2: %x\n"
- "firmware revision: %x\n",
- drvr->wlc->hw->d11core->bus->boardinfo.vendor,
- drvr->wlc->hw->d11core->bus->boardinfo.type,
- drvr->wlc->hw->boardrev,
- drvr->wlc->hw->boardflags,
- drvr->wlc->hw->boardflags2,
- drvr->wlc->ucode_rev);
-
+ seq_printf(s, "chipnum 0x%x\n"
+ "chiprev 0x%x\n"
+ "chippackage 0x%x\n"
+ "corerev 0x%x\n"
+ "boardid 0x%x\n"
+ "boardvendor 0x%x\n"
+ "boardrev %s\n"
+ "boardflags 0x%x\n"
+ "boardflags2 0x%x\n"
+ "ucoderev 0x%x\n"
+ "radiorev 0x%x\n"
+ "phytype 0x%x\n"
+ "phyrev 0x%x\n"
+ "anarev 0x%x\n"
+ "nvramrev %d\n",
+ bus->chipinfo.id, bus->chipinfo.rev, bus->chipinfo.pkg,
+ core->id.rev, bus->boardinfo.type, bus->boardinfo.vendor,
+ brcmu_boardrev_str(hw->boardrev, boardrev),
+ drvr->wlc->hw->boardflags, drvr->wlc->hw->boardflags2,
+ drvr->wlc->ucode_rev, hw->band->radiorev,
+ hw->band->phytype, hw->band->phyrev, hw->band->pi->ana_rev,
+ hw->sromrev);
return 0;
}
--
1.9.1
On 11/24/14 22:53, John W. Linville wrote:
> I am holding patches 2-4 until we resolve the brcmu_boardrev_str
> build thing...
Actually, only patch 2 and 3 are related to the build thing. If that is
what this is.
Regards,
Arend
> On Thu, Nov 20, 2014 at 10:27:00PM +0100, Arend van Spriel wrote:
>> The board revision that is available in hardware can be translated
>> so it matches the labelling on the board. This is accomplished by
>> this helper function.
>>
>> Reviewed-by: Hante Meuleman<[email protected]>
>> Reviewed-by: Pieter-Paul Giesberts<[email protected]>
>> Signed-off-by: Arend van Spriel<[email protected]>
>> ---
>> drivers/net/wireless/brcm80211/brcmutil/utils.c | 16 ++++++++++++++++
>> drivers/net/wireless/brcm80211/include/brcmu_utils.h | 2 ++
>> 2 files changed, 18 insertions(+)
>>
>> diff --git a/drivers/net/wireless/brcm80211/brcmutil/utils.c b/drivers/net/wireless/brcm80211/brcmutil/utils.c
>> index 0f7e1c7..af97f8b 100644
>> --- a/drivers/net/wireless/brcm80211/brcmutil/utils.c
>> +++ b/drivers/net/wireless/brcm80211/brcmutil/utils.c
>> @@ -292,4 +292,20 @@ void brcmu_dbg_hex_dump(const void *data, size_t size, const char *fmt, ...)
>> print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, data, size);
>> }
>> EXPORT_SYMBOL(brcmu_dbg_hex_dump);
>> +
>> +/* Produce a human-readable string for boardrev */
>> +char *brcmu_boardrev_str(u32 brev, char *buf)
>> +{
>> + char c;
>> +
>> + if (brev< 0x100) {
>> + snprintf(buf, 8, "%d.%d", (brev& 0xf0)>> 4, brev& 0xf);
>> + } else {
>> + c = (brev& 0xf000) == 0x1000 ? 'P' : 'A';
>> + snprintf(buf, 8, "%c%03x", c, brev& 0xfff);
>> + }
>> + return buf;
>> +}
>> +EXPORT_SYMBOL(brcmu_boardrev_str);
>> +
>> #endif /* defined(DEBUG) */
>> diff --git a/drivers/net/wireless/brcm80211/include/brcmu_utils.h b/drivers/net/wireless/brcm80211/include/brcmu_utils.h
>> index 8ba445b..a043e29 100644
>> --- a/drivers/net/wireless/brcm80211/include/brcmu_utils.h
>> +++ b/drivers/net/wireless/brcm80211/include/brcmu_utils.h
>> @@ -218,4 +218,6 @@ void brcmu_dbg_hex_dump(const void *data, size_t size, const char *fmt, ...)
>> }
>> #endif
>>
>> +char *brcmu_boardrev_str(u32 brev, char *buf);
>> +
>> #endif /* _BRCMU_UTILS_H_ */
>> --
>> 1.9.1
>>
>>
>
On Tue, Nov 25, 2014 at 11:01:47AM +0100, Arend van Spriel wrote:
> On 11/24/14 22:53, John W. Linville wrote:
> >I am holding patches 2-4 until we resolve the brcmu_boardrev_str
> >build thing...
>
> Actually, only patch 2 and 3 are related to the build thing. If that is what
> this is.
OK, I won't hold-up #4...
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On 11/25/14 20:05, John W. Linville wrote:
> On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote:
>> On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
>>> On 11/24/14 22:50, John W. Linville wrote:
>>>> Hmmm...I'm not sure why, but this is causing problems for me...
>>>>
>>>> ERROR: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
>>>
>>> I am confused as well. I did not have such an issue. The function is
>>> provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added it
>>> to the include file. Missing something? Also I don't see this issue over
>>> here. I will do a clean build on the wireless-next tree and see if I can
>>> reproduce this.
>>
>> I did a clean build after applying the patches in question, and I
>> still got the same issue at link time. I'll attach my .config for
>> you to try.
>
> I think that was too big...trying the compressed version...
I received both. I assume he commit mentioned below is without the patches.
Regards,
Arend
>> FWIW, I am building wireless-testing at commit
>> 733ea24c8c98d99c747b89710e520ac6e9f3951b.
>
> John
On Tue, Nov 25, 2014 at 08:16:17PM +0100, Arend van Spriel wrote:
> On 11/25/14 20:05, John W. Linville wrote:
> >On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote:
> >>On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
> >>>On 11/24/14 22:50, John W. Linville wrote:
> >>>>Hmmm...I'm not sure why, but this is causing problems for me...
> >>>>
> >>>>ERROR: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
> >>>
> >>>I am confused as well. I did not have such an issue. The function is
> >>>provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added it
> >>>to the include file. Missing something? Also I don't see this issue over
> >>>here. I will do a clean build on the wireless-next tree and see if I can
> >>>reproduce this.
> >>
> >>I did a clean build after applying the patches in question, and I
> >>still got the same issue at link time. I'll attach my .config for
> >>you to try.
> >
> >I think that was too big...trying the compressed version...
>
> I received both. I assume he commit mentioned below is without the patches.
>
> Regards,
> Arend
>
> >>FWIW, I am building wireless-testing at commit
> >>733ea24c8c98d99c747b89710e520ac6e9f3951b.
> >
> >John
That commit includes all 4 patches. I reverted the last three later
in the wireless-testing history.
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
The patch fixes a static checker warning:
drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c:2965
brcmf_cfg80211_set_pmksa()
warn: can 'pmkid_len' be negative?
The answer to the question above is likely no so changing its
type to unsigned is sufficient.
Reported-by: Dan Carpenter <[email protected]>
Reviewed-by: Hante Meuleman <[email protected]>
Reviewed-by: Franky (Zhenhui) Lin <[email protected]>
Reviewed-by: Daniel (Deognyoun) Kim <[email protected]>
Reviewed-by: Pieter-Paul Giesberts <[email protected]>
Signed-off-by: Arend van Spriel <[email protected]>
---
drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
index f8a9dfa..d1928de 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
@@ -2932,7 +2932,7 @@ brcmf_update_pmklist(struct net_device *ndev,
struct brcmf_cfg80211_pmk_list *pmk_list, s32 err)
{
int i, j;
- int pmkid_len;
+ u32 pmkid_len;
pmkid_len = le32_to_cpu(pmk_list->pmkids.npmkid);
@@ -2960,8 +2960,7 @@ brcmf_cfg80211_set_pmksa(struct wiphy *wiphy, struct net_device *ndev,
struct brcmf_if *ifp = netdev_priv(ndev);
struct pmkid_list *pmkids = &cfg->pmk_list->pmkids;
s32 err = 0;
- int i;
- int pmkid_len;
+ u32 pmkid_len, i;
brcmf_dbg(TRACE, "Enter\n");
if (!check_vif_up(ifp->vif))
@@ -3000,7 +2999,7 @@ brcmf_cfg80211_del_pmksa(struct wiphy *wiphy, struct net_device *ndev,
struct brcmf_if *ifp = netdev_priv(ndev);
struct pmkid_list pmkid;
s32 err = 0;
- int i, pmkid_len;
+ u32 pmkid_len, i;
brcmf_dbg(TRACE, "Enter\n");
if (!check_vif_up(ifp->vif))
--
1.9.1
On 11/25/14 20:20, John W. Linville wrote:
> On Tue, Nov 25, 2014 at 08:16:17PM +0100, Arend van Spriel wrote:
>> On 11/25/14 20:05, John W. Linville wrote:
>>> On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote:
>>>> On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
>>>>> On 11/24/14 22:50, John W. Linville wrote:
>>>>>> Hmmm...I'm not sure why, but this is causing problems for me...
>>>>>>
>>>>>> ERROR: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
>>>>>
>>>>> I am confused as well. I did not have such an issue. The function is
>>>>> provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added it
>>>>> to the include file. Missing something? Also I don't see this issue over
>>>>> here. I will do a clean build on the wireless-next tree and see if I can
>>>>> reproduce this.
>>>>
>>>> I did a clean build after applying the patches in question, and I
>>>> still got the same issue at link time. I'll attach my .config for
>>>> you to try.
>>>
>>> I think that was too big...trying the compressed version...
>>
>> I received both. I assume he commit mentioned below is without the patches.
>>
>> Regards,
>> Arend
>>
>>>> FWIW, I am building wireless-testing at commit
>>>> 733ea24c8c98d99c747b89710e520ac6e9f3951b.
>>>
>>> John
>
> That commit includes all 4 patches. I reverted the last three later
> in the wireless-testing history.
In wireless-next I see you included patches 1 and 4 already so I will
resend only patches 2 and 3.
Arend
> John
On 11/24/14 22:50, John W. Linville wrote:
> Hmmm...I'm not sure why, but this is causing problems for me...
>
> ERROR: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
I am confused as well. I did not have such an issue. The function is
provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added
it to the include file. Missing something? Also I don't see this issue
over here. I will do a clean build on the wireless-next tree and see if
I can reproduce this.
Regards,
Arend
> On Thu, Nov 20, 2014 at 10:27:01PM +0100, Arend van Spriel wrote:
>> The hardware info now also include radio and phy information, which
>> can be helpful in debugging issues.
>>
>> Reviewed-by: Hante Meuleman<[email protected]>
>> Reviewed-by: Pieter-Paul Giesberts<[email protected]>
>> Signed-off-by: Arend van Spriel<[email protected]>
>> ---
>> drivers/net/wireless/brcm80211/brcmsmac/debug.c | 40 +++++++++++++++++--------
>> 1 file changed, 27 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/debug.c b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
>> index 19740c1..c9a8b93 100644
>> --- a/drivers/net/wireless/brcm80211/brcmsmac/debug.c
>> +++ b/drivers/net/wireless/brcm80211/brcmsmac/debug.c
>> @@ -30,6 +30,7 @@
>> #include "main.h"
>> #include "debug.h"
>> #include "brcms_trace_events.h"
>> +#include "phy/phy_int.h"
>>
>> static struct dentry *root_folder;
>>
>> @@ -74,20 +75,33 @@ static
>> int brcms_debugfs_hardware_read(struct seq_file *s, void *data)
>> {
>> struct brcms_pub *drvr = s->private;
>> + struct brcms_hardware *hw = drvr->wlc->hw;
>> + struct bcma_device *core = hw->d11core;
>> + struct bcma_bus *bus = core->bus;
>> + char boardrev[10];
>>
>> - seq_printf(s, "board vendor: %x\n"
>> - "board type: %x\n"
>> - "board revision: %x\n"
>> - "board flags: %x\n"
>> - "board flags2: %x\n"
>> - "firmware revision: %x\n",
>> - drvr->wlc->hw->d11core->bus->boardinfo.vendor,
>> - drvr->wlc->hw->d11core->bus->boardinfo.type,
>> - drvr->wlc->hw->boardrev,
>> - drvr->wlc->hw->boardflags,
>> - drvr->wlc->hw->boardflags2,
>> - drvr->wlc->ucode_rev);
>> -
>> + seq_printf(s, "chipnum 0x%x\n"
>> + "chiprev 0x%x\n"
>> + "chippackage 0x%x\n"
>> + "corerev 0x%x\n"
>> + "boardid 0x%x\n"
>> + "boardvendor 0x%x\n"
>> + "boardrev %s\n"
>> + "boardflags 0x%x\n"
>> + "boardflags2 0x%x\n"
>> + "ucoderev 0x%x\n"
>> + "radiorev 0x%x\n"
>> + "phytype 0x%x\n"
>> + "phyrev 0x%x\n"
>> + "anarev 0x%x\n"
>> + "nvramrev %d\n",
>> + bus->chipinfo.id, bus->chipinfo.rev, bus->chipinfo.pkg,
>> + core->id.rev, bus->boardinfo.type, bus->boardinfo.vendor,
>> + brcmu_boardrev_str(hw->boardrev, boardrev),
>> + drvr->wlc->hw->boardflags, drvr->wlc->hw->boardflags2,
>> + drvr->wlc->ucode_rev, hw->band->radiorev,
>> + hw->band->phytype, hw->band->phyrev, hw->band->pi->ana_rev,
>> + hw->sromrev);
>> return 0;
>> }
>>
>> --
>> 1.9.1
>>
>>
>