2017-08-30 20:52:32

by Igor Mitsyanko

Subject: [PATCH] nl80211: look for HT/VHT capabilities in beacon's tail

From: Igor Mitsyanko <[email protected]>

There are no HT/VHT capabilities in cfg80211_ap_settings::beacon_ies,
these should be looked for in beacon's tail instead.

Signed-off-by: Igor Mitsyanko <[email protected]>
---

This is true for hostapd (at least the one in mainline): it does not
include HT/VHT caps and WLAN_EID_SUPP_RATES into beacon_ies.
But worth noting that there is no clear documentation that I could find
on what IEs could and could not be included into beacon_ies.

net/wireless/nl80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 8ce8542..0df8023 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -3791,8 +3791,8 @@ static void nl80211_check_ap_rate_selectors(struct cfg80211_ap_settings *params,
static void nl80211_calculate_ap_params(struct cfg80211_ap_settings *params)
{
const struct cfg80211_beacon_data *bcn = &params->beacon;
- size_t ies_len = bcn->beacon_ies_len;
- const u8 *ies = bcn->beacon_ies;
+ size_t ies_len = bcn->tail_len;
+ const u8 *ies = bcn->tail;
const u8 *rates;
const u8 *cap;

--
2.9.5

2017-10-02 15:34:40

by Sergey Matyukevich

Subject: Re: [PATCH] nl80211: look for HT/VHT capabilities in beacon's tail

On Wed, Aug 30, 2017 at 01:52:25PM -0700, [email protected] wrote:

> There are no HT/VHT capabilities in cfg80211_ap_settings::beacon_ies,
> these should be looked for in beacon's tail instead.
>
> Signed-off-by: Igor Mitsyanko <[email protected]>
> ---
>
> This is true for hostapd (at least the one in mainline): it does not
> include HT/VHT caps and WLAN_EID_SUPP_RATES into beacon_ies.
> But worth noting that there is no clear documentation that I could find
> on what IEs could and could not be included into beacon_ies.
>
> net/wireless/nl80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Hello Johannes,

Any comments on this change ?

Regards,
Sergey

2017-10-02 15:57:22

by Johannes Berg

Subject: Re: [PATCH] nl80211: look for HT/VHT capabilities in beacon's tail

On Mon, 2017-10-02 at 18:34 +0300, Sergey Matyukevich wrote:
> On Wed, Aug 30, 2017 at 01:52:25PM -0700, igor.mitsyanko.os@quantenna
> .com wrote:
>
> > There are no HT/VHT capabilities in
> > cfg80211_ap_settings::beacon_ies,
> > these should be looked for in beacon's tail instead.
> >
> > Signed-off-by: Igor Mitsyanko <[email protected]>
> > ---
> >
> > This is true for hostapd (at least the one in mainline): it does
> > not
> > include HT/VHT caps and WLAN_EID_SUPP_RATES into beacon_ies.
> > But worth noting that there is no clear documentation that I could
> > find
> > on what IEs could and could not be included into beacon_ies.
> >
> > net/wireless/nl80211.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Hello Johannes,
>
> Any comments on this change ?

It's already in linux.git ...

johannes