2018-08-20 22:05:22

by Larry Finger

Subject: [PATCH] rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument

In gcc8, when the 3rd argument (size) of a call to strncpy() matches the
length of the first argument, the compiler warns of the possibility of an
unterminated string. Using strlcpy() forces a null at the end.

Signed-off-by: Larry Finger <[email protected]>
---
drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c
index c2d5b495c179..c089540116fa 100644
--- a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c
+++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c
@@ -146,7 +146,7 @@ static int rtl8187_register_led(struct ieee80211_hw *dev,
led->dev = dev;
led->ledpin = ledpin;
led->is_radio = is_radio;
- strncpy(led->name, name, sizeof(led->name));
+ strlcpy(led->name, name, sizeof(led->name));

led->led_dev.name = led->name;
led->led_dev.default_trigger = default_trigger;
--
2.18.0

2018-08-31 19:54:40

by Kalle Valo

Subject: Re: [PATCH] rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument

Larry Finger <[email protected]> wrote:

> In gcc8, when the 3rd argument (size) of a call to strncpy() matches the
> length of the first argument, the compiler warns of the possibility of an
> unterminated string. Using strlcpy() forces a null at the end.
>
> Signed-off-by: Larry Finger <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

199ba9faca90 rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument

--
https://patchwork.kernel.org/patch/10570639/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches