On Fri, Mar 08, 2019 at 09:55:43PM +0800, [email protected] wrote:
> From: Yan-Hsuan Chuang <[email protected]>
>
> The rtlwifi driver is conflicting with Realtek's new 802.11ac chip
> series driver rtw88, remove it to avoid racing with the same ID.
>
> The rtw88 driver can be found at drivers/net/wireless/realtek/rtw88
The only objection I have here is that your new driver does not support
all of the devices that this driver does. So why not just rip out the
PCI stuff for the staging driver until the USB/SDIO code gets added to
the new one, and then you can drop the rest of this code?
thanks,
greg k-h
On 3/8/19 8:06 AM, Greg KH wrote:
> On Fri, Mar 08, 2019 at 09:55:43PM +0800, [email protected] wrote:
>> From: Yan-Hsuan Chuang <[email protected]>
>>
>> The rtlwifi driver is conflicting with Realtek's new 802.11ac chip
>> series driver rtw88, remove it to avoid racing with the same ID.
>>
>> The rtw88 driver can be found at drivers/net/wireless/realtek/rtw88
>
> The only objection I have here is that your new driver does not support
> all of the devices that this driver does. So why not just rip out the
> PCI stuff for the staging driver until the USB/SDIO code gets added to
> the new one, and then you can drop the rest of this code?
Greg,
The staging driver only supports PCI ID 0x10ec:0xB822, whereas the new one
supports that ID plus 0x10ec:0xC822. There will not be any devices dropped when
the staging code is deleted as long as the new driver is added.
Larry
On Fri, Mar 08, 2019 at 11:20:11AM -0600, Larry Finger wrote:
> On 3/8/19 8:06 AM, Greg KH wrote:
> > On Fri, Mar 08, 2019 at 09:55:43PM +0800, [email protected] wrote:
> > > From: Yan-Hsuan Chuang <[email protected]>
> > >
> > > The rtlwifi driver is conflicting with Realtek's new 802.11ac chip
> > > series driver rtw88, remove it to avoid racing with the same ID.
> > >
> > > The rtw88 driver can be found at drivers/net/wireless/realtek/rtw88
> >
> > The only objection I have here is that your new driver does not support
> > all of the devices that this driver does. So why not just rip out the
> > PCI stuff for the staging driver until the USB/SDIO code gets added to
> > the new one, and then you can drop the rest of this code?
>
> Greg,
>
> The staging driver only supports PCI ID 0x10ec:0xB822, whereas the new one
> supports that ID plus 0x10ec:0xC822. There will not be any devices dropped
> when the staging code is deleted as long as the new driver is added.
Ah, ok, all of those "*usb*" files in that driver directory lied :)
If there's no regression of devices, then I have no objection to this:
Acked-by: Greg Kroah-Hartman <[email protected]>
thanks,
greg k-h