2019-08-14 08:51:57

by Stanislaw Gruszka

[permalink] [raw]
Subject: Re: Ap mode regression in linux-5.3-rc1 in rt2800usb

(cc linux-wireless mailing list)

On Tue, Aug 13, 2019 at 09:50:00PM +0300, Emil Karlson wrote:
> Greetings
>
> After upgrading my ap running rt2800usb to linux-5.3-rc1 I noticed an
> unusual problem of not being able to connect to my ap with my android
> devices (nexus7/flo and nexus5x/bullhead), from tcpdump it seemed ap
> was receiving packets from the android devices after successful
> association, but android devices were not seeing the dhcp replies.
>
> I reverted drivers/net/wireless/ralink to the state it is in v5.2.8 and
> android clients can connect again normally. I did not explicitly set
> watchdog parameter to any value.
>
> Do you have any insights or is this already fixed?

Most likely is not fixed. We have those new commits in 5.3:

41a531ffa4c5 rt2x00usb: fix rx queue hang
0f47aeeada2a rt2800: do not enable watchdog by default
e403fa31ed71 rt2x00: add restart hw
710e6cc1595e rt2800: do not nullify initialization vector data
09db3b000619 rt2800: add pre_reset_hw callback
759c5b599cf4 rt2800: initial watchdog implementation
2034afe4db4a rt2800: add helpers for reading dma done index
9f3e3323e996 rt2x00: allow to specify watchdog interval

Most suspicious are 710e6cc1595e and 41a531ffa4c5 .

Could you test by reverting one single commit on 5.3
(first 710e6cc1595e and if that not help 41a531ffa4c5)
and check if it makes the problem gone?

Stanislaw


2019-08-16 08:00:40

by Emil Karlson

[permalink] [raw]
Subject: Re: Ap mode regression in linux-5.3-rc1 in rt2800usb

Greetings

On Wed, 14 Aug 2019 10:50:19 +0200
Stanislaw Gruszka <[email protected]> wrote:

> (cc linux-wireless mailing list)
>
> On Tue, Aug 13, 2019 at 09:50:00PM +0300, Emil Karlson wrote:
> > Greetings
> >
> > After upgrading my ap running rt2800usb to linux-5.3-rc1 I noticed
> > an unusual problem of not being able to connect to my ap with my
> > android devices (nexus7/flo and nexus5x/bullhead), from tcpdump it
> > seemed ap was receiving packets from the android devices after
> > successful association, but android devices were not seeing the
> > dhcp replies.
> >
> > I reverted drivers/net/wireless/ralink to the state it is in v5.2.8
> > and android clients can connect again normally. I did not
> > explicitly set watchdog parameter to any value.

> Most suspicious are 710e6cc1595e and 41a531ffa4c5 .

It seems to me that reverting only
710e6cc1595e25378c4b9977f7a8b4ad4a72a109
allows all my android devices to successfully connect to the internet.

Best Regards
-Emil

2019-08-16 09:35:27

by Stanislaw Gruszka

[permalink] [raw]
Subject: Re: Ap mode regression in linux-5.3-rc1 in rt2800usb

On Fri, Aug 16, 2019 at 11:00:12AM +0300, Emil Karlson wrote:
> Greetings
>
> On Wed, 14 Aug 2019 10:50:19 +0200
> Stanislaw Gruszka <[email protected]> wrote:
>
> > (cc linux-wireless mailing list)
> >
> > On Tue, Aug 13, 2019 at 09:50:00PM +0300, Emil Karlson wrote:
> > > Greetings
> > >
> > > After upgrading my ap running rt2800usb to linux-5.3-rc1 I noticed
> > > an unusual problem of not being able to connect to my ap with my
> > > android devices (nexus7/flo and nexus5x/bullhead), from tcpdump it
> > > seemed ap was receiving packets from the android devices after
> > > successful association, but android devices were not seeing the
> > > dhcp replies.
> > >
> > > I reverted drivers/net/wireless/ralink to the state it is in v5.2.8
> > > and android clients can connect again normally. I did not
> > > explicitly set watchdog parameter to any value.
>
> > Most suspicious are 710e6cc1595e and 41a531ffa4c5 .
>
> It seems to me that reverting only
> 710e6cc1595e25378c4b9977f7a8b4ad4a72a109
> allows all my android devices to successfully connect to the internet.

Please test attached patch as proposed fix for
710e6cc1595e25378c4b9977f7a8b4ad4a72a109 and report back. Thanks.

Stanislaw


Attachments:
(No filename) (1.21 kB)
rt2x00_clear_ivs_on_start.patch (2.72 kB)
Download all attachments

2019-08-19 06:08:40

by Emil Karlson

[permalink] [raw]
Subject: Re: Ap mode regression in linux-5.3-rc1 in rt2800usb

Hi

On Fri, 16 Aug 2019 11:33:02 +0200
Stanislaw Gruszka <[email protected]> wrote:

> > > > After upgrading my ap running rt2800usb to linux-5.3-rc1 I
> > > > noticed an unusual problem of not being able to connect to my
> > > > ap with my android devices (nexus7/flo and nexus5x/bullhead),
> > > > from tcpdump it seemed ap was receiving packets from the
> > > > android devices after successful association, but android
> > > > devices were not seeing the dhcp replies.
> > > >
> > > > I reverted drivers/net/wireless/ralink to the state it is in
> > > > v5.2.8 and android clients can connect again normally. I did not
> > > > explicitly set watchdog parameter to any value.
> >
> > > Most suspicious are 710e6cc1595e and 41a531ffa4c5 .
> >
> > It seems to me that reverting only
> > 710e6cc1595e25378c4b9977f7a8b4ad4a72a109
> > allows all my android devices to successfully connect to the
> > internet.
>
> Please test attached patch as proposed fix for
> 710e6cc1595e25378c4b9977f7a8b4ad4a72a109 and report back. Thanks.

After some testing it seems attached patch fixes the regression with no
observed negative side effects. Thanks.

Best Regards
-Emil