2019-12-04 18:19:06

by John Crispin

[permalink] [raw]
Subject: [PATCH V2 3/9] ath11k: drop memset when setting up a tx cmd desc

There is no point in zero'ing out the structure if we set all values in the
following line.

Signed-off-by: John Crispin <[email protected]>
---
drivers/net/wireless/ath/ath11k/dp_tx.c | 2 --
drivers/net/wireless/ath/ath11k/hal_tx.c | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c
index a8b9557c2346..28ebc414533e 100644
--- a/drivers/net/wireless/ath/ath11k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
@@ -167,8 +167,6 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *arvif,
skb_cb->vif = arvif->vif;
skb_cb->ar = ar;

- memset(cached_desc, 0, HAL_TCL_DESC_LEN);
-
ath11k_hal_tx_cmd_desc_setup(ab, cached_desc, &ti);

hal_ring_id = tx_ring->tcl_data_ring.ring_id;
diff --git a/drivers/net/wireless/ath/ath11k/hal_tx.c b/drivers/net/wireless/ath/ath11k/hal_tx.c
index cbe549798762..72a51ed65a51 100644
--- a/drivers/net/wireless/ath/ath11k/hal_tx.c
+++ b/drivers/net/wireless/ath/ath11k/hal_tx.c
@@ -71,6 +71,7 @@ void ath11k_hal_tx_cmd_desc_setup(struct ath11k_base *ab, void *cmd,
ti->dscp_tid_tbl_idx) |
FIELD_PREP(HAL_TCL_DATA_CMD_INFO3_SEARCH_INDEX,
ti->bss_ast_hash);
+ tcl_cmd->info4 = 0;
}

/* Commit the descriptor to hardware */
--
2.20.1