2020-03-18 09:54:36

by Tony Chuang

[permalink] [raw]
Subject: [PATCH] rtw88: 8822c: config RF table path B before path A

From: Yan-Hsuan Chuang <[email protected]>

After MAC switched power, the hardware's RF registers will have
its default value, but the default value for path B is incorrect.
So, load RF path B first, to decrease the period between MAC on
and RF path B config.

By test, if we load path A first, then there's ~300ms that the
path B is incorrect, it could lead to BT coex's A2DP glitch.
But if we configure path B first, there will only have ~3ms,
significantly lower possibility to have A2DP sound glitch.

Signed-off-by: Yan-Hsuan Chuang <[email protected]>
---
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index 146f693c7592..d2469f91976b 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -4128,7 +4128,7 @@ struct rtw_chip_info rtw8822c_hw_spec = {
.agc_tbl = &rtw8822c_agc_tbl,
.bb_tbl = &rtw8822c_bb_tbl,
.rfk_init_tbl = &rtw8822c_array_mp_cal_init_tbl,
- .rf_tbl = {&rtw8822c_rf_a_tbl, &rtw8822c_rf_b_tbl},
+ .rf_tbl = {&rtw8822c_rf_b_tbl, &rtw8822c_rf_a_tbl},
.rfe_defs = rtw8822c_rfe_defs,
.rfe_defs_size = ARRAY_SIZE(rtw8822c_rfe_defs),
.en_dis_dpd = true,
--
2.17.1


2020-03-23 17:34:51

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] rtw88: 8822c: config RF table path B before path A

<[email protected]> wrote:

> From: Yan-Hsuan Chuang <[email protected]>
>
> After MAC switched power, the hardware's RF registers will have
> its default value, but the default value for path B is incorrect.
> So, load RF path B first, to decrease the period between MAC on
> and RF path B config.
>
> By test, if we load path A first, then there's ~300ms that the
> path B is incorrect, it could lead to BT coex's A2DP glitch.
> But if we configure path B first, there will only have ~3ms,
> significantly lower possibility to have A2DP sound glitch.
>
> Signed-off-by: Yan-Hsuan Chuang <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

11a64888c79b rtw88: 8822c: config RF table path B before path A

--
https://patchwork.kernel.org/patch/11444805/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches