Hi all,
In commit
ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
Fixes tag
Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
Hi Larry,
On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <[email protected]> wrote:
>
> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
> >
> > In commit
> >
> > ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
> >
> > Fixes tag
> >
> > Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
>
> I do not understand what you want here. The subject describes what was fixed.
> The error has been in the driver since it was merged. The Fixes: line is a
> description of the commit that introduced the driver file with the error.
The subject I was referring to is the subject quoted in the Fixes tag,
not the subject of the fixing commit. So:
Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
Its not very important, just a consistency thing - I wouldn't bother
rebasing just to fix this, just for the future ...
--
Cheers,
Stephen Rothwell
Stephen Rothwell <[email protected]> writes:
> Hi Larry,
>
> On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <[email protected]> wrote:
>>
>> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
>> >
>> > In commit
>> >
>> > ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
>> >
>> > Fixes tag
>> >
>> > Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
>> >
>> > has these problem(s):
>> >
>> > - Subject does not match target commit subject
>> > Just use
>> > git log -1 --format='Fixes: %h ("%s")'
>>
>> I do not understand what you want here. The subject describes what was fixed.
>> The error has been in the driver since it was merged. The Fixes: line is a
>> description of the commit that introduced the driver file with the error.
>
> The subject I was referring to is the subject quoted in the Fixes tag,
> not the subject of the fixing commit. So:
>
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for
> legacy BCM43xx devices")
>
> Its not very important, just a consistency thing - I wouldn't bother
> rebasing just to fix this, just for the future ...
Yeah, I don't normally rebase wireless-drivers-next so this has to be
like this. But hopefully some time in the future I'll end up adding a
check for this in my patchwork script.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On 4/14/20 5:08 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
>
> Fixes tag
>
> Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
Stephan,
I do not understand what you want here. The subject describes what was fixed.
The error has been in the driver since it was merged. The Fixes: line is a
description of the commit that introduced the driver file with the error.
Larry
Stephen Rothwell <[email protected]> writes:
> In commit
>
> f8d6379932dd ("mt76: mt7663: fix the usage WoW with net detect support")
>
> Fixes tag
>
> Fixes: bd39bd2f00c3 ("mt76: mt7663: introduce WoW with net detect support")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a72ad451e704 ("mt76: mt7663: introduce WoW with net detect support")
Thanks for the report. I don't think this is bad enough to start
rebasing wireless-drivers-next so I'll leave it as is. But I'll try to
implement some kind of checking of Fixes tags in the future.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Stephen Rothwell <[email protected]> writes:
> Hi all,
>
> In commit
>
> ad96bc27032c ("brcmfmac: initialize the requested dwell time")
>
> Fixes tag
>
> Fixes: 4905432b28b7 ("brcmfmac: Fix P2P Group Formation failure via Go-neg method")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
>
> Maybe you meant
>
> Fixes: 9c29da3f4e7e ("brcmfmac: Fix P2P Group Formation failure via Go-neg method")
Heh, I noticed this and I even fixed it but maybe forgot to save my edit
or something. I'll need to be more careful next time.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Stephen Rothwell <[email protected]> writes:
> In commit
>
> 4c7e1711cf4c ("mt76: mt7915: fix potential memory leak in mcu message handler")
>
> Fixes tag
>
> Fixes: c6b002bcdfa6 ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Yeah, that should have been it but it's too much work to fix this now so
I'll just leave it be. Thanks for the report.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches