2021-06-24 07:51:05

by Liwei Song

Subject: [PATCH] mac80211: add dependency for MAC80211_LEDS

Let MAC80211_LEDS depends on LEDS_CLASS=IWLWIFI to fix the below warning:

WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
Selected by [m]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m])

Signed-off-by: Liwei Song <[email protected]>
---
net/mac80211/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 51ec8256b7fa..918a11fed563 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -69,7 +69,7 @@ config MAC80211_MESH
config MAC80211_LEDS
bool "Enable LED triggers"
depends on MAC80211
- depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
+ depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211 || LEDS_CLASS=IWLWIFI
select LEDS_TRIGGERS
help
This option enables a few LED triggers for different
--
2.17.1

2021-06-24 07:52:06

by Johannes Berg

Subject: Re: [PATCH] mac80211: add dependency for MAC80211_LEDS

On Thu, 2021-06-24 at 15:49 +0800, Liwei Song wrote:
> Let MAC80211_LEDS depends on LEDS_CLASS=IWLWIFI to fix the below warning:
>
> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>   Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
>   Selected by [m]:
>   - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m])
>
> Signed-off-by: Liwei Song <[email protected]>
> ---
>  net/mac80211/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
> index 51ec8256b7fa..918a11fed563 100644
> --- a/net/mac80211/Kconfig
> +++ b/net/mac80211/Kconfig
> @@ -69,7 +69,7 @@ config MAC80211_MESH
>  config MAC80211_LEDS
>   bool "Enable LED triggers"
>   depends on MAC80211
> - depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> + depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211 || LEDS_CLASS=IWLWIFI

Eh, no. this is the wrong way around. If anything needs to be fixed,
then it must be in iwlwifi, not the generic core part.

johannes

2021-06-24 09:13:44

by Liwei Song

Subject: Re: [PATCH] mac80211: add dependency for MAC80211_LEDS

On 6/24/21 15:51, Johannes Berg wrote:
> On Thu, 2021-06-24 at 15:49 +0800, Liwei Song wrote:
>> Let MAC80211_LEDS depends on LEDS_CLASS=IWLWIFI to fix the below warning:
>>
>> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>>   Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
>>   Selected by [m]:
>>   - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m])
>>
>> Signed-off-by: Liwei Song <[email protected]>
>> ---
>>  net/mac80211/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
>> index 51ec8256b7fa..918a11fed563 100644
>> --- a/net/mac80211/Kconfig
>> +++ b/net/mac80211/Kconfig
>> @@ -69,7 +69,7 @@ config MAC80211_MESH
>>  config MAC80211_LEDS
>>   bool "Enable LED triggers"
>>   depends on MAC80211
>> - depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
>> + depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211 || LEDS_CLASS=IWLWIFI
>
> Eh, no. this is the wrong way around. If anything needs to be fixed,
> then it must be in iwlwifi, not the generic core part.

Got it and thanks, I will try fix it in iwlwifi.

Thanks,
Liwei.

>
> johannes
>