2021-08-19 12:56:17

by Colin King

Subject: [PATCH] brcmsmac: make array addr static const, makes object smaller

From: Colin Ian King <[email protected]>

Don't populate the array addr on the stack but instead it
static const. Makes the object code smaller by 79 bytes:

Before:
text data bss dec hex filename
176015 54652 128 230795 3858b .../broadcom/brcm80211/brcmsmac/main.o

After:
text data bss dec hex filename
175872 54716 128 230716 3853c .../broadcom/brcm80211/brcmsmac/main.o

(gcc version 10.3.0)

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
index 26de1bd7fee9..8ddfc3d06687 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
@@ -704,7 +704,7 @@ static void brcms_c_write_inits(struct brcms_hardware *wlc_hw,
static void brcms_c_write_mhf(struct brcms_hardware *wlc_hw, u16 *mhfs)
{
u8 idx;
- u16 addr[] = {
+ static const u16 addr[] = {
M_HOST_FLAGS1, M_HOST_FLAGS2, M_HOST_FLAGS3, M_HOST_FLAGS4,
M_HOST_FLAGS5
};
--
2.32.0

2021-08-21 19:23:30

by Kalle Valo

Subject: Re: [PATCH] brcmsmac: make array addr static const, makes object smaller

Colin King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> Don't populate the array addr on the stack but instead it
> static const. Makes the object code smaller by 79 bytes:
>
> Before:
> text data bss dec hex filename
> 176015 54652 128 230795 3858b .../broadcom/brcm80211/brcmsmac/main.o
>
> After:
> text data bss dec hex filename
> 175872 54716 128 230716 3853c .../broadcom/brcm80211/brcmsmac/main.o
>
> (gcc version 10.3.0)
>
> Signed-off-by: Colin Ian King <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

0dc62413c882 brcmsmac: make array addr static const, makes object smaller

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches