2021-09-08 16:00:44

by Felix Fietkau

[permalink] [raw]

Subject: [PATCH] mt76: mt7915: fix WMM index on DBDC cards

---

WMM index range needs to be split between both PHYs if a second PHY exists.
The condition for that was accidentally written as checking if the vif PHY
is the secondary one

Signed-off-by: Felix Fietkau <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
index 748ea70ea12e..a19e68668c65 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
@@ -215,7 +215,7 @@ static int mt7915_add_interface(struct ieee80211_hw *hw,
mvif->phy = phy;
mvif->band_idx = ext_phy;

- if (ext_phy)
+ if (dev->mt76.phy2)
mvif->wmm_idx = ext_phy * (MT7915_MAX_WMM_SETS / 2) +
mvif->idx % (MT7915_MAX_WMM_SETS / 2);
else
--
2.30.1

2021-09-09 08:11:13

by Lorenzo Bianconi

[permalink] [raw]

Subject: Re: [PATCH] mt76: mt7915: fix WMM index on DBDC cards

---

> WMM index range needs to be split between both PHYs if a second PHY exists.
> The condition for that was accidentally written as checking if the vif PHY
> is the secondary one

We need to add the following Fixes tag here:

Fixes: e57b7901469fc ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")

Regards,
Lorenzo

>
> Signed-off-by: Felix Fietkau <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> index 748ea70ea12e..a19e68668c65 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> @@ -215,7 +215,7 @@ static int mt7915_add_interface(struct ieee80211_hw *hw,
> mvif->phy = phy;
> mvif->band_idx = ext_phy;
>
> - if (ext_phy)
> + if (dev->mt76.phy2)
> mvif->wmm_idx = ext_phy * (MT7915_MAX_WMM_SETS / 2) +
> mvif->idx % (MT7915_MAX_WMM_SETS / 2);
> else
> --
> 2.30.1
>

---

Attachments:

(No filename) (1.08 kB)
signature.asc (235.00 B)
Download all attachments