2021-10-09 21:41:22

by Christian Lamparter

[permalink] [raw]
Subject: [PATCH v1] ath9k: support DT ieee80211-freq-limit property to limit channels

The common DT property can be used to limit the available channels
but ath9k has to manually call wiphy_read_of_freq_limits().

Signed-off-by: Christian Lamparter <[email protected]>

---

I would have put this into ath9k_of_init(). But it didn't work there.
The reason is that in ath9k_of_init() the channels and bands are not yet
registered in the wiphy struct. So there isn't any channel to flag as
disabled.

---
drivers/net/wireless/ath/ath9k/init.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 1568730fc01e..0344d6f27275 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -1094,6 +1094,8 @@ int ath9k_init_device(u16 devid, struct ath_softc *sc,
ARRAY_SIZE(ath9k_tpt_blink));
#endif

+ wiphy_read_of_freq_limits(hw->wiphy);
+
/* Register with mac80211 */
error = ieee80211_register_hw(hw);
if (error)
--
2.33.0


2021-10-11 06:29:48

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v1] ath9k: support DT ieee80211-freq-limit property to limit channels

Christian Lamparter <[email protected]> writes:

> The common DT property can be used to limit the available channels
> but ath9k has to manually call wiphy_read_of_freq_limits().
>
> Signed-off-by: Christian Lamparter <[email protected]>
>
> ---
>
> I would have put this into ath9k_of_init(). But it didn't work there.
> The reason is that in ath9k_of_init() the channels and bands are not yet
> registered in the wiphy struct. So there isn't any channel to flag as
> disabled.

I think this is good info to have in the commit log, so in the pending
branch I did that.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2021-10-13 05:47:41

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v1] ath9k: support DT ieee80211-freq-limit property to limit channels

Christian Lamparter <[email protected]> wrote:

> The common DT property can be used to limit the available channels
> but ath9k has to manually call wiphy_read_of_freq_limits().
>
> I would have put this into ath9k_of_init(). But it didn't work there.
> The reason is that in ath9k_of_init() the channels and bands are not yet
> registered in the wiphy struct. So there isn't any channel to flag as
> disabled.
>
> Signed-off-by: Christian Lamparter <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

03469e79fee9 ath9k: support DT ieee80211-freq-limit property to limit channels

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches