2021-10-22 23:58:39

by Benjamin Li

Subject: [PATCH 0/2] wcn36xx: add missing 5GHz channels 136 and 144

Think Bryan's commit was accidentally lost during upstreaming of his original
WCN3680 support patches, so I've included it here.

Omitted Fixes: tag as this was a regression from downstream prima, but not a
regression from previous versions of wcn36xx.

Benjamin Li (1):
wcn36xx: add missing 5GHz channels 136 and 144

Bryan O'Donoghue (1):
wcn36xx: Switch on Antenna diversity feature bit

drivers/net/wireless/ath/wcn36xx/main.c | 2 ++
drivers/net/wireless/ath/wcn36xx/smd.c | 5 ++++-
2 files changed, 6 insertions(+), 1 deletion(-)

--
2.25.1

2021-10-22 23:58:48

by Benjamin Li

Subject: [PATCH 1/2] wcn36xx: Switch on Antenna diversity feature bit

From: Bryan O'Donoghue <[email protected]>

Switches on Antenna diversity feature bit.

Signed-off-by: Bryan O'Donoghue <[email protected]>
Signed-off-by: Benjamin Li <[email protected]>
---
drivers/net/wireless/ath/wcn36xx/smd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 3979171c92dd..be6442b3c80b 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -2394,8 +2394,10 @@ int wcn36xx_smd_feature_caps_exchange(struct wcn36xx *wcn)
INIT_HAL_MSG(msg_body, WCN36XX_HAL_FEATURE_CAPS_EXCHANGE_REQ);

set_feat_caps(msg_body.feat_caps, STA_POWERSAVE);
- if (wcn->rf_id == RF_IRIS_WCN3680)
+ if (wcn->rf_id == RF_IRIS_WCN3680) {
set_feat_caps(msg_body.feat_caps, DOT11AC);
+ set_feat_caps(msg_body.feat_caps, ANTENNA_DIVERSITY_SELECTION);
+ }

PREPARE_HAL_BUF(wcn->hal_buf, msg_body);

--
2.25.1

2021-10-25 08:24:35

by Kalle Valo

Subject: Re: [PATCH 1/2] wcn36xx: Switch on Antenna diversity feature bit

Benjamin Li <[email protected]> writes:

> From: Bryan O'Donoghue <[email protected]>
>
> Switches on Antenna diversity feature bit.

The commit log should answer to the question "why?":

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches