2021-11-26 16:57:41

by Shayne Chen

[permalink] [raw]
Subject: [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init

Set 6GHz cap to iftype data which is matched to the type of
current interface.

Fixes: 50ac15a511e3 ("mt76: mt7921: add 6GHz support")
Signed-off-by: Shayne Chen <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7921/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
index 5a64126..5540b2d 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
@@ -178,7 +178,7 @@ mt7921_init_he_caps(struct mt7921_phy *phy, enum nl80211_band band,
if (vht_cap->cap & IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN)
cap |= IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS;

- data->he_6ghz_capa.capa = cpu_to_le16(cap);
+ data[idx].he_6ghz_capa.capa = cpu_to_le16(cap);
}
idx++;
}
--
2.25.1



2021-11-27 14:45:39

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init

> Set 6GHz cap to iftype data which is matched to the type of
> current interface.

In this case data points to data[idx] since mt7921 supports just
NL80211_IFTYPE_STATION (please note idx = 0 and idx != i).
Anyway this can be an issue in the future when we will add more vif_type.
Maybe we can drop Fixes tag, not sure. Anyway:

Acked-by: Lorenzo Bianconi <[email protected]>

>
> Fixes: 50ac15a511e3 ("mt76: mt7921: add 6GHz support")
> Signed-off-by: Shayne Chen <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> index 5a64126..5540b2d 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> @@ -178,7 +178,7 @@ mt7921_init_he_caps(struct mt7921_phy *phy, enum nl80211_band band,
> if (vht_cap->cap & IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN)
> cap |= IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS;
>
> - data->he_6ghz_capa.capa = cpu_to_le16(cap);
> + data[idx].he_6ghz_capa.capa = cpu_to_le16(cap);
> }
> idx++;
> }
> --
> 2.25.1
>


Attachments:
(No filename) (1.20 kB)
signature.asc (228.00 B)
Download all attachments