Fix a coccinelle warning by removing condition with no possible effect
Signed-off-by: Praghadeesh T K S <[email protected]>
---
drivers/net/wireless/broadcom/b43/xmit.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireless/broadcom/b43/xmit.c
index 7651b1b..667a74b 100644
--- a/drivers/net/wireless/broadcom/b43/xmit.c
+++ b/drivers/net/wireless/broadcom/b43/xmit.c
@@ -169,12 +169,7 @@ static u16 b43_generate_tx_phy_ctl1(struct b43_wldev *dev, u8 bitrate)
const struct b43_phy *phy = &dev->phy;
const struct b43_tx_legacy_rate_phy_ctl_entry *e;
u16 control = 0;
- u16 bw;
-
- if (phy->type == B43_PHYTYPE_LP)
- bw = B43_TXH_PHY1_BW_20;
- else /* FIXME */
- bw = B43_TXH_PHY1_BW_20;
+ u16 bw = B43_TXH_PHY1_BW_20;
if (0) { /* FIXME: MIMO */
} else if (b43_is_cck_rate(bitrate) && phy->type != B43_PHYTYPE_LP) {
--
2.34.1
Am 25.06.2022 um 21:29 schrieb Praghadeesh T K S:
> Fix a coccinelle warning by removing condition with no possible effect
>
> Signed-off-by: Praghadeesh T K S <[email protected]>
> ---
> drivers/net/wireless/broadcom/b43/xmit.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireless/broadcom/b43/xmit.c
> index 7651b1b..667a74b 100644
> --- a/drivers/net/wireless/broadcom/b43/xmit.c
> +++ b/drivers/net/wireless/broadcom/b43/xmit.c
> @@ -169,12 +169,7 @@ static u16 b43_generate_tx_phy_ctl1(struct b43_wldev *dev, u8 bitrate)
> const struct b43_phy *phy = &dev->phy;
> const struct b43_tx_legacy_rate_phy_ctl_entry *e;
> u16 control = 0;
> - u16 bw;
> -
> - if (phy->type == B43_PHYTYPE_LP)
> - bw = B43_TXH_PHY1_BW_20;
> - else /* FIXME */
> - bw = B43_TXH_PHY1_BW_20;
> + u16 bw = B43_TXH_PHY1_BW_20;
Can you check if this is a possible register typo?
>
> if (0) { /* FIXME: MIMO */
> } else if (b43_is_cck_rate(bitrate) && phy->type != B43_PHYTYPE_LP) {
On Sun, Jun 26, 2022 at 01:03:57PM +0200, Sebastian Gottschall wrote:
> Am 25.06.2022 um 21:29 schrieb Praghadeesh T K S:
> > Fix a coccinelle warning by removing condition with no possible effect
> >
> > Signed-off-by: Praghadeesh T K S <[email protected]>
> > ---
> > drivers/net/wireless/broadcom/b43/xmit.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireless/broadcom/b43/xmit.c
> > index 7651b1b..667a74b 100644
> > --- a/drivers/net/wireless/broadcom/b43/xmit.c
> > +++ b/drivers/net/wireless/broadcom/b43/xmit.c
> > @@ -169,12 +169,7 @@ static u16 b43_generate_tx_phy_ctl1(struct b43_wldev *dev, u8 bitrate)
> > const struct b43_phy *phy = &dev->phy;
> > const struct b43_tx_legacy_rate_phy_ctl_entry *e;
> > u16 control = 0;
> > - u16 bw;
> > -
> > - if (phy->type == B43_PHYTYPE_LP)
> > - bw = B43_TXH_PHY1_BW_20;
> > - else /* FIXME */
> > - bw = B43_TXH_PHY1_BW_20;
> > + u16 bw = B43_TXH_PHY1_BW_20;
Hi Praghadeesh
I assume you took a deep look at the FIXME, understand why it is
there, looked at the datasheet etc, and decided it is not in fact
broken. Hence it is safe to remove the FIXME. Please could you
summarise your findings in the commit messages.
Andrew
On Sun, 26 Jun 2022 13:03:57 +0200
Sebastian Gottschall <[email protected]> wrote:
> Am 25.06.2022 um 21:29 schrieb Praghadeesh T K S:
> > Fix a coccinelle warning by removing condition with no possible
> > effect
> >
> > Signed-off-by: Praghadeesh T K S <[email protected]>
> > ---
> > drivers/net/wireless/broadcom/b43/xmit.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/wireless/broadcom/b43/xmit.c
> > b/drivers/net/wireless/broadcom/b43/xmit.c index 7651b1b..667a74b
> > 100644 --- a/drivers/net/wireless/broadcom/b43/xmit.c
> > +++ b/drivers/net/wireless/broadcom/b43/xmit.c
> > @@ -169,12 +169,7 @@ static u16 b43_generate_tx_phy_ctl1(struct
> > b43_wldev *dev, u8 bitrate) const struct b43_phy *phy = &dev->phy;
> > const struct b43_tx_legacy_rate_phy_ctl_entry *e;
> > u16 control = 0;
> > - u16 bw;
> > -
> > - if (phy->type == B43_PHYTYPE_LP)
> > - bw = B43_TXH_PHY1_BW_20;
> > - else /* FIXME */
> > - bw = B43_TXH_PHY1_BW_20;
> > + u16 bw = B43_TXH_PHY1_BW_20;
> Can you check if this is a possible register typo?
I think use of this name was intentional.
The code is marked as being incomplete with /* FIXME */
This change removes the FIXME. Which is bad. It doesn't improve the
code. It reduces code quality by removing the
incompleteness documentation.
Please leave the code as-is.
--
Michael Büsch
https://bues.ch/