2023-01-09 08:46:21

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH] scripts: rpm: make clear that mkspec script contains 4.13 feature

On 1/9/2023 9:25 AM, Arend van Spriel wrote:
> A fix was made in the mkspec script [1] that uses a feature, ie. the
> OR expression, which requires RPM 4.13. However, the script indicates
> another minimum version. Lower versions may have success by using
> the --no-deps option as suggested, but feels like bumping the version
> to 4.13 is reasonable as it put me on the wrong track at first with
> RPM 4.11 on my Centos7 machine.

This should not have gone to the wireless list. Sorry for the noise. I
have updated the state in linux-wireless patchwork.

Regards,
Arend


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2023-01-09 10:46:26

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] scripts: rpm: make clear that mkspec script contains 4.13 feature

Hi.
Thanks for catching this.


On Mon, Jan 9, 2023 at 5:25 PM Arend van Spriel
<[email protected]> wrote:
>
> A fix was made in the mkspec script [1] that uses a feature, ie. the
> OR expression, which requires RPM 4.13. However, the script indicates
> another minimum version. Lower versions may have success by using
> the --no-deps option as suggested,


As far as I tested, CentOS 7 did not work with --no-deps solution.
It just ended up with a syntax error.





> but feels like bumping the version
> to 4.13 is reasonable as it put me on the wrong track at first with
> RPM 4.11 on my Centos7 machine.
>
> [1] https://lore.kernel.org/linux-kbuild/[email protected]/


This is already merged.

Please use

Commit 02a893bc9975 ("kbuild: rpm-pkg: add libelf-devel as alternative
for BuildRequires")

instead of the URL.





>
> Signed-off-by: Arend van Spriel <[email protected]>
> ---
> scripts/package/mkspec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> index adab28fa7f89..094e52c979a8 100755
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec
> @@ -1,7 +1,7 @@
> #!/bin/sh
> #
> # Output a simple RPM spec file.
> -# This version assumes a minimum of RPM 4.0.3.
> +# This version assumes a minimum of RPM 4.13
> #
> # The only gothic bit here is redefining install_post to avoid
> # stripping the symbols from files in the kernel which we want
> --
> 2.32.0
>


--
Best Regards
Masahiro Yamada