2023-06-05 15:29:32

by Shayne Chen

[permalink] [raw]
Subject: [PATCH v3 04/10] wifi: mt76: mt7996: init he and eht cap for AP_VLAN

From: Peter Chiu <[email protected]>

Init he and eht capabilities for AP_VLAN type. Without this patch, the
BA response from AP_VLAN will not include the ADDBA extension tag.

Signed-off-by: Peter Chiu <[email protected]>
Signed-off-by: Shayne Chen <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7996/init.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/init.c b/drivers/net/wireless/mediatek/mt76/mt7996/init.c
index f1b48cdda58f..004575a0479b 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/init.c
@@ -808,6 +808,7 @@ __mt7996_set_stream_he_eht_caps(struct mt7996_phy *phy,
switch (i) {
case NL80211_IFTYPE_STATION:
case NL80211_IFTYPE_AP:
+ case NL80211_IFTYPE_AP_VLAN:
#ifdef CONFIG_MAC80211_MESH
case NL80211_IFTYPE_MESH_POINT:
#endif
--
2.39.2



2023-06-22 16:09:13

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH v3 04/10] wifi: mt76: mt7996: init he and eht cap for AP_VLAN

On 05.06.23 17:21, Shayne Chen wrote:
> From: Peter Chiu <[email protected]>
>
> Init he and eht capabilities for AP_VLAN type. Without this patch, the
> BA response from AP_VLAN will not include the ADDBA extension tag.
If that's the case, then I think this is something that needs to be
fixed in mac80211 instead. Since interfaces with the AP_VLAN iftype are
not exposed to the driver, I don't see why the driver should register
capabilities for that type.

- Felix