2023-06-14 13:32:17

by Nicolas Cavallari

Subject: [PATCH] wifi: mac80211: Remove "Missing iftype sband data/EHT cap" spam

In mesh mode, ieee80211_chandef_he_6ghz_oper() is called by
mesh_matches_local() for every received mesh beacon.

On a 6 GHz mesh of a HE-only phy, this spams that the hardware does not
have EHT capabilities, even if the received mesh beacon does not have an
EHT element.

Unlike HE, not supporting EHT in the 6 GHz band is not an error so do
not print anything in this case.

Fixes: 5dca295dd767 ("mac80211: Add initial support for EHT and 320 MHz channels")

Signed-off-by: Nicolas Cavallari <[email protected]>
---
net/mac80211/util.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 3bd07a0a782f..325a1e107240 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -3801,10 +3801,8 @@ bool ieee80211_chandef_he_6ghz_oper(struct ieee80211_sub_if_data *sdata,
}

eht_cap = ieee80211_get_eht_iftype_cap(sband, iftype);
- if (!eht_cap) {
- sdata_info(sdata, "Missing iftype sband data/EHT cap");
+ if (!eht_cap)
eht_oper = NULL;
- }

he_6ghz_oper = ieee80211_he_6ghz_oper(he_oper);

--
2.40.1

2023-06-15 09:35:57

by Simon Horman

Subject: Re: [PATCH] wifi: mac80211: Remove "Missing iftype sband data/EHT cap" spam

On Wed, Jun 14, 2023 at 03:26:48PM +0200, Nicolas Cavallari wrote:
> In mesh mode, ieee80211_chandef_he_6ghz_oper() is called by
> mesh_matches_local() for every received mesh beacon.
>
> On a 6 GHz mesh of a HE-only phy, this spams that the hardware does not
> have EHT capabilities, even if the received mesh beacon does not have an
> EHT element.
>
> Unlike HE, not supporting EHT in the 6 GHz band is not an error so do
> not print anything in this case.
>
> Fixes: 5dca295dd767 ("mac80211: Add initial support for EHT and 320 MHz channels")
>
> Signed-off-by: Nicolas Cavallari <[email protected]>

Reviewed-by: Simon Horman <[email protected]>