2024-01-04 09:49:21

by Mingyen Hsieh

[permalink] [raw]
Subject: [PATCH] wifi: mt76: mt7925: fix the wrong data type for scan command

From: Ming Yen Hsieh <[email protected]>

For the member of 'struct scan_req_tlv', replace data type of
func_mask_ext from 'u8' to 'u32'.

Signed-off-by: Ming Yen Hsieh <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7925/mcu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
index 3c41e21303b1..82b7e277397f 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
@@ -208,7 +208,7 @@ struct scan_req_tlv {
__le16 channel_dwell_time; /* channel Dwell interval */
__le16 timeout_value;
__le16 probe_delay_time;
- u8 func_mask_ext;
+ u32 func_mask_ext;
};

struct scan_ssid_tlv {
--
2.18.0



2024-01-04 10:16:32

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH] wifi: mt76: mt7925: fix the wrong data type for scan command

On Jan 04, Mingyen Hsieh wrote:
> From: Ming Yen Hsieh <[email protected]>
>
> For the member of 'struct scan_req_tlv', replace data type of
> func_mask_ext from 'u8' to 'u32'.
>
> Signed-off-by: Ming Yen Hsieh <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt7925/mcu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> index 3c41e21303b1..82b7e277397f 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> @@ -208,7 +208,7 @@ struct scan_req_tlv {
> __le16 channel_dwell_time; /* channel Dwell interval */
> __le16 timeout_value;
> __le16 probe_delay_time;
> - u8 func_mask_ext;
> + u32 func_mask_ext;

should it be __le32? (even if it is not used yet)

Regards,
Lorenzo

> };
>
> struct scan_ssid_tlv {
> --
> 2.18.0
>

Attachments:
(No filename) (995.00 B)
 signature.asc (235.00 B)
 Download all attachments