Currently, the logic used to select the 6 GHz band is incorrect,
which may cause 6 GHz supported channels to not be updated properly.
This is because the 6 GHz Max frequency supported by the driver is
being compared to the Max frequency supported on the board. If in
some cases, the 6 GHz Max frequency supported on the board is less
than the defined 6 GHz Max frequency, all 6 GHz channels are disabled.
To address this, compare the max frequency supported by the board to
the defined 6 GHz Minimum frequency by the driver.
Similarly, when a dual mac card supports both 6 GHz and 5 GHz radios,
if the 5 GHz radio gets enumerated first before 6 GHz, the checks in
ath12k_mac_setup_channels_rates() can cause the 5 GHz channels which
were enabled earlier to get disabled when the 6 GHz channel list is
updated. This is because the Min 6 GHz frequency defined in the driver
is 5945 MHz, which should be 5925 MHz since channel 2 is not considered
currently, but the firmware can pass 5925 MHz as the minimum.
Hence, update the Min frequency supported by the driver to 5925 MHz.
In addition, ensure that the channel list update to firmware updates
only the channels that the current radio (ar) supports rather than
considering the wiphy support. This would be required when multiple pdevs
are supported in a wiphy and they support different ranges of frequencies
or bands as in single wiphy support.
Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
Signed-off-by: Sriram R <[email protected]>
---
drivers/net/wireless/ath/ath12k/core.h | 2 +-
drivers/net/wireless/ath/ath12k/mac.c | 2 +-
drivers/net/wireless/ath/ath12k/reg.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index ba0a30f1ea29..41e8bf1af169 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -425,7 +425,7 @@ struct ath12k_sta {
};
#define ATH12K_MIN_5G_FREQ 4150
-#define ATH12K_MIN_6G_FREQ 5945
+#define ATH12K_MIN_6G_FREQ 5925
#define ATH12K_MAX_6G_FREQ 7115
#define ATH12K_NUM_CHANS 100
#define ATH12K_MAX_5G_CHAN 173
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 88cec54c6c2e..f4e5dc363472 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -7198,7 +7198,7 @@ static int ath12k_mac_setup_channels_rates(struct ath12k *ar,
}
if (supported_bands & WMI_HOST_WLAN_5G_CAP) {
- if (reg_cap->high_5ghz_chan >= ATH12K_MAX_6G_FREQ) {
+ if (reg_cap->high_5ghz_chan >= ATH12K_MIN_6G_FREQ) {
channels = kmemdup(ath12k_6ghz_channels,
sizeof(ath12k_6ghz_channels), GFP_KERNEL);
if (!channels) {
diff --git a/drivers/net/wireless/ath/ath12k/reg.c b/drivers/net/wireless/ath/ath12k/reg.c
index f924bc13ccff..29542c46b094 100644
--- a/drivers/net/wireless/ath/ath12k/reg.c
+++ b/drivers/net/wireless/ath/ath12k/reg.c
@@ -103,7 +103,7 @@ int ath12k_reg_update_chan_list(struct ath12k *ar)
bands = hw->wiphy->bands;
for (band = 0; band < NUM_NL80211_BANDS; band++) {
- if (!bands[band])
+ if (!(ar->mac.sbands[band].channels && bands[band]))
continue;
for (i = 0; i < bands[band]->n_channels; i++) {
@@ -129,7 +129,7 @@ int ath12k_reg_update_chan_list(struct ath12k *ar)
ch = arg->channel;
for (band = 0; band < NUM_NL80211_BANDS; band++) {
- if (!bands[band])
+ if (!(ar->mac.sbands[band].channels && bands[band]))
continue;
for (i = 0; i < bands[band]->n_channels; i++) {
--
2.17.1
Sriram R <[email protected]> wrote:
> Currently, the logic used to select the 6 GHz band is incorrect,
> which may cause 6 GHz supported channels to not be updated properly.
> This is because the 6 GHz max frequency supported by the driver is
> being compared to the max frequency supported on the board. If in
> some cases, the 6 GHz max frequency supported on the board is less
> than the defined 6 GHz max frequency, all 6 GHz channels are disabled.
> To address this, compare the max frequency supported by the board to
> the defined 6 GHz minimum frequency by the driver.
>
> Similarly, when a dual mac card supports both 6 GHz and 5 GHz radios,
> if the 5 GHz radio gets enumerated first before 6 GHz, the checks in
> ath12k_mac_setup_channels_rates() can cause the 5 GHz channels which
> were enabled earlier to get disabled when the 6 GHz channel list is
> updated. This is because the min 6 GHz frequency defined in the driver
> is 5945 MHz, which should be 5925 MHz since channel 2 is not considered
> currently, but the firmware can pass 5925 MHz as the minimum.
> Hence, update the min frequency supported by the driver to 5925 MHz.
>
> In addition, ensure that the channel list update to firmware updates
> only the channels that the current radio (ar) supports rather than
> considering the wiphy support. This would be required when multiple pdevs
> are supported in a wiphy and they support different ranges of frequencies
> or bands as in single wiphy support.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Sriram R <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
I did because it looks odd for me that these are capitalised (could be wrong though):
s/Min/min/
s/Max/max/
Jeff, what do you think about that the patch and my changes?
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On 1/23/2024 1:32 AM, Kalle Valo wrote:
> Sriram R <[email protected]> wrote:
>
>> Currently, the logic used to select the 6 GHz band is incorrect,
>> which may cause 6 GHz supported channels to not be updated properly.
>> This is because the 6 GHz max frequency supported by the driver is
>> being compared to the max frequency supported on the board. If in
>> some cases, the 6 GHz max frequency supported on the board is less
>> than the defined 6 GHz max frequency, all 6 GHz channels are disabled.
>> To address this, compare the max frequency supported by the board to
>> the defined 6 GHz minimum frequency by the driver.
>>
>> Similarly, when a dual mac card supports both 6 GHz and 5 GHz radios,
>> if the 5 GHz radio gets enumerated first before 6 GHz, the checks in
>> ath12k_mac_setup_channels_rates() can cause the 5 GHz channels which
>> were enabled earlier to get disabled when the 6 GHz channel list is
>> updated. This is because the min 6 GHz frequency defined in the driver
>> is 5945 MHz, which should be 5925 MHz since channel 2 is not considered
>> currently, but the firmware can pass 5925 MHz as the minimum.
>> Hence, update the min frequency supported by the driver to 5925 MHz.
>>
>> In addition, ensure that the channel list update to firmware updates
>> only the channels that the current radio (ar) supports rather than
>> considering the wiphy support. This would be required when multiple pdevs
>> are supported in a wiphy and they support different ranges of frequencies
>> or bands as in single wiphy support.
>>
>> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>
>> Signed-off-by: Sriram R <[email protected]>
>> Signed-off-by: Kalle Valo <[email protected]>
>
> I did because it looks odd for me that these are capitalised (could be wrong though):
>
> s/Min/min/
> s/Max/max/
>
> Jeff, what do you think about that the patch and my changes?
>
Both the patch and your change LGTM
Acked-by: Jeff Johnson <[email protected]>
Sriram R <[email protected]> wrote:
> Currently, the logic used to select the 6 GHz band is incorrect,
> which may cause 6 GHz supported channels to not be updated properly.
> This is because the 6 GHz Max frequency supported by the driver is
> being compared to the Max frequency supported on the board. If in
> some cases, the 6 GHz Max frequency supported on the board is less
> than the defined 6 GHz Max frequency, all 6 GHz channels are disabled.
> To address this, compare the max frequency supported by the board to
> the defined 6 GHz Minimum frequency by the driver.
>
> Similarly, when a dual mac card supports both 6 GHz and 5 GHz radios,
> if the 5 GHz radio gets enumerated first before 6 GHz, the checks in
> ath12k_mac_setup_channels_rates() can cause the 5 GHz channels which
> were enabled earlier to get disabled when the 6 GHz channel list is
> updated. This is because the Min 6 GHz frequency defined in the driver
> is 5945 MHz, which should be 5925 MHz since channel 2 is not considered
> currently, but the firmware can pass 5925 MHz as the minimum.
> Hence, update the Min frequency supported by the driver to 5925 MHz.
>
> In addition, ensure that the channel list update to firmware updates
> only the channels that the current radio (ar) supports rather than
> considering the wiphy support. This would be required when multiple pdevs
> are supported in a wiphy and they support different ranges of frequencies
> or bands as in single wiphy support.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Sriram R <[email protected]>
> Acked-by: Jeff Johnson <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
67a48d937fac wifi: ath12k: Fix issues in channel list update
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches