2024-05-10 11:56:45

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH wireless-next] ath11k: Fix error path in ath11k_pcic_ext_irq_config

On Wed, May 08, 2024 at 11:59:01AM -0700, Breno Leitao wrote:
> If one of the dummy allocation fails in ath11k_pcic_ext_irq_config(),
> the previous allocated devices might leak due to returning without
> deallocating the devices.
>
> Instead of returning on the error path, deallocate all the previously
> allocated net_devices and then return.
>
> Fixes: bca592ead825 ("wifi: ath11k: allocate dummy net_device dynamically")
> Signed-off-by: Breno Leitao <[email protected]>

Reviewed-by: Simon Horman <[email protected]>