2021-03-04 15:48:45

by Ryder Lee

[permalink] [raw]
Subject: [PATCH v4] mt76: mt7615: add missing capabilities for DBDC

This improves performance for second phy.

Signed-off-by: Ryder Lee <[email protected]>
---
change since v4 - fix init order.
change since v3 - none.
change since v2 - adjust setup sequence.
---
drivers/net/wireless/mediatek/mt76/mt7615/init.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
index 88a2ee7e7143..e70e852c1af8 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
@@ -448,6 +448,9 @@ int mt7615_register_ext_phy(struct mt7615_dev *dev)

/* second phy can only handle 5 GHz */
mphy->cap.has_5ghz = true;
+ mphy->sband_5g.sband.ht_cap.cap |= IEEE80211_HT_CAP_LDPC_CODING;
+ mphy->sband_5g.sband.vht_cap.cap |=
+ IEEE80211_VHT_CAP_MAX_A_MPDU_LENGTH_EXPONENT_MASK;

/* mt7615 second phy shares the same hw queues with the primary one */
for (i = 0; i <= MT_TXQ_PSD ; i++)
--
2.18.0


2021-03-04 19:33:20

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH v4] mt76: mt7615: add missing capabilities for DBDC


On 2021-03-04 09:55, Ryder Lee wrote:
> This improves performance for second phy.
>
> Signed-off-by: Ryder Lee <[email protected]>I actually prefer v1 of this patch. You can fix the init order issues by
simply dropping the if (phy->mt76->cap.has_*) checks, since they are not
needed at all.

- Felix