2022-10-17 08:17:45

by Johannes Berg

[permalink] [raw]
Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi

On Mon, 2022-10-17 at 16:12 +0800, Wen Gong wrote:
> > >
> > I guess valid links wasn't set at that point yet?
> >
> > Anyway should also move out of rate_control_rate_init() and probably
> > into something like ieee80211_assoc_config_link()? That already does
> > some rx_nss calculations which is probably not great ...
>
> OK. I will test with my change internal now. And replace to use upstream
> change
>
> after someone fix it.
>

Well, I think you should try to fix it and submit the patch, I'm not
going to do it in the short term ... :)

johannes


2022-10-18 09:01:33

by Wen Gong

[permalink] [raw]
Subject: Re: wifi: mac80211: mlo rx nss value 0 of wifi

On 10/17/2022 4:14 PM, Johannes Berg wrote:
> On Mon, 2022-10-17 at 16:12 +0800, Wen Gong wrote:
>>> I guess valid links wasn't set at that point yet?
>>>
>>> Anyway should also move out of rate_control_rate_init() and probably
>>> into something like ieee80211_assoc_config_link()? That already does
>>> some rx_nss calculations which is probably not great ...
>> OK. I will test with my change internal now. And replace to use upstream
>> change
>>
>> after someone fix it.
>>
> Well, I think you should try to fix it and submit the patch, I'm not
> going to do it in the short term ... :)
unfortunately I am also busy at other place in at present:).????
>
> johannes