2020-02-19 08:56:16

by Ashish

[permalink] [raw]
Subject: Commit d1d1a96 in rtl8188ee module causes issues when connecting to my institute's wifi

The commit d1d1a96 (at
https://github.com/torvalds/linux/commit/d1d1a96bdb4408d02e2bfcb32b71aba165458a80?diff=unified)
in rtl8188ee module causes problems while connecting to my institute's
wifi. I am not able to connect to that wifi after this commit. The
journalctl output is at http://ix.io/28IX (look for "AP off, try to
reconnect now").

The problem is with removal of the struct. Adding the struct back in
trx.h solves the issue.


2020-02-19 17:05:55

by Larry Finger

[permalink] [raw]
Subject: Re: Commit d1d1a96 in rtl8188ee module causes issues when connecting to my institute's wifi

On 2/19/20 2:55 AM, Ashish wrote:
> The commit d1d1a96 (at
> https://github.com/torvalds/linux/commit/d1d1a96bdb4408d02e2bfcb32b71aba165458a80?diff=unified)
> in rtl8188ee module causes problems while connecting to my institute's wifi. I
> am not able to connect to that wifi after this commit. The journalctl output is
> at http://ix.io/28IX (look for "AP off, try to reconnect now").
>
> The problem is with removal of the struct. Adding the struct back in trx.h
> solves the issue.
>

As I have discussed with you in the other venues, that struct was never used,
and the only way it could have caused any effect is if the alignment of struct
phy_status_rpt is critical in some way I do not understand.

Please try the patch below and report back. That will restore the alignment
without all that mumbo-jumbo about little- vs big-endian.

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
index 917729807514..e17f70b4d199 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
@@ -561,6 +561,7 @@ static inline void clear_pci_tx_desc_content(__le32
*__pdesc, int _size)
rxmcs == DESC92C_RATE11M)

struct phy_status_rpt {
+ u8 padding[2];
u8 ch_corr[2];
u8 cck_sig_qual_ofdm_pwdb_all;
u8 cck_agc_rpt_ofdm_cfosho_a;

Larry