A few changes to reduce checkpatch.pl errors in the ath5k driver. For
the most part, I only fixed cosmetic things, and left the actual 'code
flow' untouched (hopefully)!
Diff is against wireless-testing HEAD.
Signed-off-by: John Daiker <[email protected]>
---
2008/10/17 Bob Copeland <[email protected]>:
> On Fri, Oct 17, 2008 at 3:16 PM, John Daiker <[email protected]> wrote:
>> A few changes to reduce checkpatch.pl errors in the ath5k driver. For the
>> most part, I only fixed cosmetic things, and left the actual 'code flow'
>> untouched (hopefully)!
>>
>> Diff is against wireless-testing HEAD.
>>
>> Signed-off-by: John Daiker <[email protected]>
>
> Please post patches inline if you can; they are easier to review that way.
>
> One easy way to convince yourself (and us) that there are no code changes
> is to compile with and without the patch and compare resulting binaries
> for no differences.
>
> All that said, I reviewed this one and it looks good...
>
> Reviewed-by: Bob Copeland <[email protected]>
>
> --
> Bob Copeland %% http://www.bobcopeland.com
>
Same here...
Acked-by: Nick Kossifidis <[email protected]>
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
On Fri, Oct 17, 2008 at 3:16 PM, John Daiker <[email protected]> wrote:
> A few changes to reduce checkpatch.pl errors in the ath5k driver. For the
> most part, I only fixed cosmetic things, and left the actual 'code flow'
> untouched (hopefully)!
>
> Diff is against wireless-testing HEAD.
>
> Signed-off-by: John Daiker <[email protected]>
Please post patches inline if you can; they are easier to review that way.
One easy way to convince yourself (and us) that there are no code changes
is to compile with and without the patch and compare resulting binaries
for no differences.
All that said, I reviewed this one and it looks good...
Reviewed-by: Bob Copeland <[email protected]>
--
Bob Copeland %% http://www.bobcopeland.com