2010-10-24 22:10:16

by Nicolas Kaiser

Subject: [PATCH] wireless/wl1271: remove redundant if-statement

Apparently the return value of wl1271_ps_elp_sleep never gets
checked anyway.

Signed-off-by: Nicolas Kaiser <[email protected]>
---
drivers/net/wireless/wl12xx/wl1271_event.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c
index 7b3f503..38ccef7 100644
--- a/drivers/net/wireless/wl12xx/wl1271_event.c
+++ b/drivers/net/wireless/wl12xx/wl1271_event.c
@@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,

/* go to extremely low power mode */
wl1271_ps_elp_sleep(wl);
- if (ret < 0)
- break;
break;
case EVENT_EXIT_POWER_SAVE_FAIL:
wl1271_debug(DEBUG_PSM, "PSM exit failed");
--
1.7.2.2

2010-10-25 13:31:19

by Nicolas Kaiser

Subject: [PATCH] wireless/wl1271: remove redundant if-statement v2

wl1271_ps_elp_sleep() is void and cannot return a value.

Signed-off-by: Nicolas Kaiser <[email protected]>
---
Sorry for the poor wording of the initial description.

drivers/net/wireless/wl12xx/wl1271_event.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c
index 7b3f503..38ccef7 100644
--- a/drivers/net/wireless/wl12xx/wl1271_event.c
+++ b/drivers/net/wireless/wl12xx/wl1271_event.c
@@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,

/* go to extremely low power mode */
wl1271_ps_elp_sleep(wl);
- if (ret < 0)
- break;
break;
case EVENT_EXIT_POWER_SAVE_FAIL:
wl1271_debug(DEBUG_PSM, "PSM exit failed");
--
1.7.2.2

2010-10-26 10:28:59

by Luciano Coelho

Subject: Re: [PATCH] wireless/wl1271: remove redundant if-statement v2

On Mon, 2010-10-25 at 15:30 +0200, ext Nicolas Kaiser wrote:
> wl1271_ps_elp_sleep() is void and cannot return a value.
>
> Signed-off-by: Nicolas Kaiser <[email protected]>
> ---
> Sorry for the poor wording of the initial description.
>
> drivers/net/wireless/wl12xx/wl1271_event.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c
> index 7b3f503..38ccef7 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_event.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_event.c
> @@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
>
> /* go to extremely low power mode */
> wl1271_ps_elp_sleep(wl);
> - if (ret < 0)
> - break;
> break;
> case EVENT_EXIT_POWER_SAVE_FAIL:
> wl1271_debug(DEBUG_PSM, "PSM exit failed");

Reviewed-by: Luciano Coelho <[email protected]>

Thanks! Applied to the wl12xx tree.

--
Cheers,
Luca.

2010-10-25 13:11:52

by Luciano Coelho

Subject: Re: [PATCH] wireless/wl1271: remove redundant if-statement

On Mon, 2010-10-25 at 00:24 +0200, ext Larry Finger wrote:
> On 10/24/2010 05:07 PM, Nicolas Kaiser wrote:
> > Apparently the return value of wl1271_ps_elp_sleep never gets
> > checked anyway.
>
> The patch is fine, but this comment is a little misleading as
> wl1271_ps_elp_sleep() is void and cannot return a value.

Yes, this patch is good, but please rewrite the description, as Larry
suggested.

--
Cheers,
Luca.

2010-10-24 22:24:05

by Larry Finger

Subject: Re: [PATCH] wireless/wl1271: remove redundant if-statement

On 10/24/2010 05:07 PM, Nicolas Kaiser wrote:
> Apparently the return value of wl1271_ps_elp_sleep never gets
> checked anyway.

The patch is fine, but this comment is a little misleading as
wl1271_ps_elp_sleep() is void and cannot return a value.

Larry