2011-04-19 20:03:20

by Carl J. Richell

Subject: rtlwifi: rtl8192ce: LED initialization

Hi wireless developers,

The patch at the following link fixes the wireless LED on rtl8192ce devices.

http://marc.info/?l=linux-wireless&m=130247823800466&w=2

However, there is the following Error when compiling against 2.6.38 in Ubuntu natty:

"
drivers/net/wireless/rtlwifi/rtl8192ce/led.c: In function ‘_rtl92ce_init_led’:
drivers/net/wireless/rtlwifi/rtl8192ce/led.c:40:6: error: ‘struct rtl_led’ has no member named ‘ledon’
make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192ce/led.o] Error 1
"

The driver compiles correctly and the LED works after commenting out the offending line:

wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/led.c

static void _rtl92ce_init_led(struct ieee80211_hw *hw,
struct rtl_led *pled, enum rtl_led_pin ledpin)
{
pled->hw = hw;
pled->ledpin = ledpin;
/* pled->ledon = false; */
}

Is this an appropriate fix?

Best Regards,


Carl Richell

2011-04-19 21:12:05

by Larry Finger

Subject: Re: rtlwifi: rtl8192ce: LED initialization

On 04/19/2011 02:57 PM, Carl J. Richell wrote:
> Hi wireless developers,
>
> The patch at the following link fixes the wireless LED on rtl8192ce devices.
>
> http://marc.info/?l=linux-wireless&m=130247823800466&w=2
>
> However, there is the following Error when compiling against 2.6.38 in Ubuntu natty:
>
> "
> drivers/net/wireless/rtlwifi/rtl8192ce/led.c: In function ‘_rtl92ce_init_led’:
> drivers/net/wireless/rtlwifi/rtl8192ce/led.c:40:6: error: ‘struct rtl_led’ has no member named ‘ledon’
> make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192ce/led.o] Error 1
> "
>
> The driver compiles correctly and the LED works after commenting out the offending line:
>
> wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
>
> static void _rtl92ce_init_led(struct ieee80211_hw *hw,
> struct rtl_led *pled, enum rtl_led_pin ledpin)
> {
> pled->hw = hw;
> pled->ledpin = ledpin;
> /* pled->ledon = false; */
> }
>
> Is this an appropriate fix?

The patch was made for 2.6.39.

For 2.6.38, the routine _rtl92ce_init_led() does not exist, thus some of the
other changes in rtl8192ce from .38 to .39 have been put into the driver, but
not all. Your change should be OK.

Larry

2011-04-19 21:18:19

by Carl J. Richell

Subject: Re: rtlwifi: rtl8192ce: LED initialization

----- Original Message -----
> On 04/19/2011 02:57 PM, Carl J. Richell wrote:
> > Hi wireless developers,
> >
> > The patch at the following link fixes the wireless LED on rtl8192ce
> > devices.
> >
> > http://marc.info/?l=linux-wireless&m=130247823800466&w=2
> >
> > However, there is the following Error when compiling against 2.6.38
> > in Ubuntu natty:
> >
> > "
> > drivers/net/wireless/rtlwifi/rtl8192ce/led.c: In function
> > ‘_rtl92ce_init_led’:
> > drivers/net/wireless/rtlwifi/rtl8192ce/led.c:40:6: error: ‘struct
> > rtl_led’ has no member named ‘ledon’
> > make[5]: *** [drivers/net/wireless/rtlwifi/rtl8192ce/led.o] Error 1
> > "
> >
> > The driver compiles correctly and the LED works after commenting out
> > the offending line:
> >
> > wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/led.c
> >
> > static void _rtl92ce_init_led(struct ieee80211_hw *hw,
> > struct rtl_led *pled, enum rtl_led_pin ledpin)
> > {
> > pled->hw = hw;
> > pled->ledpin = ledpin;
> > /* pled->ledon = false; */
> > }
> >
> > Is this an appropriate fix?
>
> The patch was made for 2.6.39.
>
> For 2.6.38, the routine _rtl92ce_init_led() does not exist, thus some
> of the
> other changes in rtl8192ce from .38 to .39 have been put into the
> driver, but
> not all. Your change should be OK.
>

Thank you, Larry. Much appreciated!


Carl