2011-12-16 18:55:41

by Rafał Miłecki

Subject: [RFC] b43: Rearranging functions in phy_n.c

Hey,

The order of functions in phy_n.c is really messy. I wanted to collect
related functions, fix order (dependency) and name goups via comments.

Is there anything I should know? Patches are going to be huge, tons of
lines moved around the phy_n.c :(

Are there any objections against that? Any suggestions if I should
post one huge patch or few smaller ones?

--
Rafał

2011-12-16 19:04:43

by Larry Finger

Subject: Re: [RFC] b43: Rearranging functions in phy_n.c

On 12/16/2011 12:55 PM, Rafał Miłecki wrote:
> Hey,
>
> The order of functions in phy_n.c is really messy. I wanted to collect
> related functions, fix order (dependency) and name goups via comments.
>
> Is there anything I should know? Patches are going to be huge, tons of
> lines moved around the phy_n.c :(
>
> Are there any objections against that? Any suggestions if I should
> post one huge patch or few smaller ones?

Several smaller ones always help the reviewer. I would vote for that option.

Larry