2012-01-12 09:32:22

by Raja Mani

Subject: [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs()

From: Raja Mani <[email protected]>

ath6kl_read_fwlogs() assigns the value zero to the variable 'ret'
at the time of declaration. Later, return value of ath6kl_diag_read32()
repalces the init value. Hence removing useless zero assignment.

Signed-off-by: Raja Mani <[email protected]>
---
drivers/net/wireless/ath/ath6kl/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
index eea3c74..51baec4 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -252,7 +252,7 @@ int ath6kl_read_fwlogs(struct ath6kl *ar)
struct ath6kl_dbglog_hdr debug_hdr;
struct ath6kl_dbglog_buf debug_buf;
u32 address, length, dropped, firstbuf, debug_hdr_addr;
- int ret = 0, loop;
+ int ret, loop;
u8 *buf;

buf = kmalloc(ATH6KL_FWLOG_PAYLOAD_SIZE, GFP_KERNEL);
--
1.7.1

2012-01-13 11:54:28

by Kalle Valo

Subject: Re: [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs()

On 01/12/2012 11:31 AM, [email protected] wrote:
> From: Raja Mani <[email protected]>
>
> ath6kl_read_fwlogs() assigns the value zero to the variable 'ret'
> at the time of declaration. Later, return value of ath6kl_diag_read32()
> repalces the init value. Hence removing useless zero assignment.
>
> Signed-off-by: Raja Mani <[email protected]>

Thanks, applied.

BTW, I only got patch 1/2. What happened to patch 2?

Kalle

2012-01-18 05:54:44

by Raja Mani

Subject: Re: [PATCH 1/2] ath6kl: Remove useless initialization in ath6kl_read_fwlogs()

On Friday 13 January 2012 05:24 PM, Kalle Valo wrote:
> On 01/12/2012 11:31 AM, [email protected] wrote:
>> From: Raja Mani<[email protected]>
>>
>> ath6kl_read_fwlogs() assigns the value zero to the variable 'ret'
>> at the time of declaration. Later, return value of ath6kl_diag_read32()
>> repalces the init value. Hence removing useless zero assignment.
>>
>> Signed-off-by: Raja Mani<[email protected]>
>
> Thanks, applied.
>
> BTW, I only got patch 1/2. What happened to patch 2?

Oops, I wanted to send only this patch.
It's a title mistake. Sorry about that.

>
> Kalle