2012-05-06 21:01:08

by Larry Finger

[permalink] [raw]
Subject: [PATCH] b43legacy: Fix error due to MMIO access with SSB unpowered

There is a dummy read of a PCI MMIO register that occurs before the SSB bus
has been powered, which is an error. This bug has not been seen earlier,
but was apparently exposed when udev was updated to version 182.

Signed-off-by: Larry Finger <[email protected]>
Cc: stable <[email protected]>
---

John,

This fix should be applied to 3.4.

Larry
---

Index: wireless-testing-new/drivers/net/wireless/b43legacy/main.c
===================================================================
--- wireless-testing-new.orig/drivers/net/wireless/b43legacy/main.c
+++ wireless-testing-new/drivers/net/wireless/b43legacy/main.c
@@ -1573,8 +1573,6 @@ static void b43legacy_request_firmware(s
const char *filename;
int err;

- /* do dummy read */
- ssb_read32(dev->dev, SSB_TMSHIGH);
if (!fw->ucode) {
if (rev == 2)
filename = "ucode2";