2022-08-22 16:52:54

by Johannes Berg

[permalink] [raw]
Subject: Re: Aw: Re: help for driver porting - missing member preset_chandef in struct wireless_dev

On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote:
> > Gesendet: Montag, 22. August 2022 um 17:02 Uhr
> > Von: "Johannes Berg" <[email protected]>
>
> > Yes. Make sure the driver doesn't access it, it should get stuff
> > through
> > other APIs.
>
> thanks for response, commented out the use of the member and the wdev
> assignment as it was then unused
> can you tell me which api-call this should be?
> i just want to make sure this is really done as i up-ported the driver
> from 4.9, so if the api-call was introduced later it is maybe missing.

No sorry, I don't know how the driver was/is using it, so I can't tell
you how to replace it.

johannes


2022-08-22 17:08:42

by Frank Wunderlich

[permalink] [raw]
Subject: Aw: Re: Re: help for driver porting - missing member preset_chandef in struct wireless_dev


> Gesendet: Montag, 22. August 2022 um 18:43 Uhr
> Von: "Johannes Berg" <[email protected]>

> On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote:

> > thanks for response, commented out the use of the member and the wdev
> > assignment as it was then unused
> > can you tell me which api-call this should be?
> > i just want to make sure this is really done as i up-ported the driver
> > from 4.9, so if the api-call was introduced later it is maybe missing.
>
> No sorry, I don't know how the driver was/is using it, so I can't tell
> you how to replace it.

can you give me possible calls (if there are multiple candidates) which may set the channel (without mesh)
for me to check or maybe implement?

> johannes

Frank

2022-08-22 19:22:55

by Johannes Berg

[permalink] [raw]
Subject: Re: Aw: Re: Re: help for driver porting - missing member preset_chandef in struct wireless_dev

On Mon, 2022-08-22 at 18:59 +0200, Frank Wunderlich wrote:
> > Gesendet: Montag, 22. August 2022 um 18:43 Uhr
> > Von: "Johannes Berg" <[email protected]>
>
> > On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote:
>
> > > thanks for response, commented out the use of the member and the
> > > wdev
> > > assignment as it was then unused
> > > can you tell me which api-call this should be?
> > > i just want to make sure this is really done as i up-ported the
> > > driver
> > > from 4.9, so if the api-call was introduced later it is maybe
> > > missing.
> >
> > No sorry, I don't know how the driver was/is using it, so I can't
> > tell
> > you how to replace it.
>
> can you give me possible calls (if there are multiple candidates)
> which may set the channel (without mesh)
> for me to check or maybe implement?

Well it seems to access it inside the start_ap callback, so it should
just check the configuration instea