2014-02-18 18:41:12

by Jouni Malinen

[permalink] [raw]
Subject: [PATCH] ath9k: Enable U-APSD AP mode support

mac80211 handles the actual operations, so ath9k can just indicate
support for this. Based on initial tests, this combination seems to
work fine.

Signed-off-by: Jouni Malinen <[email protected]>
---
drivers/net/wireless/ath/ath9k/init.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 07a0315..4856a17 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -949,6 +949,7 @@ static void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
hw->wiphy->flags |= WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL;
hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_5_10_MHZ;
hw->wiphy->flags |= WIPHY_FLAG_HAS_CHANNEL_SWITCH;
+ hw->wiphy->flags |= WIPHY_FLAG_AP_UAPSD;

hw->queues = 4;
hw->max_rates = 4;
--
1.7.9.5


--
Jouni Malinen PGP id EFC895FA


2014-02-19 09:48:26

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] ath9k: Enable U-APSD AP mode support

On Tue, 2014-02-18 at 23:18 +0100, Felix Fietkau wrote:
> On 2014-02-18 20:05, Johannes Berg wrote:
> > On Tue, 2014-02-18 at 20:41 +0200, Jouni Malinen wrote:
> >> mac80211 handles the actual operations, so ath9k can just indicate
> >> support for this. Based on initial tests, this combination seems to
> >> work fine.
> >
> > I believe this is not true with aggregation sessions.
> Why not? Block Ack Window handling is handled by
> .release_buffered_frames just fine (and tested with PS-Poll).

Yeah, n/m, I missed that you implemented that.

johannes


2014-02-18 19:06:06

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] ath9k: Enable U-APSD AP mode support

On Tue, 2014-02-18 at 20:41 +0200, Jouni Malinen wrote:
> mac80211 handles the actual operations, so ath9k can just indicate
> support for this. Based on initial tests, this combination seems to
> work fine.

I believe this is not true with aggregation sessions.

johannes


2014-02-18 22:18:53

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] ath9k: Enable U-APSD AP mode support

On 2014-02-18 20:05, Johannes Berg wrote:
> On Tue, 2014-02-18 at 20:41 +0200, Jouni Malinen wrote:
>> mac80211 handles the actual operations, so ath9k can just indicate
>> support for this. Based on initial tests, this combination seems to
>> work fine.
>
> I believe this is not true with aggregation sessions.
Why not? Block Ack Window handling is handled by
.release_buffered_frames just fine (and tested with PS-Poll).

- Felix