2017-10-14 09:41:20

by Christos Gkekas

Subject: [PATCH] ath10k: spectral: Remove redundant check

Variable val is unsigned, so checking whether it is less than zero is
redundant.

Signed-off-by: Christos Gkekas <[email protected]>
---
drivers/net/wireless/ath/ath10k/spectral.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c
index dd9cc09..2048b1e 100644
--- a/drivers/net/wireless/ath/ath10k/spectral.c
+++ b/drivers/net/wireless/ath/ath10k/spectral.c
@@ -406,7 +406,7 @@ static ssize_t write_file_spectral_count(struct file *file,
if (kstrtoul(buf, 0, &val))
return -EINVAL;

- if (val < 0 || val > 255)
+ if (val > 255)
return -EINVAL;

mutex_lock(&ar->conf_mutex);
--
2.7.4

2017-10-27 13:49:43

by Kalle Valo

Subject: Re: ath10k: spectral: Remove redundant check

Christos Gkekas <[email protected]> wrote:

> Variable val is unsigned, so checking whether it is less than zero is
> redundant.
>
> Signed-off-by: Christos Gkekas <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

d83c0d3293bb ath10k: spectral: remove redundant check in write_file_spectral_count()

--
https://patchwork.kernel.org/patch/10006335/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches