2022-12-27 20:27:11

by Sicelo A. Mhlongo

[permalink] [raw]
Subject: WLAN broken on Nokia N900 with v6.2-rc1

Hi

With linux 6.2-rc1, wlan is broken on the Nokia N900 with wl1251, while
it was working up to at least 6.1-rc7. The driver probes fine and I can
scan for networks. However it is not possible to connect to any.

dmesg contains the following:


[ 143.202484] WARNING: CPU: 0 PID: 1300 at net/wireless/core.c:1463 cfg80211_netdev_notifier_call+0x26d/0x30c [cfg80211]
[ 143.203613] Modules linked in: nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bnep cmt_speech nokia_modem ssi_protocol phonet radio_platform_si4713 joydev mousedev hsi_char wl1251_spi wl1251 mac80211 libarc4 omap3_rom_rng rng_core ir_rx51 pwm_omap_dmtimer rc_core snd_soc_rx51 rx51_battery isp1704_charger cpufreq_dt snd_soc_omap_mcbsp snd_soc_ti_sdma omap_wdt cfg80211 omap3_isp videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common omap_sham crypto_engine snd_soc_tlv320aic3x_i2c snd_soc_tlv320aic3x snd_soc_tpa6130a2 tsc2005 snd_soc_core regmap_spi snd_pcm_dmaengine tsc200x_core snd_pcm omap_mailbox snd_timer leds_lp5523 bq27xxx_battery_i2c snd si4713 leds_lp55xx_common bq27xxx_battery soundcore led_class tsl2563 twl4030_wdt hci_nokia rtc_twl hci_uart btbcm bluetooth twl4030_vibra pwm_twl_led pwm_twl ff_memless ecdh_generic twl4030_madc ecc rfkill libaes et8ek8 ad5820 v4l2_fwnode v4l2_async
[ 143.205780] st_accel_i2c st_sensors_i2c st_accel industrialio_triggered_buffer kfifo_buf st_sensors videodev industrialio omap_ssi mc hsi
[ 143.206146] CPU: 0 PID: 1300 Comm: NetworkManager Tainted: G W 6.2.0-rc1-nokia-n900+ #1
[ 143.206207] Hardware name: Nokia RX-51 board
[ 143.206268] unwind_backtrace from show_stack+0xb/0xc
[ 143.206390] show_stack from dump_stack_lvl+0x2b/0x34
[ 143.206512] dump_stack_lvl from __warn+0xdb/0xe8
[ 143.206604] __warn from warn_slowpath_fmt+0x3f/0x76
[ 143.206726] warn_slowpath_fmt from cfg80211_netdev_notifier_call+0x26d/0x30c [cfg80211]
[ 143.207519] cfg80211_netdev_notifier_call [cfg80211] from raw_notifier_call_chain+0x31/0x3c
[ 143.208282] raw_notifier_call_chain from __dev_notify_flags+0x3f/0x90
[ 143.208404] __dev_notify_flags from dev_change_flags+0x2d/0x34
[ 143.208496] dev_change_flags from do_setlink+0x20f/0xa98
[ 143.208587] do_setlink from rtnl_newlink+0x341/0x5f0
[ 143.208679] rtnl_newlink from rtnetlink_rcv_msg+0x193/0x218
[ 143.208770] rtnetlink_rcv_msg from netlink_rcv_skb+0x75/0xb0
[ 143.208892] netlink_rcv_skb from netlink_unicast+0x113/0x1b4
[ 143.208984] netlink_unicast from netlink_sendmsg+0x161/0x31c
[ 143.209106] netlink_sendmsg from ____sys_sendmsg+0x123/0x158
[ 143.209228] ____sys_sendmsg from ___sys_sendmsg+0x43/0x68
[ 143.209350] ___sys_sendmsg from sys_sendmsg+0x33/0x60
[ 143.209442] sys_sendmsg from ret_fast_syscall+0x1/0x5c
[ 143.209564] Exception stack(0xd0149fa8 to 0xd0149ff0)
[ 143.209625] 9fa0: 00000000 00000000 0000000d beabf550 00000000 00000000
[ 143.209686] 9fc0: 00000000 00000000 00000001 00000128 beabf67c beabf678 00000000 beabf674
[ 143.209747] 9fe0: beabf508 beabf4f8 b6fadcdb b6fad994
[ 143.209808] ---[ end trace 0000000000000000 ]---
[ 143.241180] ------------[ cut here ]------------
[ 143.241241] WARNING: CPU: 0 PID: 25 at net/wireless/scan.c:1021 cfg80211_scan_done+0x6b/0x124 [cfg80211]
[ 143.241912] Modules linked in: nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bnep cmt_speech nokia_modem ssi_protocol phonet radio_platform_si4713 joydev mousedev hsi_char wl1251_spi wl1251 mac80211 libarc4 omap3_rom_rng rng_core ir_rx51 pwm_omap_dmtimer rc_core snd_soc_rx51 rx51_battery isp1704_charger cpufreq_dt snd_soc_omap_mcbsp snd_soc_ti_sdma omap_wdt cfg80211 omap3_isp videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common omap_sham crypto_engine snd_soc_tlv320aic3x_i2c snd_soc_tlv320aic3x snd_soc_tpa6130a2 tsc2005 snd_soc_core regmap_spi snd_pcm_dmaengine tsc200x_core snd_pcm omap_mailbox snd_timer leds_lp5523 bq27xxx_battery_i2c snd si4713 leds_lp55xx_common bq27xxx_battery soundcore led_class tsl2563 twl4030_wdt hci_nokia rtc_twl hci_uart btbcm bluetooth twl4030_vibra pwm_twl_led pwm_twl ff_memless ecdh_generic twl4030_madc ecc rfkill libaes et8ek8 ad5820 v4l2_fwnode v4l2_async
[ 143.243041] st_accel_i2c st_sensors_i2c st_accel industrialio_triggered_buffer kfifo_buf st_sensors videodev industrialio omap_ssi mc hsi
[ 143.243225] CPU: 0 PID: 25 Comm: kworker/u2:2 Tainted: G W 6.2.0-rc1-nokia-n900+ #1
[ 143.243255] Hardware name: Nokia RX-51 board
[ 143.243286] Workqueue: phy0 ieee80211_scan_work [mac80211]
[ 143.243865] unwind_backtrace from show_stack+0xb/0xc
[ 143.243927] show_stack from dump_stack_lvl+0x2b/0x34
[ 143.243988] dump_stack_lvl from __warn+0xdb/0xe8
[ 143.244049] __warn from warn_slowpath_fmt+0x3f/0x76
[ 143.244110] warn_slowpath_fmt from cfg80211_scan_done+0x6b/0x124 [cfg80211]
[ 143.244598] cfg80211_scan_done [cfg80211] from __ieee80211_scan_completed+0x85/0x2d8 [mac80211]
[ 143.245269] __ieee80211_scan_completed [mac80211] from ieee80211_scan_work+0xdf/0x3b4 [mac80211]
[ 143.245849] ieee80211_scan_work [mac80211] from process_one_work+0x153/0x35c
[ 143.246185] process_one_work from worker_thread+0xd9/0x3d4
[ 143.246246] worker_thread from kthread+0xad/0xc0
[ 143.246276] kthread from ret_from_fork+0x11/0x20
[ 143.246337] Exception stack(0xd0085fb0 to 0xd0085ff8)
[ 143.246368] 5fa0: 00000000 00000000 00000000 00000000
[ 143.246398] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 143.246429] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[ 143.246459] ---[ end trace 0000000000000000 ]---



I tried to bisect with v6.2-rc1 as bad and v6.1-rc7 as good commits, and
it suggested a790cc3a4fad75048295571a350b95b87e022a5a as the first bad
commit. However I am not entirely sure yet what the real cause is, and
the correct fix.

I will appreciate assistance with this issue, and/or ideas how to
troubleshoot it further.

Regards
Sicelo


Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1 #forregzbot

[Note: this mail contains only information for Linux kernel regression
tracking. Mails like these contain '#forregzbot' in the subject to make
then easy to spot and filter out. The author also tried to remove most
or all individuals from the list of recipients to spare them the hassle.]

On 27.12.22 21:18, Sicelo wrote:
> Hi
>
> With linux 6.2-rc1, wlan is broken on the Nokia N900 with wl1251, while
> it was working up to at least 6.1-rc7. The driver probes fine and I can
> scan for networks. However it is not possible to connect to any.

Thanks for the report. To be sure below issue doesn't fall through the
cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression
tracking bot:

#regzbot ^introduced a790cc3a4fad75048295571a350b95b87e022a5a
#regzbot title net: wifi: WLAN broken on Nokia N900
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

> dmesg contains the following:
>
>
> [ 143.202484] WARNING: CPU: 0 PID: 1300 at net/wireless/core.c:1463 cfg80211_netdev_notifier_call+0x26d/0x30c [cfg80211]
> [ 143.203613] Modules linked in: nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bnep cmt_speech nokia_modem ssi_protocol phonet radio_platform_si4713 joydev mousedev hsi_char wl1251_spi wl1251 mac80211 libarc4 omap3_rom_rng rng_core ir_rx51 pwm_omap_dmtimer rc_core snd_soc_rx51 rx51_battery isp1704_charger cpufreq_dt snd_soc_omap_mcbsp snd_soc_ti_sdma omap_wdt cfg80211 omap3_isp videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common omap_sham crypto_engine snd_soc_tlv320aic3x_i2c snd_soc_tlv320aic3x snd_soc_tpa6130a2 tsc2005 snd_soc_core regmap_spi snd_pcm_dmaengine tsc200x_core snd_pcm omap_mailbox snd_timer leds_lp5523 bq27xxx_battery_i2c snd si4713 leds_lp55xx_common bq27xxx_battery soundcore led_class tsl2563 twl4030_wdt hci_nokia rtc_twl hci_uart btbcm bluetooth twl4030_vibra pwm_twl_led pwm_twl ff_memless ecdh_generic twl4030_madc ecc rfkill libaes et8ek8 ad5820 v4l2_fwnode v4l2_async
> [ 143.205780] st_accel_i2c st_sensors_i2c st_accel industrialio_triggered_buffer kfifo_buf st_sensors videodev industrialio omap_ssi mc hsi
> [ 143.206146] CPU: 0 PID: 1300 Comm: NetworkManager Tainted: G W 6.2.0-rc1-nokia-n900+ #1
> [ 143.206207] Hardware name: Nokia RX-51 board
> [ 143.206268] unwind_backtrace from show_stack+0xb/0xc
> [ 143.206390] show_stack from dump_stack_lvl+0x2b/0x34
> [ 143.206512] dump_stack_lvl from __warn+0xdb/0xe8
> [ 143.206604] __warn from warn_slowpath_fmt+0x3f/0x76
> [ 143.206726] warn_slowpath_fmt from cfg80211_netdev_notifier_call+0x26d/0x30c [cfg80211]
> [ 143.207519] cfg80211_netdev_notifier_call [cfg80211] from raw_notifier_call_chain+0x31/0x3c
> [ 143.208282] raw_notifier_call_chain from __dev_notify_flags+0x3f/0x90
> [ 143.208404] __dev_notify_flags from dev_change_flags+0x2d/0x34
> [ 143.208496] dev_change_flags from do_setlink+0x20f/0xa98
> [ 143.208587] do_setlink from rtnl_newlink+0x341/0x5f0
> [ 143.208679] rtnl_newlink from rtnetlink_rcv_msg+0x193/0x218
> [ 143.208770] rtnetlink_rcv_msg from netlink_rcv_skb+0x75/0xb0
> [ 143.208892] netlink_rcv_skb from netlink_unicast+0x113/0x1b4
> [ 143.208984] netlink_unicast from netlink_sendmsg+0x161/0x31c
> [ 143.209106] netlink_sendmsg from ____sys_sendmsg+0x123/0x158
> [ 143.209228] ____sys_sendmsg from ___sys_sendmsg+0x43/0x68
> [ 143.209350] ___sys_sendmsg from sys_sendmsg+0x33/0x60
> [ 143.209442] sys_sendmsg from ret_fast_syscall+0x1/0x5c
> [ 143.209564] Exception stack(0xd0149fa8 to 0xd0149ff0)
> [ 143.209625] 9fa0: 00000000 00000000 0000000d beabf550 00000000 00000000
> [ 143.209686] 9fc0: 00000000 00000000 00000001 00000128 beabf67c beabf678 00000000 beabf674
> [ 143.209747] 9fe0: beabf508 beabf4f8 b6fadcdb b6fad994
> [ 143.209808] ---[ end trace 0000000000000000 ]---
> [ 143.241180] ------------[ cut here ]------------
> [ 143.241241] WARNING: CPU: 0 PID: 25 at net/wireless/scan.c:1021 cfg80211_scan_done+0x6b/0x124 [cfg80211]
> [ 143.241912] Modules linked in: nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bnep cmt_speech nokia_modem ssi_protocol phonet radio_platform_si4713 joydev mousedev hsi_char wl1251_spi wl1251 mac80211 libarc4 omap3_rom_rng rng_core ir_rx51 pwm_omap_dmtimer rc_core snd_soc_rx51 rx51_battery isp1704_charger cpufreq_dt snd_soc_omap_mcbsp snd_soc_ti_sdma omap_wdt cfg80211 omap3_isp videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common omap_sham crypto_engine snd_soc_tlv320aic3x_i2c snd_soc_tlv320aic3x snd_soc_tpa6130a2 tsc2005 snd_soc_core regmap_spi snd_pcm_dmaengine tsc200x_core snd_pcm omap_mailbox snd_timer leds_lp5523 bq27xxx_battery_i2c snd si4713 leds_lp55xx_common bq27xxx_battery soundcore led_class tsl2563 twl4030_wdt hci_nokia rtc_twl hci_uart btbcm bluetooth twl4030_vibra pwm_twl_led pwm_twl ff_memless ecdh_generic twl4030_madc ecc rfkill libaes et8ek8 ad5820 v4l2_fwnode v4l2_async
> [ 143.243041] st_accel_i2c st_sensors_i2c st_accel industrialio_triggered_buffer kfifo_buf st_sensors videodev industrialio omap_ssi mc hsi
> [ 143.243225] CPU: 0 PID: 25 Comm: kworker/u2:2 Tainted: G W 6.2.0-rc1-nokia-n900+ #1
> [ 143.243255] Hardware name: Nokia RX-51 board
> [ 143.243286] Workqueue: phy0 ieee80211_scan_work [mac80211]
> [ 143.243865] unwind_backtrace from show_stack+0xb/0xc
> [ 143.243927] show_stack from dump_stack_lvl+0x2b/0x34
> [ 143.243988] dump_stack_lvl from __warn+0xdb/0xe8
> [ 143.244049] __warn from warn_slowpath_fmt+0x3f/0x76
> [ 143.244110] warn_slowpath_fmt from cfg80211_scan_done+0x6b/0x124 [cfg80211]
> [ 143.244598] cfg80211_scan_done [cfg80211] from __ieee80211_scan_completed+0x85/0x2d8 [mac80211]
> [ 143.245269] __ieee80211_scan_completed [mac80211] from ieee80211_scan_work+0xdf/0x3b4 [mac80211]
> [ 143.245849] ieee80211_scan_work [mac80211] from process_one_work+0x153/0x35c
> [ 143.246185] process_one_work from worker_thread+0xd9/0x3d4
> [ 143.246246] worker_thread from kthread+0xad/0xc0
> [ 143.246276] kthread from ret_from_fork+0x11/0x20
> [ 143.246337] Exception stack(0xd0085fb0 to 0xd0085ff8)
> [ 143.246368] 5fa0: 00000000 00000000 00000000 00000000
> [ 143.246398] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [ 143.246429] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 143.246459] ---[ end trace 0000000000000000 ]---
>
>
>
> I tried to bisect with v6.2-rc1 as bad and v6.1-rc7 as good commits, and
> it suggested a790cc3a4fad75048295571a350b95b87e022a5a as the first bad
> commit. However I am not entirely sure yet what the real cause is, and
> the correct fix.
>
> I will appreciate assistance with this issue, and/or ideas how to
> troubleshoot it further.
>
> Regards
> Sicelo

2022-12-29 10:23:00

by Alexander Wetzel

[permalink] [raw]
Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1

On 27.12.22 21:18, Sicelo wrote:
> Hi
>
> With linux 6.2-rc1, wlan is broken on the Nokia N900 with wl1251, while
> it was working up to at least 6.1-rc7. The driver probes fine and I can
> scan for networks. However it is not possible to connect to any.
>
> dmesg contains the following:
>
>
> [ 143.202484] WARNING: CPU: 0 PID: 1300 at net/wireless/core.c:1463 cfg80211_netdev_notifier_call+0x26d/0x30c [cfg80211]
> [ 143.203613] Modules linked in: nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bnep cmt_speech nokia_modem ssi_protocol phonet radio_platform_si4713 joydev mousedev hsi_char wl1251_spi wl1251 mac80211 libarc4 omap3_rom_rng rng_core ir_rx51 pwm_omap_dmtimer rc_core snd_soc_rx51 rx51_battery isp1704_charger cpufreq_dt snd_soc_omap_mcbsp snd_soc_ti_sdma omap_wdt cfg80211 omap3_isp videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common omap_sham crypto_engine snd_soc_tlv320aic3x_i2c snd_soc_tlv320aic3x snd_soc_tpa6130a2 tsc2005 snd_soc_core regmap_spi snd_pcm_dmaengine tsc200x_core snd_pcm omap_mailbox snd_timer leds_lp5523 bq27xxx_battery_i2c snd si4713 leds_lp55xx_common bq27xxx_battery soundcore led_class tsl2563 twl4030_wdt hci_nokia rtc_twl hci_uart btbcm bluetooth twl4030_vibra pwm_twl_led pwm_twl ff_memless ecdh_generic twl4030_madc ecc rfkill libaes et8ek8 ad5820 v4l2_fwnode v4l2_async
> [ 143.205780] st_accel_i2c st_sensors_i2c st_accel industrialio_triggered_buffer kfifo_buf st_sensors videodev industrialio omap_ssi mc hsi
> [ 143.206146] CPU: 0 PID: 1300 Comm: NetworkManager Tainted: G W 6.2.0-rc1-nokia-n900+ #1
> [ 143.206207] Hardware name: Nokia RX-51 board
> [ 143.206268] unwind_backtrace from show_stack+0xb/0xc
> [ 143.206390] show_stack from dump_stack_lvl+0x2b/0x34
> [ 143.206512] dump_stack_lvl from __warn+0xdb/0xe8
> [ 143.206604] __warn from warn_slowpath_fmt+0x3f/0x76
> [ 143.206726] warn_slowpath_fmt from cfg80211_netdev_notifier_call+0x26d/0x30c [cfg80211]
> [ 143.207519] cfg80211_netdev_notifier_call [cfg80211] from raw_notifier_call_chain+0x31/0x3c
> [ 143.208282] raw_notifier_call_chain from __dev_notify_flags+0x3f/0x90
> [ 143.208404] __dev_notify_flags from dev_change_flags+0x2d/0x34
> [ 143.208496] dev_change_flags from do_setlink+0x20f/0xa98
> [ 143.208587] do_setlink from rtnl_newlink+0x341/0x5f0
> [ 143.208679] rtnl_newlink from rtnetlink_rcv_msg+0x193/0x218
> [ 143.208770] rtnetlink_rcv_msg from netlink_rcv_skb+0x75/0xb0
> [ 143.208892] netlink_rcv_skb from netlink_unicast+0x113/0x1b4
> [ 143.208984] netlink_unicast from netlink_sendmsg+0x161/0x31c
> [ 143.209106] netlink_sendmsg from ____sys_sendmsg+0x123/0x158
> [ 143.209228] ____sys_sendmsg from ___sys_sendmsg+0x43/0x68
> [ 143.209350] ___sys_sendmsg from sys_sendmsg+0x33/0x60
> [ 143.209442] sys_sendmsg from ret_fast_syscall+0x1/0x5c
> [ 143.209564] Exception stack(0xd0149fa8 to 0xd0149ff0)
> [ 143.209625] 9fa0: 00000000 00000000 0000000d beabf550 00000000 00000000
> [ 143.209686] 9fc0: 00000000 00000000 00000001 00000128 beabf67c beabf678 00000000 beabf674
> [ 143.209747] 9fe0: beabf508 beabf4f8 b6fadcdb b6fad994
> [ 143.209808] ---[ end trace 0000000000000000 ]---
> [ 143.241180] ------------[ cut here ]------------
> [ 143.241241] WARNING: CPU: 0 PID: 25 at net/wireless/scan.c:1021 cfg80211_scan_done+0x6b/0x124 [cfg80211]
> [ 143.241912] Modules linked in: nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bnep cmt_speech nokia_modem ssi_protocol phonet radio_platform_si4713 joydev mousedev hsi_char wl1251_spi wl1251 mac80211 libarc4 omap3_rom_rng rng_core ir_rx51 pwm_omap_dmtimer rc_core snd_soc_rx51 rx51_battery isp1704_charger cpufreq_dt snd_soc_omap_mcbsp snd_soc_ti_sdma omap_wdt cfg80211 omap3_isp videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common omap_sham crypto_engine snd_soc_tlv320aic3x_i2c snd_soc_tlv320aic3x snd_soc_tpa6130a2 tsc2005 snd_soc_core regmap_spi snd_pcm_dmaengine tsc200x_core snd_pcm omap_mailbox snd_timer leds_lp5523 bq27xxx_battery_i2c snd si4713 leds_lp55xx_common bq27xxx_battery soundcore led_class tsl2563 twl4030_wdt hci_nokia rtc_twl hci_uart btbcm bluetooth twl4030_vibra pwm_twl_led pwm_twl ff_memless ecdh_generic twl4030_madc ecc rfkill libaes et8ek8 ad5820 v4l2_fwnode v4l2_async
> [ 143.243041] st_accel_i2c st_sensors_i2c st_accel industrialio_triggered_buffer kfifo_buf st_sensors videodev industrialio omap_ssi mc hsi
> [ 143.243225] CPU: 0 PID: 25 Comm: kworker/u2:2 Tainted: G W 6.2.0-rc1-nokia-n900+ #1
> [ 143.243255] Hardware name: Nokia RX-51 board
> [ 143.243286] Workqueue: phy0 ieee80211_scan_work [mac80211]
> [ 143.243865] unwind_backtrace from show_stack+0xb/0xc
> [ 143.243927] show_stack from dump_stack_lvl+0x2b/0x34
> [ 143.243988] dump_stack_lvl from __warn+0xdb/0xe8
> [ 143.244049] __warn from warn_slowpath_fmt+0x3f/0x76
> [ 143.244110] warn_slowpath_fmt from cfg80211_scan_done+0x6b/0x124 [cfg80211]
> [ 143.244598] cfg80211_scan_done [cfg80211] from __ieee80211_scan_completed+0x85/0x2d8 [mac80211]
> [ 143.245269] __ieee80211_scan_completed [mac80211] from ieee80211_scan_work+0xdf/0x3b4 [mac80211]
> [ 143.245849] ieee80211_scan_work [mac80211] from process_one_work+0x153/0x35c
> [ 143.246185] process_one_work from worker_thread+0xd9/0x3d4
> [ 143.246246] worker_thread from kthread+0xad/0xc0
> [ 143.246276] kthread from ret_from_fork+0x11/0x20
> [ 143.246337] Exception stack(0xd0085fb0 to 0xd0085ff8)
> [ 143.246368] 5fa0: 00000000 00000000 00000000 00000000
> [ 143.246398] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [ 143.246429] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> [ 143.246459] ---[ end trace 0000000000000000 ]---
>
>
>
> I tried to bisect with v6.2-rc1 as bad and v6.1-rc7 as good commits, and
> it suggested a790cc3a4fad75048295571a350b95b87e022a5a as the first bad
> commit. However I am not entirely sure yet what the real cause is, and
> the correct fix.
>
> I will appreciate assistance with this issue, and/or ideas how to
> troubleshoot it further.

I do not yet see how switching the driver to iTXQ can cause the observed
errors. The warnings above happen during scan, which should not be
affected by the commit above. So I assume for now that's these are just
follow up issues and something is wrong before the error messages we get...

But scanning itself is still working for you? You see the networks, just
joining them is not working, correct?

Some ideas how to continue debugging the issue for now:

1) Enable debugging and share the all logs starting from driver load up
and including one connection request.
Looks like you must edit drivers/net/wireless/ti/wl1251/wl1251.h and
change line 39:
#define DEBUG_LEVEL (DEBUG_NONE)
to
#define DEBUG_LEVEL (DEBUG_ALL)

2) Keep debugging enabled but undo the change of the commit causing the
problem. Remove the line line 1362 added by the problematic commit in
drivers/net/wireless/ti/wl1251/main.c:
.wake_tx_queue = ieee80211_handle_wake_tx_queue,
Connection should work again. Run the same test procedure as above
and share the debug log from that. with the logs from 1) and 2) we
hopefully get an better idea where the problem really is...

3) On top of the debug logs above you can also try what happens when we
force the driver to use SW scan only:
Add the line we removed for 2) again but remove line 1364 instead:
.hw_scan = wl1251_op_hw_scan,
Again share the debug logs


Alexander

2023-01-03 16:56:47

by Sicelo A. Mhlongo

[permalink] [raw]
Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1

Hi Alexander

>
> I do not yet see how switching the driver to iTXQ can cause the observed
> errors. The warnings above happen during scan, which should not be affected
> by the commit above. So I assume for now that's these are just follow up
> issues and something is wrong before the error messages we get...
>
> But scanning itself is still working for you? You see the networks, just
> joining them is not working, correct?

Yes, although later I found that joining does actually work, but takes
an unusually long time. I later observed that I can even get an IP
address. However, there is 100% packet loss.

Accidentally, I stumbled on the fact that if I turn power saving off,
then it starts working reasonably well. I am not sure what this
observation suggests though.

> Some ideas how to continue debugging the issue for now:
>
> 1) Enable debugging and share the all logs starting from driver load up
> and including one connection request.
> Looks like you must edit drivers/net/wireless/ti/wl1251/wl1251.h and
> change line 39:
> #define DEBUG_LEVEL (DEBUG_NONE)
> to
> #define DEBUG_LEVEL (DEBUG_ALL)
>
> 2) Keep debugging enabled but undo the change of the commit causing the
> problem. Remove the line line 1362 added by the problematic commit in
> drivers/net/wireless/ti/wl1251/main.c:
> .wake_tx_queue = ieee80211_handle_wake_tx_queue,
> Connection should work again. Run the same test procedure as above
> and share the debug log from that. with the logs from 1) and 2) we
> hopefully get an better idea where the problem really is...
>
> 3) On top of the debug logs above you can also try what happens when we
> force the driver to use SW scan only:
> Add the line we removed for 2) again but remove line 1364 instead:
> .hw_scan = wl1251_op_hw_scan,
> Again share the debug logs
>

I will do further testing in a couple of weeks when I have time again.
Thank you for the suggestions.

Sicelo

2023-01-10 19:05:14

by Alexander Wetzel

[permalink] [raw]
Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1

On 03.01.23 17:52, Sicelo wrote:
> Hi Alexander
>
>>
>> I do not yet see how switching the driver to iTXQ can cause the observed
>> errors. The warnings above happen during scan, which should not be affected
>> by the commit above. So I assume for now that's these are just follow up
>> issues and something is wrong before the error messages we get...
>>
>> But scanning itself is still working for you? You see the networks, just
>> joining them is not working, correct?
>
> Yes, although later I found that joining does actually work, but takes
> an unusually long time. I later observed that I can even get an IP
> address. However, there is 100% packet loss.
>
> Accidentally, I stumbled on the fact that if I turn power saving off,
> then it starts working reasonably well. I am not sure what this
> observation suggests though.
>

Should have seen the potential sooner, but can you please check if the
following patch fixes the issue?
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

This patch seems to be a perfect fit to what you are describing...

FYI:
There is another regression report which has that as a very likely but
not yet confirmed fix:
https://lore.kernel.org/linux-wireless/[email protected]/T/#t

(The discussion above has another patch you really want to have when
AMPDU is supported.)

Alexander

2023-01-10 19:21:01

by Sicelo A. Mhlongo

[permalink] [raw]
Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1

Hello

On Tue, Jan 10, 2023 at 07:59:24PM +0100, Alexander Wetzel wrote:
> Should have seen the potential sooner, but can you please check if the
> following patch fixes the issue?
> https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
>
> This patch seems to be a perfect fit to what you are describing...
>

Yes, someone pointed me to this patch a day ago, and it does fix the
issue indeed.

Apologies for not responding sooner.

> FYI:
> There is another regression report which has that as a very likely but not
> yet confirmed fix:
> https://lore.kernel.org/linux-wireless/[email protected]/T/#t
>
> (The discussion above has another patch you really want to have when AMPDU
> is supported.)
>

I will give this a try as well during the course of the week. I noticed
the speeds were low, but that could just be the weak hardware itself
(1x600MHz ARM CPU), and I have not had time to compare performance from
before the commits in question.

Regards
Sicelo

2023-01-11 16:26:13

by Alexander Wetzel

[permalink] [raw]
Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1

On 10.01.23 20:08, Sicelo wrote:
> Hello
>
> On Tue, Jan 10, 2023 at 07:59:24PM +0100, Alexander Wetzel wrote:
>> Should have seen the potential sooner, but can you please check if the
>> following patch fixes the issue?
>> https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
>>
>> This patch seems to be a perfect fit to what you are describing...
>>
>
> Yes, someone pointed me to this patch a day ago, and it does fix the
> issue indeed.
>
> Apologies for not responding sooner.
>
That was fast:-)
Thanks for testing and reporting back.

>> FYI:
>> There is another regression report which has that as a very likely but not
>> yet confirmed fix:
>> https://lore.kernel.org/linux-wireless/[email protected]/T/#t
>>
>> (The discussion above has another patch you really want to have when AMPDU
>> is supported.)
>>
>
> I will give this a try as well during the course of the week. I noticed
> the speeds were low, but that could just be the weak hardware itself
> (1x600MHz ARM CPU), and I have not had time to compare performance from
> before the commits in question.

Please keep me posted on the outcome. I expect no relevant change but
then I did not test the patch on weak HW so far...

Alexander


2023-01-11 17:01:07

by Alexander Wetzel

[permalink] [raw]
Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1

For regression tracking only:

+CC [email protected]

Issue is solved with a patch already on the way into mainline.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20230111&id=4444bc2116aecdcde87dce80373540adc8bd478b

Issue was found and fixed independently of the regression report, so no
regression tags in the commit.

On 11.01.23 17:21, Alexander Wetzel wrote:
> On 10.01.23 20:08, Sicelo wrote:
>> Hello
>>
>> On Tue, Jan 10, 2023 at 07:59:24PM +0100, Alexander Wetzel wrote:
>>> Should have seen the potential sooner, but can you please check if the
>>> following patch fixes the issue?
>>> https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
>>>
>>> This patch seems to be a perfect fit to what you are describing...
>>>
>>
>> Yes, someone pointed me to this patch a day ago, and it does fix the
>> issue indeed.
>>
>> Apologies for not responding sooner.
>>
> That was fast:-)
> Thanks for testing and reporting back.
>
>>> FYI:
>>> There is another regression report which has that as a very likely
>>> but not
>>> yet confirmed fix:
>>> https://lore.kernel.org/linux-wireless/[email protected]/T/#t
>>>
>>> (The discussion above has another patch you really want to have when
>>> AMPDU
>>> is supported.)
>>>
>>
>> I will give this a try as well during the course of the week. I noticed
>> the speeds were low, but that could just be the weak hardware itself
>> (1x600MHz ARM CPU), and I have not had time to compare performance from
>> before the commits in question.
>
> Please keep me posted on the outcome. I expect no relevant change but
> then I did not test the patch on weak HW so far...
>
> Alexander
>
>

Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1



On 11.01.23 17:49, Alexander Wetzel wrote:
> For regression tracking only:
>
> +CC [email protected]
>
> Issue is solved with a patch already on the way into mainline.
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20230111&id=4444bc2116aecdcde87dce80373540adc8bd478b
>
> Issue was found and fixed independently of the regression report, so no
> regression tags in the commit.

Happens, thx for letting me know. Now regzbot will know about it as well:

#regzbot fix: wifi: mac80211: Proper mark iTXQs for resumption

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.

> On 11.01.23 17:21, Alexander Wetzel wrote:
>> On 10.01.23 20:08, Sicelo wrote:
>>> Hello
>>>
>>> On Tue, Jan 10, 2023 at 07:59:24PM +0100, Alexander Wetzel wrote:
>>>> Should have seen the potential sooner, but can you please check if the
>>>> following patch fixes the issue?
>>>> https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
>>>>
>>>> This patch seems to be a perfect fit to what you are describing...
>>>>
>>>
>>> Yes, someone pointed me to this patch a day ago, and it does fix the
>>> issue indeed.
>>>
>>> Apologies for not responding sooner.
>>>
>> That was fast:-)
>> Thanks for testing and reporting back.
>>
>>>> FYI:
>>>> There is another regression report which has that as a very likely
>>>> but not
>>>> yet confirmed fix:
>>>> https://lore.kernel.org/linux-wireless/[email protected]/T/#t
>>>>
>>>> (The discussion above has another patch you really want to have when
>>>> AMPDU
>>>> is supported.)
>>>>
>>>
>>> I will give this a try as well during the course of the week. I noticed
>>> the speeds were low, but that could just be the weak hardware itself
>>> (1x600MHz ARM CPU), and I have not had time to compare performance from
>>> before the commits in question.
>>
>> Please keep me posted on the outcome. I expect no relevant change but
>> then I did not test the patch on weak HW so far...
>>
>> Alexander
>>
>>
>
>
>