2023-06-16 12:39:18

by Juerg Haefliger

Subject: [PATCH] wifi: p54: Add missing MODULE_FIRMWARE macro

Add the missing MODULE_FIRMWARE macro for "3826.eeprom".

Signed-off-by: Juerg Haefliger <[email protected]>
---
drivers/net/wireless/intersil/p54/p54spi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c
index 19152fd449ba..ce0179b8ab36 100644
--- a/drivers/net/wireless/intersil/p54/p54spi.c
+++ b/drivers/net/wireless/intersil/p54/p54spi.c
@@ -28,6 +28,7 @@
#endif /* CONFIG_P54_SPI_DEFAULT_EEPROM */

MODULE_FIRMWARE("3826.arm");
+MODULE_FIRMWARE("3826.eeprom");

/* gpios should be handled in board files and provided via platform data,
* but because it's currently impossible for p54spi to have a header file
--
2.37.2

2023-06-16 13:19:01

by Christian Lamparter

Subject: Re: [PATCH] wifi: p54: Add missing MODULE_FIRMWARE macro

On 6/16/23 14:19, Juerg Haefliger wrote:
> Add the missing MODULE_FIRMWARE macro for "3826.eeprom".
>
> Signed-off-by: Juerg Haefliger <[email protected]>
Sure.

Acked-by: Christian Lamparter <[email protected]>

For people looking for the "3826.eeprom": Default values
are provided by p54spi_eeprom.h . But there's a MAC field
and antennas dbi values in there for customization.

Cheers,
Christian
> ---
> drivers/net/wireless/intersil/p54/p54spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c
> index 19152fd449ba..ce0179b8ab36 100644
> --- a/drivers/net/wireless/intersil/p54/p54spi.c
> +++ b/drivers/net/wireless/intersil/p54/p54spi.c
> @@ -28,6 +28,7 @@
> #endif /* CONFIG_P54_SPI_DEFAULT_EEPROM */
>
> MODULE_FIRMWARE("3826.arm");
> +MODULE_FIRMWARE("3826.eeprom");
>
> /* gpios should be handled in board files and provided via platform data,
> * but because it's currently impossible for p54spi to have a header file

2023-06-21 10:03:55

by Kalle Valo

Subject: Re: [PATCH] wifi: p54: Add missing MODULE_FIRMWARE macro

Juerg Haefliger <[email protected]> wrote:

> Add the missing MODULE_FIRMWARE macro for "3826.eeprom".
>
> Signed-off-by: Juerg Haefliger <[email protected]>
> Acked-by: Christian Lamparter <[email protected]>

Patch applied to wireless-next.git, thanks.

8d0c7e1901d6 wifi: p54: Add missing MODULE_FIRMWARE macro

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches