2016-09-05 15:26:04

by Arnd Bergmann

Subject: Re: [v2] bcma: use of_dma_configure() to set initial dma mask

On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote:
> Arnd Bergmann <[email protected]> wrote:
> > While fixing another bug, I noticed that bcma manually sets up
> > a dma_mask pointer for its child devices. We have a generic
> > helper for that now, which should be able to cope better with
> > any variations that might be needed to deal with cache coherency,
> > unusual DMA address offsets, iommus, or limited DMA masks, none
> > of which are currently handled here.
> >
> > This changes the core to use the of_dma_configure(), like
> > we do for platform devices that are probed directly from
> > DT.
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
>
> Nobody tested this, so I'll drop the patch.
>

Should I resend it? I think it's still required.

Arnd

2016-09-06 07:48:22

by Kalle Valo

Subject: Re: [v2] bcma: use of_dma_configure() to set initial dma mask

Arnd Bergmann <[email protected]> writes:

> On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote:
>> Arnd Bergmann <[email protected]> wrote:
>> > While fixing another bug, I noticed that bcma manually sets up
>> > a dma_mask pointer for its child devices. We have a generic
>> > helper for that now, which should be able to cope better with
>> > any variations that might be needed to deal with cache coherency,
>> > unusual DMA address offsets, iommus, or limited DMA masks, none
>> > of which are currently handled here.
>> >
>> > This changes the core to use the of_dma_configure(), like
>> > we do for platform devices that are probed directly from
>> > DT.
>> >
>> > Signed-off-by: Arnd Bergmann <[email protected]>
>>
>> Nobody tested this, so I'll drop the patch.
>
> Should I resend it? I think it's still required.

Sorry, I misunderstood your comments then. No need to resend, I readded
this to my queue:

https://patchwork.kernel.org/patch/8608751/

--
Kalle Valo

2016-09-05 18:34:28

by Arend Van Spriel

Subject: Re: [v2] bcma: use of_dma_configure() to set initial dma mask

On 5-9-2016 17:26, Arnd Bergmann wrote:
> On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote:
>> Arnd Bergmann <[email protected]> wrote:
>>> While fixing another bug, I noticed that bcma manually sets up
>>> a dma_mask pointer for its child devices. We have a generic
>>> helper for that now, which should be able to cope better with
>>> any variations that might be needed to deal with cache coherency,
>>> unusual DMA address offsets, iommus, or limited DMA masks, none
>>> of which are currently handled here.
>>>
>>> This changes the core to use the of_dma_configure(), like
>>> we do for platform devices that are probed directly from
>>> DT.
>>>
>>> Signed-off-by: Arnd Bergmann <[email protected]>
>>
>> Nobody tested this, so I'll drop the patch.
>>
>
> Should I resend it? I think it's still required.

Maybe you should request some bcma users (Rafał?) explicitly to test
this. I have no equipment with CONFIG_OF enabled over here.

Regards,
Arend