2017-10-08 13:04:07

by Jia-Ju Bai

Subject: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

No rcu_read_lock is called, but rcu_read_unlock is still called.
Thus rcu_read_unlock should be removed.

Signed-off-by: Jia-Ju Bai <[email protected]>
---
drivers/net/wireless/ath/wcn36xx/main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index 35bd50b..b83f01d 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
if (!sta) {
wcn36xx_err("sta %pM is not found\n",
bss_conf->bssid);
- rcu_read_unlock();
goto out;
}
sta_priv = wcn36xx_sta_to_priv(sta);
--
1.7.9.5

2017-10-27 14:00:50

by Kalle Valo

Subject: Re: wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

Jia-Ju Bai <[email protected]> wrote:

> No rcu_read_lock is called, but rcu_read_unlock is still called.
> Thus rcu_read_unlock should be removed.
>
> Signed-off-by: Jia-Ju Bai <[email protected]>
> Acked-by: Bjorn Andersson <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-current branch of ath.git, thanks.

c0d5adc35c0b wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

--
https://patchwork.kernel.org/patch/9991827/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2017-10-11 06:54:49

by Bjorn Andersson

Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:

> No rcu_read_lock is called, but rcu_read_unlock is still called.
> Thus rcu_read_unlock should be removed.
>

Thanks, not sure how I could miss that one. Kalle can you please include
this in a v4.14-rc pull request?


:

Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration")

> Signed-off-by: Jia-Ju Bai <[email protected]>

Acked-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 35bd50b..b83f01d 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
> if (!sta) {
> wcn36xx_err("sta %pM is not found\n",
> bss_conf->bssid);
> - rcu_read_unlock();
> goto out;
> }
> sta_priv = wcn36xx_sta_to_priv(sta);
> --
> 1.7.9.5
>
>
>
> _______________________________________________
> wcn36xx mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/wcn36xx

2017-10-11 08:28:47

by Kalle Valo

Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

Bjorn Andersson <[email protected]> writes:

> On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:
>
>> No rcu_read_lock is called, but rcu_read_unlock is still called.
>> Thus rcu_read_unlock should be removed.
>>=20
>
> Thanks, not sure how I could miss that one. Kalle can you please include
> this in a v4.14-rc pull request?
>
>
> :
>
> Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configura=
tion")
>
>> Signed-off-by: Jia-Ju Bai <[email protected]>
>
> Acked-by: Bjorn Andersson <[email protected]>

Ok, I'll queue this to 4.14.

--=20
Kalle Valo=