2011-01-07 00:33:59

by Sujith

[permalink] [raw]
Subject: [RFC v2] cfg80211: Add HT BSS attributes

(Resend to list).

Sujith wrote:
> Sujith wrote:
> > From: Sujith Manoharan <[email protected]>
> >
> > Add two new per-BSS attributes to allow configuration of
> > HT capabilites and operational parameters by hostapd.
>
> Ok, looks like this is not needed after all.
> When operating in AP mode, an associated station's HT caps is
> notified to the driver through sta_add() anyway.
>
> The main motive for this patch was that ath9k_htc required the
> HT params of the current BSS and it turns out that the firmware
> doesn't do anything with the information. :)
>
> Sujith


2011-01-07 02:34:03

by Daniel Halperin

[permalink] [raw]
Subject: Re: [RFC v2] cfg80211: Add HT BSS attributes

On Thu, Jan 6, 2011 at 6:15 PM, Sujith <[email protected]> wrote:
> Daniel Halperin wrote:
>> Yeah, me too. ?Isn't greenfield mode (whether there are legacy devices
>> around) part of the operating capabilities and should be supported by
>> hostapd?
>
> Yes, hostapd does check if there are non-GF stations in the BSS and updates
> the HT operation mode parameters. But the nl80211 interface hook is currently
> not implemented.
>

right.. so don't we want this patch? :) Sorry if I'm being obtuse

Dan

2011-01-07 02:39:45

by Sujith

[permalink] [raw]
Subject: Re: [RFC v2] cfg80211: Add HT BSS attributes

Daniel Halperin wrote:
> On Thu, Jan 6, 2011 at 6:15 PM, Sujith <[email protected]> wrote:
> > Daniel Halperin wrote:
> >> Yeah, me too. ?Isn't greenfield mode (whether there are legacy devices
> >> around) part of the operating capabilities and should be supported by
> >> hostapd?
> >
> > Yes, hostapd does check if there are non-GF stations in the BSS and updates
> > the HT operation mode parameters. But the nl80211 interface hook is currently
> > not implemented.
> >
>
> right.. so don't we want this patch? :) Sorry if I'm being obtuse

The Greenfield status is part of opmode (see operation_mode in struct ieee80211_ht_info).
This is already handled by mac80211 through NL80211_ATTR_BSS_HT_OPMODE for AP mode.

Sujith

2011-01-07 02:00:40

by Daniel Halperin

[permalink] [raw]
Subject: Re: [RFC v2] cfg80211: Add HT BSS attributes

On Thu, Jan 6, 2011 at 4:56 PM, Luis R. Rodriguez <[email protected]> wrote:
> On Thu, Jan 6, 2011 at 4:33 PM, Sujith <[email protected]> wrote:
>> (Resend to list).
>>
>> Sujith wrote:
>>> Sujith wrote:
>>> > From: Sujith Manoharan <[email protected]>
>>> >
>>> > Add two new per-BSS attributes to allow configuration of
>>> > HT capabilites and operational parameters by hostapd.
>>>
>>> Ok, looks like this is not needed after all.
>>> When operating in AP mode, an associated station's HT caps is
>>> notified to the driver through sta_add() anyway.
>>>
>>> The main motive for this patch was that ath9k_htc required the
>>> HT params of the current BSS and it turns out that the firmware
>>> doesn't do anything with the information. :)
>
> Ah, I thought the purpose was to allow dynamic configuration of HT
> capa/params used.
>

Yeah, me too. Isn't greenfield mode (whether there are legacy devices
around) part of the operating capabilities and should be supported by
hostapd?

Dan

2011-01-07 00:56:49

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [RFC v2] cfg80211: Add HT BSS attributes

On Thu, Jan 6, 2011 at 4:33 PM, Sujith <[email protected]> wrote:
> (Resend to list).
>
> Sujith wrote:
>> Sujith wrote:
>> > From: Sujith Manoharan <[email protected]>
>> >
>> > Add two new per-BSS attributes to allow configuration of
>> > HT capabilites and operational parameters by hostapd.
>>
>> Ok, looks like this is not needed after all.
>> When operating in AP mode, an associated station's HT caps is
>> notified to the driver through sta_add() anyway.
>>
>> The main motive for this patch was that ath9k_htc required the
>> HT params of the current BSS and it turns out that the firmware
>> doesn't do anything with the information. :)

Ah, I thought the purpose was to allow dynamic configuration of HT
capa/params used.

Luis

2011-01-07 02:15:36

by Sujith

[permalink] [raw]
Subject: Re: [RFC v2] cfg80211: Add HT BSS attributes

Daniel Halperin wrote:
> Yeah, me too. Isn't greenfield mode (whether there are legacy devices
> around) part of the operating capabilities and should be supported by
> hostapd?

Yes, hostapd does check if there are non-GF stations in the BSS and updates
the HT operation mode parameters. But the nl80211 interface hook is currently
not implemented.

Sujith