2013-06-04 07:08:56

by Yijing Wang

Subject: [RESEND][PATCH 3/7] net, ipw2x00: remove redundant D0 power state set

Pci_enable_device() will set device power state to D0,
so it's no need to do it again in ipw2100_pci_init_one().

Signed-off-by: Yijing Wang <[email protected]>
Cc: Stanislav Yakovlev <[email protected]>
Cc: "John W. Linville" <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/net/wireless/ipw2x00/ipw2100.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c
index 15920aa..f8ab193 100644
--- a/drivers/net/wireless/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/ipw2x00/ipw2100.c
@@ -6242,8 +6242,6 @@ static int ipw2100_pci_init_one(struct pci_dev *pci_dev,
if ((val & 0x0000ff00) != 0)
pci_write_config_dword(pci_dev, 0x40, val & 0xffff00ff);

- pci_set_power_state(pci_dev, PCI_D0);
-
if (!ipw2100_hw_is_adapter_in_system(dev)) {
printk(KERN_WARNING DRV_NAME
"Device not found via register read.\n");
--
1.7.1

2013-06-04 09:16:35

by Stanislav Yakovlev

Subject: Re: [RESEND][PATCH 3/7] net, ipw2x00: remove redundant D0 power state set

Hi Yijing,

On 4 June 2013 00:07, Yijing Wang <[email protected]> wrote:
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in ipw2100_pci_init_one().
>
> Signed-off-by: Yijing Wang <[email protected]>
> Cc: Stanislav Yakovlev <[email protected]>
> Cc: "John W. Linville" <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Looks fine, thanks.

Stanislav.