On Fri, Oct 20, 2023 at 2:47 AM Dmitry Antipov <[email protected]> wrote:
>
> In 'mwifiex_sdio_generic_fw_dump()', move the check whether
> 'sdio_readb()' has failed for MAX_POLL_TRIES times out of
> the reading loop. Compile tested only.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <[email protected]>
> ---
> drivers/net/wireless/marvell/mwifiex/sdio.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
We've already discussed and rejected this patch, if you aren't
planning on doing any real testing with it.
Subject: Re: [PATCH] wifi: mwifiex: fix SDIO firmware dump wait
https://lore.kernel.org/all/CA+ASDXNu-CWa9V5Oc-01pLp72iMVRw7m46+bDdNUxVmfrR9PSQ@mail.gmail.com/
It's *probably* correct, but it's risky without any cursory testing.