2020-07-24 10:17:50

by Loic Poulain

Subject: [PATCH v2 3/6] wcn36xx: Increase number of TX retries

Increase the short/long retry limit to 15 in order to impove TX
robustness in noisy/busy environment. 15 is the default value
defined in the downstream driver. Observed number of ack timeout
is reduced with this change.

Signed-off-by: Loic Poulain <[email protected]>
---
drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 59f9f53..908cc6c 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -45,8 +45,8 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = {
WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000),
WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64),
WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347),
- WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 6),
- WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 6),
+ WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15),
+ WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15),
WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000),
WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5),
WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10),
--
2.7.4

2020-07-24 13:14:03

by Kalle Valo

Subject: Re: [PATCH v2 3/6] wcn36xx: Increase number of TX retries

Ramon Fried <[email protected]> writes:

> On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <[email protected]>
> wrote:
>
> Increase the short/long retry limit to 15 in order to impove TX
> robustness in noisy/busy environment. 15 is the default value
> defined in the downstream driver. Observed number of ack timeout
> is reduced with this change.
>
> Signed-off-by: Loic Poulain <[email protected]>
> ---
> drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c
> b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 59f9f53..908cc6c 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -45,8 +45,8 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[]
> = {
> WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000),
> WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64),
> WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347),
> - WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 6),
> - WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 6),
> + WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15),
> + WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15),
> WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000),
> WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5),
> WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10),
> --
> 2.7.4
>
>
>
>
> These set of patches fixed my connectivity issues with TP-Link DECO
> routers.
> Acked-By: Ramon Fried <[email protected]>

HTML emails are dropped by the list, please use text/plain only.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-07-24 13:46:51

by Ramon Fried

Subject: Re: [PATCH v2 3/6] wcn36xx: Increase number of TX retries

Yes. small glitch. sorry.


On Fri, Jul 24, 2020 at 4:12 PM Kalle Valo <[email protected]> wrote:
>
> Ramon Fried <[email protected]> writes:
>
> > On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <[email protected]>
> > wrote:
> >
> > Increase the short/long retry limit to 15 in order to impove TX
> > robustness in noisy/busy environment. 15 is the default value
> > defined in the downstream driver. Observed number of ack timeout
> > is reduced with this change.
> >
> > Signed-off-by: Loic Poulain <[email protected]>
> > ---
> > drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c
> > b/drivers/net/wireless/ath/wcn36xx/smd.c
> > index 59f9f53..908cc6c 100644
> > --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> > +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> > @@ -45,8 +45,8 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[]
> > = {
> > WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000),
> > WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64),
> > WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347),
> > - WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 6),
> > - WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 6),
> > + WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15),
> > + WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15),
> > WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000),
> > WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5),
> > WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10),
> > --
> > 2.7.4
> >
> >
> >
> >
> > These set of patches fixed my connectivity issues with TP-Link DECO
> > routers.
> > Acked-By: Ramon Fried <[email protected]>
>
> HTML emails are dropped by the list, please use text/plain only.
>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches