2023-07-05 07:53:44

by Jeff Chua

[permalink] [raw]
Subject: Linux-6.5 iwlwifi crash

Latest linux-6.4 after June 27 crash my whole linux notebook once
iwlwifi is loaded. Anyone seeing this?

Bisect? Or there's a patch for this?

# modprobe iwlwifi
... Whole system frozen!


Here's my system before the crash ...

# dmesg
cfg80211: Loading compiled-in X.509 certificates for regulatory database
Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
thermal thermal_zone1: failed to read out thermal zone (-61)
iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
requested 65536K

# lspci
00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
WiFi (rev 01)

# linux git log
commit d528014517f2b0531862c02865b9d4c908019dc4 (HEAD -> master,
origin/master, origin/HEAD)
Author: Linus Torvalds <[email protected]>
Date: Tue Jul 4 15:05:12 2023 -0700

# lsmodModule Size Used by
iwlmvm 397312 0
mac80211 626688 1 iwlmvm
iwlwifi 307200 1 iwlmvm
cfg80211 413696 3 iwlmvm,iwlwifi,mac80211


Bisect?

Thanks,
Jeff.


2023-07-05 08:44:32

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: Linux-6.5 iwlwifi crash

Hi! Thanks for your report.

Side note: is there any relation to the thread[1] you posted this in?
Doesn't look like it from here.

Side note: discussing multiple unrelated issues in one thread increases
the risk a lot that some or all of them are ignored:
https://linux-regtracking.leemhuis.info/post/frequent-reasons-why-linux-kernel-bug-reports-are-ignored/

[1] https://lore.kernel.org/all/[email protected]/

On 05.07.23 09:24, Jeff Chua wrote:
> Latest linux-6.4

What do you mean by that? From later in the mail it sounds like you mean
latest mainline -- is that correct?

> after June 27 crash my whole linux notebook once
> iwlwifi is loaded. Anyone seeing this?

I haven't heard of any such problems, but that doesn't have to mean much.

> Bisect? Or there's a patch for this?
>
> # modprobe iwlwifi
> ... Whole system frozen!
>
>
> Here's my system before the crash ...
>
> # dmesg
> cfg80211: Loading compiled-in X.509 certificates for regulatory database
> Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
> iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
> thermal thermal_zone1: failed to read out thermal zone (-61)
> iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
> requested 65536K
>
> # lspci
> 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
> WiFi (rev 01)
>
> # linux git log
> commit d528014517f2b0531862c02865b9d4c908019dc4 (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Linus Torvalds <[email protected]>
> Date: Tue Jul 4 15:05:12 2023 -0700
>
> # lsmodModule Size Used by
> iwlmvm 397312 0
> mac80211 626688 1 iwlmvm
> iwlwifi 307200 1 iwlmvm
> cfg80211 413696 3 iwlmvm,iwlwifi,mac80211
>
>
> Bisect?

If none of the others CCed comes up with an idea within the next few
hours then yes please!

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

2023-07-05 12:12:57

by Jeff Chua

[permalink] [raw]
Subject: Re: Linux-6.5 iwlwifi crash

On Wed, Jul 5, 2023 at 4:37 PM Linux regression tracking (Thorsten
Leemhuis) <[email protected]> wrote:
>
> Hi! Thanks for your report.
>
> Side note: is there any relation to the thread[1] you posted this in?

Sorry, I was just posting to the same email list that I had reported
about a different wifi list earlier. No relation to this, but it's a
new wifi issue.

> Doesn't look like it from here.
>
> Side note: discussing multiple unrelated issues in one thread increases
> the risk a lot that some or all of them are ignored:
> https://linux-regtracking.leemhuis.info/post/frequent-reasons-why-linux-kernel-bug-reports-are-ignored/
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> On 05.07.23 09:24, Jeff Chua wrote:
> > Latest linux-6.4
>
> What do you mean by that? From later in the mail it sounds like you mean
> latest mainline -- is that correct?

It's from linux git pull. It's 6.5-rc but I didn't write that way
becuase Linus's branch is still 6.4 ... that 6.5-rc0 or rc1 should
have more appropriate.

> > after June 27 crash my whole linux notebook once
> > iwlwifi is loaded. Anyone seeing this?
>
> I haven't heard of any such problems, but that doesn't have to mean much.

> > Bisect? Or there's a patch for this?
> >
> > # modprobe iwlwifi
> > ... Whole system frozen!
> >
> >
> > Here's my system before the crash ...
> >
> > # dmesg
> > cfg80211: Loading compiled-in X.509 certificates for regulatory database
> > Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
> > iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
> > iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
> > thermal thermal_zone1: failed to read out thermal zone (-61)
> > iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
> > requested 65536K
> >
> > # lspci
> > 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
> > WiFi (rev 01)
> >
> > # linux git log
> > commit d528014517f2b0531862c02865b9d4c908019dc4 (HEAD -> master,
> > origin/master, origin/HEAD)
> > Author: Linus Torvalds <[email protected]>
> > Date: Tue Jul 4 15:05:12 2023 -0700
> >
> > # lsmodModule Size Used by
> > iwlmvm 397312 0
> > mac80211 626688 1 iwlmvm
> > iwlwifi 307200 1 iwlmvm
> > cfg80211 413696 3 iwlmvm,iwlwifi,mac80211
> >
> >
> > Bisect?
>
> If none of the others CCed comes up with an idea within the next few
> hours then yes please!

I will wait for a day, then bisect.

Thank you!


> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.

2023-07-05 18:18:18

by Larry Finger

[permalink] [raw]
Subject: Re: Linux-6.5 iwlwifi crash

On 7/5/23 06:56, Jeff Chua wrote:
> On Wed, Jul 5, 2023 at 4:37 PM Linux regression tracking (Thorsten
> Leemhuis) <[email protected]> wrote:
>>
>> Hi! Thanks for your report.
>>
>> Side note: is there any relation to the thread[1] you posted this in?
>
> Sorry, I was just posting to the same email list that I had reported
> about a different wifi list earlier. No relation to this, but it's a
> new wifi issue.
>
>> Doesn't look like it from here.
>>
>> Side note: discussing multiple unrelated issues in one thread increases
>> the risk a lot that some or all of them are ignored:
>> https://linux-regtracking.leemhuis.info/post/frequent-reasons-why-linux-kernel-bug-reports-are-ignored/
>>
>> [1] https://lore.kernel.org/all/[email protected]/
>>
>> On 05.07.23 09:24, Jeff Chua wrote:
>>> Latest linux-6.4
>>
>> What do you mean by that? From later in the mail it sounds like you mean
>> latest mainline -- is that correct?
>
> It's from linux git pull. It's 6.5-rc but I didn't write that way
> becuase Linus's branch is still 6.4 ... that 6.5-rc0 or rc1 should
> have more appropriate.
>
>>> after June 27 crash my whole linux notebook once
>>> iwlwifi is loaded. Anyone seeing this?
>>
>> I haven't heard of any such problems, but that doesn't have to mean much.
>
>>> Bisect? Or there's a patch for this?
>>>
>>> # modprobe iwlwifi
>>> ... Whole system frozen!
>>>
>>>
>>> Here's my system before the crash ...
>>>
>>> # dmesg
>>> cfg80211: Loading compiled-in X.509 certificates for regulatory database
>>> Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
>>> iwlwifi 0000:00:14.3: enabling device (0000 -> 0002)
>>> iwlwifi 0000:00:14.3: api flags index 2 larger than supported by driver
>>> thermal thermal_zone1: failed to read out thermal zone (-61)
>>> iwlwifi 0000:00:14.3: Sorry - debug buffer is only 4096K while you
>>> requested 65536K
>>>
>>> # lspci
>>> 00:14.3 Network controller: Intel Corporation Alder Lake-P PCH CNVi
>>> WiFi (rev 01)
>>>
>>> # linux git log
>>> commit d528014517f2b0531862c02865b9d4c908019dc4 (HEAD -> master,
>>> origin/master, origin/HEAD)
>>> Author: Linus Torvalds <[email protected]>
>>> Date: Tue Jul 4 15:05:12 2023 -0700
>>>
>>> # lsmodModule Size Used by
>>> iwlmvm 397312 0
>>> mac80211 626688 1 iwlmvm
>>> iwlwifi 307200 1 iwlmvm
>>> cfg80211 413696 3 iwlmvm,iwlwifi,mac80211

Jeff,

Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
is working OK with iwlmvm. Lspci says my device is

04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
(rev 73)

I think you do need to do a bisection.

Larry




2023-07-07 02:09:51

by Jeff Chua

[permalink] [raw]
Subject: Re: Linux-6.5 iwlwifi crash

On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <[email protected]> wrote:

> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
> is working OK with iwlmvm. Lspci says my device is
>
> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
> (rev 73)
>
> I think you do need to do a bisection.
> Larry


Larry,

I did a bisect and here's what it came up with ... reverted the
following and iwlwiifi worked again.


19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
Author: Johannes Berg <[email protected]>
Date: Wed Jun 21 13:12:07 2023 +0300

wifi: iwlwifi: split 22000.c into multiple files

Split the configuration list in 22000.c into four new files,
per new device family, so we don't have this huge unusable
file. Yes, this duplicates a few small things, but that's
still much better than what we have now.

Signed-off-by: Johannes Berg <[email protected]>
Signed-off-by: Gregory Greenman <[email protected]>
Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
Signed-off-by: Johannes Berg <[email protected]>

drivers/net/wireless/intel/iwlwifi/Makefile | 1 +
drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 939 +-----------------------
drivers/net/wireless/intel/iwlwifi/cfg/ax210.c | 452 ++++++++++++
drivers/net/wireless/intel/iwlwifi/cfg/bz.c | 523 +++++++++++++
drivers/net/wireless/intel/iwlwifi/cfg/sc.c | 214 ++++++
drivers/net/wireless/intel/iwlwifi/iwl-config.h | 2 +
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 3 +
7 files changed, 1206 insertions(+), 928 deletions(-)
create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/ax210.c
create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/bz.c
create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/sc.c


My best.,
Jeff

>
>

2023-07-07 08:48:12

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: Linux-6.5 iwlwifi crash

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
for once, to make this easily accessible to everyone.

Jeff, thx for bisecting. Johannes afaik is unavailable for a while
(CCing him nevertheless), hence:

Gregory, could you please take a look at this? And maybe provide a few
hints for Jeff how to generate more data that allows us to find the root
of the problem?

Jeff, btw, the iwlwifi bug reporting guide (
https://wireless.wiki.kernel.org/en/users/drivers/iwlwifi/debugging
) says to file a bugs in http://bugzilla.kernel.org/ Might be wise to do
this in case Gregory is also unavailable, but instructed someone to keep
an eye on things there.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

On 07.07.23 03:56, Jeff Chua wrote:
> On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <[email protected]> wrote:
>
>> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
>> is working OK with iwlmvm. Lspci says my device is
>>
>> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
>> (rev 73)
>>
>> I think you do need to do a bisection.
>> Larry
>
>
> Larry,
>
> I did a bisect and here's what it came up with ... reverted the
> following and iwlwiifi worked again.
>
>
> 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
> commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
> Author: Johannes Berg <[email protected]>
> Date: Wed Jun 21 13:12:07 2023 +0300
>
> wifi: iwlwifi: split 22000.c into multiple files
>
> Split the configuration list in 22000.c into four new files,
> per new device family, so we don't have this huge unusable
> file. Yes, this duplicates a few small things, but that's
> still much better than what we have now.
>
> Signed-off-by: Johannes Berg <[email protected]>
> Signed-off-by: Gregory Greenman <[email protected]>
> Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
> Signed-off-by: Johannes Berg <[email protected]>
>
> drivers/net/wireless/intel/iwlwifi/Makefile | 1 +
> drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 939 +-----------------------
> drivers/net/wireless/intel/iwlwifi/cfg/ax210.c | 452 ++++++++++++
> drivers/net/wireless/intel/iwlwifi/cfg/bz.c | 523 +++++++++++++
> drivers/net/wireless/intel/iwlwifi/cfg/sc.c | 214 ++++++
> drivers/net/wireless/intel/iwlwifi/iwl-config.h | 2 +
> drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 3 +
> 7 files changed, 1206 insertions(+), 928 deletions(-)
> create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/ax210.c
> create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/bz.c
> create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/sc.c
>
>
> My best.,
> Jeff
>
>>
>>
>
>

2023-07-07 09:54:52

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: Linux-6.5 iwlwifi crash

On 07.07.23 10:43, Linux regression tracking (Thorsten Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> for once, to make this easily accessible to everyone.
>
> Jeff, thx for bisecting. Johannes afaik is unavailable for a while
> (CCing him nevertheless), hence:
> [...]

Just noticed: there is a bug in bugzilla about this issue already. See
here: https://bugzilla.kernel.org/show_bug.cgi?id=217622

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.


> On 07.07.23 03:56, Jeff Chua wrote:
>> On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <[email protected]> wrote:
>>
>>> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
>>> is working OK with iwlmvm. Lspci says my device is
>>>
>>> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
>>> (rev 73)
>>>
>>> I think you do need to do a bisection.
>>> Larry
>>
>>
>> Larry,
>>
>> I did a bisect and here's what it came up with ... reverted the
>> following and iwlwiifi worked again.
>>
>>
>> 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
>> commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
>> Author: Johannes Berg <[email protected]>
>> Date: Wed Jun 21 13:12:07 2023 +0300
>>
>> wifi: iwlwifi: split 22000.c into multiple files
>>
>> Split the configuration list in 22000.c into four new files,
>> per new device family, so we don't have this huge unusable
>> file. Yes, this duplicates a few small things, but that's
>> still much better than what we have now.
>>
>> Signed-off-by: Johannes Berg <[email protected]>
>> Signed-off-by: Gregory Greenman <[email protected]>
>> Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
>> Signed-off-by: Johannes Berg <[email protected]>
>>
>> drivers/net/wireless/intel/iwlwifi/Makefile | 1 +
>> drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 939 +-----------------------
>> drivers/net/wireless/intel/iwlwifi/cfg/ax210.c | 452 ++++++++++++
>> drivers/net/wireless/intel/iwlwifi/cfg/bz.c | 523 +++++++++++++
>> drivers/net/wireless/intel/iwlwifi/cfg/sc.c | 214 ++++++
>> drivers/net/wireless/intel/iwlwifi/iwl-config.h | 2 +
>> drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 3 +
>> 7 files changed, 1206 insertions(+), 928 deletions(-)
>> create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/ax210.c
>> create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/bz.c
>> create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/sc.c
>>
>>
>> My best.,
>> Jeff
>>
>>>
>>>
>>
>>

2023-07-07 18:16:30

by Larry Finger

[permalink] [raw]
Subject: Re: Linux-6.5 iwlwifi crash

On 7/7/23 03:43, Linux regression tracking (Thorsten Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> for once, to make this easily accessible to everyone.
>
> Jeff, thx for bisecting. Johannes afaik is unavailable for a while
> (CCing him nevertheless), hence:
>
> Gregory, could you please take a look at this? And maybe provide a few
> hints for Jeff how to generate more data that allows us to find the root
> of the problem?
>
> Jeff, btw, the iwlwifi bug reporting guide (
> https://wireless.wiki.kernel.org/en/users/drivers/iwlwifi/debugging
> ) says to file a bugs in http://bugzilla.kernel.org/ Might be wise to do
> this in case Gregory is also unavailable, but instructed someone to keep
> an eye on things there.
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> On 07.07.23 03:56, Jeff Chua wrote:
>> On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <[email protected]> wrote:
>>
>>> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
>>> is working OK with iwlmvm. Lspci says my device is
>>>
>>> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
>>> (rev 73)
>>>
>>> I think you do need to do a bisection.
>>> Larry
>>
>>
>> Larry,
>>
>> I did a bisect and here's what it came up with ... reverted the
>> following and iwlwiifi worked again.
>>
>>
>> 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
>> commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
>> Author: Johannes Berg <[email protected]>
>> Date: Wed Jun 21 13:12:07 2023 +0300
>>
>> wifi: iwlwifi: split 22000.c into multiple files
>>
>> Split the configuration list in 22000.c into four new files,
>> per new device family, so we don't have this huge unusable
>> file. Yes, this duplicates a few small things, but that's
>> still much better than what we have now.
>>
>> Signed-off-by: Johannes Berg <[email protected]>
>> Signed-off-by: Gregory Greenman <[email protected]>
>> Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
>> Signed-off-by: Johannes Berg <[email protected]>

Jeff,

I am certainly no expert on iwlwifi, but this change looks suspicious:

@@ -10,8 +10,7 @@
#include "fw/api/txq.h"

/* Highest firmware API version supported */
-#define IWL_22000_UCODE_API_MAX 81
-#define IWL_22500_UCODE_API_MAX 77
+#define IWL_22000_UCODE_API_MAX 77

/* Lowest firmware API version supported */

The parameter that was originally set to 81 is now set to 77.

Please try the attached patch.

Larry


Attachments:
test_iwlwifi.patch (0.98 kB)

2023-07-09 00:04:34

by Jeff Chua

[permalink] [raw]
Subject: Re: Linux-6.5 iwlwifi crash

On Sat, Jul 8, 2023 at 2:07 AM Larry Finger <[email protected]> wrote:
> I am certainly no expert on iwlwifi, but this change looks suspicious:
>
> @@ -10,8 +10,7 @@
> #include "fw/api/txq.h"
>
> /* Highest firmware API version supported */
> -#define IWL_22000_UCODE_API_MAX 81
> -#define IWL_22500_UCODE_API_MAX 77
> +#define IWL_22000_UCODE_API_MAX 77
>
> /* Lowest firmware API version supported */
>
> The parameter that was originally set to 81 is now set to 77.
>
> Please try the attached patch.
>
> Larry

Larry, tried, but that didn't help.

Thanks,
Jeff.