2016-02-14 21:58:06

by Fabio Estevam

Subject: [PATCH] brcmfmac: of: Include "of.h" header file

From: Fabio Estevam <[email protected]>

Include "of.h" header file to fix the following sparse warning:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <[email protected]>
---
Resending to [email protected]

drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index 03f35e0..6231b36 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -23,6 +23,7 @@
#include <defs.h>
#include "debug.h"
#include "sdio.h"
+#include "of.h"

void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)
{
--
1.9.1

2016-02-15 10:03:04

by Arend Van Spriel

Subject: Re: [PATCH] brcmfmac: of: Include "of.h" header file

I am actually preparing a patch series and found that this change is
incorporated in that series. As that involves other changes it is
probably better to drop this patch. I thought I could change the
patchwork state for it, but no luck.

Regards,
Arend

On Mon, Feb 15, 2016 at 10:15 AM, Arend Van Spriel
<[email protected]> wrote:
> On Sun, Feb 14, 2016 at 10:57 PM, Fabio Estevam <[email protected]> wrote:
>> From: Fabio Estevam <[email protected]>
>>
>> Include "of.h" header file to fix the following sparse warning:
>>
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static?
>
> Acked-by: Arend van Spriel <[email protected]>
>> Signed-off-by: Fabio Estevam <[email protected]>
>> ---
>> Resending to [email protected]
>>
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> index 03f35e0..6231b36 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> @@ -23,6 +23,7 @@
>> #include <defs.h>
>> #include "debug.h"
>> #include "sdio.h"
>> +#include "of.h"
>>
>> void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)
>> {
>> --
>> 1.9.1
>>

2016-02-18 13:19:14

by Kalle Valo

Subject: Re: [PATCH] brcmfmac: of: Include "of.h" header file

Arend Van Spriel <[email protected]> writes:

> I am actually preparing a patch series and found that this change is
> incorporated in that series. As that involves other changes it is
> probably better to drop this patch. I thought I could change the
> patchwork state for it, but no luck.

I think you can only change states of patches which you have submitted.
But I dropped this now.

--
Kalle Valo

2016-02-15 09:15:51

by Arend Van Spriel

Subject: Re: [PATCH] brcmfmac: of: Include "of.h" header file

On Sun, Feb 14, 2016 at 10:57 PM, Fabio Estevam <[email protected]> wrote:
> From: Fabio Estevam <[email protected]>
>
> Include "of.h" header file to fix the following sparse warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static?

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Fabio Estevam <[email protected]>
> ---
> Resending to [email protected]
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> index 03f35e0..6231b36 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> @@ -23,6 +23,7 @@
> #include <defs.h>
> #include "debug.h"
> #include "sdio.h"
> +#include "of.h"
>
> void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)
> {
> --
> 1.9.1
>

2016-02-15 00:34:32

by Julian Calaby

Subject: Re: [PATCH] brcmfmac: of: Include "of.h" header file

Hi All,

On Mon, Feb 15, 2016 at 8:57 AM, Fabio Estevam <[email protected]> wrote:
> From: Fabio Estevam <[email protected]>
>
> Include "of.h" header file to fix the following sparse warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <[email protected]>

Looks correct to me.

Reviewed-by: Julian Calaby <[email protected]>

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/