2019-02-10 19:48:05

by Lubomir Rintel

Subject: [PATCH] libertas_tf: don't set URB_ZERO_PACKET on IN USB transfer

It doesn't make sense and the USB core warns on each submit of such
URB, easily flooding the message buffer with tracebacks.

Analogous issue was fixed in regular libertas driver in commit 6528d8804780
("libertas: don't set URB_ZERO_PACKET on IN USB transfer").

Cc: [email protected]
Signed-off-by: Lubomir Rintel <[email protected]>
---
drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
index 789337ea676a..6ede6168bd85 100644
--- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c
+++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
@@ -433,8 +433,6 @@ static int __if_usb_submit_rx_urb(struct if_usb_card *cardp,
skb_tail_pointer(skb),
MRVDRV_ETH_RX_PACKET_BUFFER_SIZE, callbackfn, cardp);

- cardp->rx_urb->transfer_flags |= URB_ZERO_PACKET;
-
lbtf_deb_usb2(&cardp->udev->dev, "Pointer for rx_urb %p\n",
cardp->rx_urb);
ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC);
--
2.20.1

2019-02-11 13:38:53

by Steve deRosier

Subject: Re: [PATCH] libertas_tf: don't set URB_ZERO_PACKET on IN USB transfer

On Sun, Feb 10, 2019 at 11:48 AM Lubomir Rintel <[email protected]> wrote:
>
> It doesn't make sense and the USB core warns on each submit of such
> URB, easily flooding the message buffer with tracebacks.
>
> Analogous issue was fixed in regular libertas driver in commit 6528d8804780
> ("libertas: don't set URB_ZERO_PACKET on IN USB transfer").
>
> Cc: [email protected]
> Signed-off-by: Lubomir Rintel <[email protected]>
> ---
> drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
> index 789337ea676a..6ede6168bd85 100644
> --- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c
> +++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
> @@ -433,8 +433,6 @@ static int __if_usb_submit_rx_urb(struct if_usb_card *cardp,
> skb_tail_pointer(skb),
> MRVDRV_ETH_RX_PACKET_BUFFER_SIZE, callbackfn, cardp);
>
> - cardp->rx_urb->transfer_flags |= URB_ZERO_PACKET;
> -
> lbtf_deb_usb2(&cardp->udev->dev, "Pointer for rx_urb %p\n",
> cardp->rx_urb);
> ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC);
> --
> 2.20.1
>

Reviewed-by: Steve deRosier <[email protected]>

2019-02-19 15:10:51

by Kalle Valo

Subject: Re: [PATCH] libertas_tf: don't set URB_ZERO_PACKET on IN USB transfer

Lubomir Rintel <[email protected]> wrote:

> It doesn't make sense and the USB core warns on each submit of such
> URB, easily flooding the message buffer with tracebacks.
>
> Analogous issue was fixed in regular libertas driver in commit 6528d8804780
> ("libertas: don't set URB_ZERO_PACKET on IN USB transfer").
>
> Cc: [email protected]
> Signed-off-by: Lubomir Rintel <[email protected]>
> Reviewed-by: Steve deRosier <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

607076a904c4 libertas_tf: don't set URB_ZERO_PACKET on IN USB transfer

--
https://patchwork.kernel.org/patch/10804875/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches