2023-09-16 03:36:28

by Jeff Johnson

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] cfg80211: Allow AP/P2PGO to indicate port authorization to peer STA/P2PClient

On 9/14/2023 10:17 PM, Vinayak Yadawad wrote:
> In 4way handshake offload, cfg80211_port_authorized enables driver
> to indicate successful 4way handshake to cfg80211 layer. Currently
> this path of port authorization is restricted to interface type
> NL80211_IFTYPE_STATION and NL80211_IFTYPE_P2P_CLIENT. This patch
> extends the support for NL80211_IFTYPE_AP and NL80211_IFTYPE_P2P_GO
> interfaces to authorize peer STA/P2P_CLIENT, whenever authentication
> is offloaded on the AP/P2P_GO interface.
>
> Signed-off-by: Vinayak Yadawad <[email protected]>
> ---

v1->v2 change log is missing
can you provide that as a separate message

2023-09-18 11:15:50

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] cfg80211: Allow AP/P2PGO to indicate port authorization to peer STA/P2PClient

On Fri, 2023-09-15 at 12:11 -0700, Jeff Johnson wrote:
> On 9/14/2023 10:17 PM, Vinayak Yadawad wrote:
> > In 4way handshake offload, cfg80211_port_authorized enables driver
> > to indicate successful 4way handshake to cfg80211 layer. Currently
> > this path of port authorization is restricted to interface type
> > NL80211_IFTYPE_STATION and NL80211_IFTYPE_P2P_CLIENT. This patch
> > extends the support for NL80211_IFTYPE_AP and NL80211_IFTYPE_P2P_GO
> > interfaces to authorize peer STA/P2P_CLIENT, whenever authentication
> > is offloaded on the AP/P2P_GO interface.
> >
> > Signed-off-by: Vinayak Yadawad <[email protected]>
> > ---
>
> v1->v2 change log is missing
> can you provide that as a separate message

Or just fix it with v3, this doesn't apply ...

Also please indent the documentation per what you see there (tab).

johannes

2023-09-24 15:45:51

by Vinayak Yadawad

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] cfg80211: Allow AP/P2PGO to indicate port authorization to peer STA/P2PClient

Hi,

I have addressed the comments as part of "[PATCH v3 1/1] cfg80211:
Allow AP/P2PGO to indicate port authorization to peer STA/P2PClient".
Please review.

Regards,
Vinayak

On Mon, Sep 18, 2023 at 1:18 PM Johannes Berg <[email protected]> wrote:
>
> On Fri, 2023-09-15 at 12:11 -0700, Jeff Johnson wrote:
> > On 9/14/2023 10:17 PM, Vinayak Yadawad wrote:
> > > In 4way handshake offload, cfg80211_port_authorized enables driver
> > > to indicate successful 4way handshake to cfg80211 layer. Currently
> > > this path of port authorization is restricted to interface type
> > > NL80211_IFTYPE_STATION and NL80211_IFTYPE_P2P_CLIENT. This patch
> > > extends the support for NL80211_IFTYPE_AP and NL80211_IFTYPE_P2P_GO
> > > interfaces to authorize peer STA/P2P_CLIENT, whenever authentication
> > > is offloaded on the AP/P2P_GO interface.
> > >
> > > Signed-off-by: Vinayak Yadawad <[email protected]>
> > > ---
> >
> > v1->v2 change log is missing
> > can you provide that as a separate message
>
> Or just fix it with v3, this doesn't apply ...
>
> Also please indent the documentation per what you see there (tab).
>
> johannes


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature