The below commit introduced a regression causing the wlcore
to time out and go into recovery.
commit 3719c17e1816695f415dd3b4ddcb679f7dc617c8
("wlcore/wl18xx: fw logger over sdio")
Reverting the changes regarding write of the last partition size
brings the module back to it's functional state.
Reported-by: Ross Green <[email protected]>
Signed-off-by: Emil Goode <[email protected]>
---
drivers/net/wireless/ti/wlcore/io.c | 8 ++++----
drivers/net/wireless/ti/wlcore/io.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/io.c b/drivers/net/wireless/ti/wlcore/io.c
index 9ac118e..564ca75 100644
--- a/drivers/net/wireless/ti/wlcore/io.c
+++ b/drivers/net/wireless/ti/wlcore/io.c
@@ -175,14 +175,14 @@ int wlcore_set_partition(struct wl1271 *wl,
if (ret < 0)
goto out;
+ /* We don't need the size of the last partition, as it is
+ * automatically calculated based on the total memory size and
+ * the sizes of the previous partitions.
+ */
ret = wlcore_raw_write32(wl, HW_PART3_START_ADDR, p->mem3.start);
if (ret < 0)
goto out;
- ret = wlcore_raw_write32(wl, HW_PART3_SIZE_ADDR, p->mem3.size);
- if (ret < 0)
- goto out;
-
out:
return ret;
}
diff --git a/drivers/net/wireless/ti/wlcore/io.h b/drivers/net/wireless/ti/wlcore/io.h
index 6c257b5..10cf374 100644
--- a/drivers/net/wireless/ti/wlcore/io.h
+++ b/drivers/net/wireless/ti/wlcore/io.h
@@ -36,8 +36,8 @@
#define HW_PART1_START_ADDR (HW_PARTITION_REGISTERS_ADDR + 12)
#define HW_PART2_SIZE_ADDR (HW_PARTITION_REGISTERS_ADDR + 16)
#define HW_PART2_START_ADDR (HW_PARTITION_REGISTERS_ADDR + 20)
-#define HW_PART3_SIZE_ADDR (HW_PARTITION_REGISTERS_ADDR + 24)
-#define HW_PART3_START_ADDR (HW_PARTITION_REGISTERS_ADDR + 28)
+#define HW_PART3_START_ADDR (HW_PARTITION_REGISTERS_ADDR + 24)
+
#define HW_ACCESS_REGISTER_SIZE 4
#define HW_ACCESS_PRAM_MAX_RANGE 0x3c000
--
2.1.4
Emil Goode <[email protected]> writes:
> The below commit introduced a regression causing the wlcore
> to time out and go into recovery.
>
> commit 3719c17e1816695f415dd3b4ddcb679f7dc617c8
> ("wlcore/wl18xx: fw logger over sdio")
>
> Reverting the changes regarding write of the last partition size
> brings the module back to it's functional state.
>
> Reported-by: Ross Green <[email protected]>
> Signed-off-by: Emil Goode <[email protected]>
A proper "Fixes:" line is good to have, but I can add it.
I'm planning to queue this to 4.5.
--
Kalle Valo
On Thu, Feb 25, 2016 at 11:11 AM, Emil Goode <[email protected]> wrote:
> Hello Ross
>
> On Wed, Feb 24, 2016 at 04:40:50PM +1100, Ross Green wrote:
>> On Wed, Feb 17, 2016 at 4:34 PM, Ross Green <[email protected]> wrote:
>> > Appreciate your efforts!
>> >
>> > Just trying to make sure it does not get lost.
>> > Introduced in rc1, not fixed by ... rc4.
>> >
>> > Anyway, I will continue to test, lots of other things still to chase
>> > even in rc4!
>> >
>> > Regards,
>> >
>> > Ross Green
>> >
>> > On Wed, Feb 17, 2016 at 2:24 AM, Kalle Valo <[email protected]> wrote:
>> >> Ross Green <[email protected]> writes:
>> >>
>> >>> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <[email protected]> wrote:
>> >>>>
>> >>>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>> >>>>> regression causing the wlcore to time out and go into recovery. Reverting the
>> >>>>> changes regarding write of the last partition size brings the module back to
>> >>>>> it's functional state.
>> >>>>>
>> >>>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>> >>>>> Reported-by: Ross Green <[email protected]>
>> >>>>> Signed-off-by: Emil Goode <[email protected]>
>> >>>>> [[email protected]: improved commit log]
>> >>>>
>> >>>> Thanks, applied to wireless-drivers.git.
>> >>>>
>> >>>> Kalle Valo
>> >>>
>> >>> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
>> >>> So the behaviour of firmware reset being called after the access of
>> >>> the last partition timesout.
>> >>>
>> >>> Again tested patch with the new release - 4.5-rc4 and found everything
>> >>> to work as expected again.
>> >>>
>> >>> So Hopefully for rc5 - Please!
>> >>
>> >> It takes some time to get patches into Linus' tree. And being in a
>> >> conference and then getting sick is not really helping. I'm not sure if
>> >> this patch makes to rc5 on time, but I'll try.
>> >>
>> >> --
>> >> Kalle Valo
>>
>> G'day all,
>>
>> I have tested Emil's patch with each 4.5-rc release.
>>
>> Seems to work fine with rc2, rc3, rc4.
>> I tried it with rc5 and get the following output from dmesg see attachment.
>>
>> So it looks like there is a reset that it recovers from and then proceeds OK.
>>
>> I see the patch has been queued by David Miller so it might make it into rc6.
>> That will be great. It still does not look quite as clean as it should
>> be however, given the noise in the dmesg output from rc5
>>
>> Regards,
>>
>>
>> Ross Green
>
> I'm unable to reproduce that ELP wakeup timeout with v4.5-rc5 on my pandaboard es.
> Can you easily reproduce it and are you able to reproduce it with commit 3719c17e1816 reverted?
>
> However, I'm seeing another bug that occurs when the wlan is not configured to connect to
> an AP directly after boot (dmesg attached). It is not related to any recent changes and goes back
> before the 3.14 kernel. There seem to be an issue with the looped IRQ handling implementation.
> A scan on 2GHZ is performed and the wlcore_fw_status() call in wlcore_irq_locked() returns
> WL1271_ACX_INTR_HW_AVAILABLE, then nothing seem to happen until the delayed work queue
> scan_complete_work starts executing after the 30 sec timeout runs out and the wlcore goes into
> recovery. I guess a new scan should be initiated after wlcore_fw_status() return hw available,
> does anyone have input on that?
>
> Best regards,
>
> Emil Goode
Sorry Emil had not tried a reboot since getting that message. The wifi
module did recover and associate properly after that. So I just kept
on using the system.
Trying to track down another problem that takes "AGES" before it shows
up so just kept the system running. Hoping to get some debug regarding
and RCU problem.
I will check it again later when i get a chance to reboot.
At least with your patch in place the system will keep functioning.
Plus I had not noticed any problems running rc2, rc3, rc4 with your
patch in place.
Everything behaved pre the 4.5 changes.
I'll get back to you with what I find. It does look however that there
might be some other problems sitting there that possibly the new
changes show up more. Some slightly different timing situations.
Regards,
Ross Green
Ross Green <[email protected]> writes:
> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <[email protected]> wrote:
>>
>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>>> regression causing the wlcore to time out and go into recovery. Reverting the
>>> changes regarding write of the last partition size brings the module back to
>>> it's functional state.
>>>
>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>>> Reported-by: Ross Green <[email protected]>
>>> Signed-off-by: Emil Goode <[email protected]>
>>> [[email protected]: improved commit log]
>>
>> Thanks, applied to wireless-drivers.git.
>>
>> Kalle Valo
>
> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
> So the behaviour of firmware reset being called after the access of
> the last partition timesout.
>
> Again tested patch with the new release - 4.5-rc4 and found everything
> to work as expected again.
>
> So Hopefully for rc5 - Please!
It takes some time to get patches into Linus' tree. And being in a
conference and then getting sick is not really helping. I'm not sure if
this patch makes to rc5 on time, but I'll try.
--
Kalle Valo
On Wed, Feb 17, 2016 at 4:34 PM, Ross Green <[email protected]> wrote:
> Appreciate your efforts!
>
> Just trying to make sure it does not get lost.
> Introduced in rc1, not fixed by ... rc4.
>
> Anyway, I will continue to test, lots of other things still to chase
> even in rc4!
>
> Regards,
>
> Ross Green
>
> On Wed, Feb 17, 2016 at 2:24 AM, Kalle Valo <[email protected]> wrote:
>> Ross Green <[email protected]> writes:
>>
>>> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <[email protected]> wrote:
>>>>
>>>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>>>>> regression causing the wlcore to time out and go into recovery. Reverting the
>>>>> changes regarding write of the last partition size brings the module back to
>>>>> it's functional state.
>>>>>
>>>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>>>>> Reported-by: Ross Green <[email protected]>
>>>>> Signed-off-by: Emil Goode <[email protected]>
>>>>> [[email protected]: improved commit log]
>>>>
>>>> Thanks, applied to wireless-drivers.git.
>>>>
>>>> Kalle Valo
>>>
>>> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
>>> So the behaviour of firmware reset being called after the access of
>>> the last partition timesout.
>>>
>>> Again tested patch with the new release - 4.5-rc4 and found everything
>>> to work as expected again.
>>>
>>> So Hopefully for rc5 - Please!
>>
>> It takes some time to get patches into Linus' tree. And being in a
>> conference and then getting sick is not really helping. I'm not sure if
>> this patch makes to rc5 on time, but I'll try.
>>
>> --
>> Kalle Valo
G'day all,
I have tested Emil's patch with each 4.5-rc release.
Seems to work fine with rc2, rc3, rc4.
I tried it with rc5 and get the following output from dmesg see attachment.
So it looks like there is a reset that it recovers from and then proceeds OK.
I see the patch has been queued by David Miller so it might make it into rc6.
That will be great. It still does not look quite as clean as it should
be however, given the noise in the dmesg output from rc5
Regards,
Ross Green
Hello Ross
On Wed, Feb 24, 2016 at 04:40:50PM +1100, Ross Green wrote:
> On Wed, Feb 17, 2016 at 4:34 PM, Ross Green <[email protected]> wrote:
> > Appreciate your efforts!
> >
> > Just trying to make sure it does not get lost.
> > Introduced in rc1, not fixed by ... rc4.
> >
> > Anyway, I will continue to test, lots of other things still to chase
> > even in rc4!
> >
> > Regards,
> >
> > Ross Green
> >
> > On Wed, Feb 17, 2016 at 2:24 AM, Kalle Valo <[email protected]> wrote:
> >> Ross Green <[email protected]> writes:
> >>
> >>> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <[email protected]> wrote:
> >>>>
> >>>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
> >>>>> regression causing the wlcore to time out and go into recovery. Reverting the
> >>>>> changes regarding write of the last partition size brings the module back to
> >>>>> it's functional state.
> >>>>>
> >>>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
> >>>>> Reported-by: Ross Green <[email protected]>
> >>>>> Signed-off-by: Emil Goode <[email protected]>
> >>>>> [[email protected]: improved commit log]
> >>>>
> >>>> Thanks, applied to wireless-drivers.git.
> >>>>
> >>>> Kalle Valo
> >>>
> >>> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
> >>> So the behaviour of firmware reset being called after the access of
> >>> the last partition timesout.
> >>>
> >>> Again tested patch with the new release - 4.5-rc4 and found everything
> >>> to work as expected again.
> >>>
> >>> So Hopefully for rc5 - Please!
> >>
> >> It takes some time to get patches into Linus' tree. And being in a
> >> conference and then getting sick is not really helping. I'm not sure if
> >> this patch makes to rc5 on time, but I'll try.
> >>
> >> --
> >> Kalle Valo
>
> G'day all,
>
> I have tested Emil's patch with each 4.5-rc release.
>
> Seems to work fine with rc2, rc3, rc4.
> I tried it with rc5 and get the following output from dmesg see attachment.
>
> So it looks like there is a reset that it recovers from and then proceeds OK.
>
> I see the patch has been queued by David Miller so it might make it into rc6.
> That will be great. It still does not look quite as clean as it should
> be however, given the noise in the dmesg output from rc5
>
> Regards,
>
>
> Ross Green
I'm unable to reproduce that ELP wakeup timeout with v4.5-rc5 on my pandaboard es.
Can you easily reproduce it and are you able to reproduce it with commit 3719c17e1816 reverted?
However, I'm seeing another bug that occurs when the wlan is not configured to connect to
an AP directly after boot (dmesg attached). It is not related to any recent changes and goes back
before the 3.14 kernel. There seem to be an issue with the looped IRQ handling implementation.
A scan on 2GHZ is performed and the wlcore_fw_status() call in wlcore_irq_locked() returns
WL1271_ACX_INTR_HW_AVAILABLE, then nothing seem to happen until the delayed work queue
scan_complete_work starts executing after the 30 sec timeout runs out and the wlcore goes into
recovery. I guess a new scan should be initiated after wlcore_fw_status() return hw available,
does anyone have input on that?
Best regards,
Emil Goode
Appreciate your efforts!
Just trying to make sure it does not get lost.
Introduced in rc1, not fixed by ... rc4.
Anyway, I will continue to test, lots of other things still to chase
even in rc4!
Regards,
Ross Green
On Wed, Feb 17, 2016 at 2:24 AM, Kalle Valo <[email protected]> wrote:
> Ross Green <[email protected]> writes:
>
>> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <[email protected]> wrote:
>>>
>>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>>>> regression causing the wlcore to time out and go into recovery. Reverting the
>>>> changes regarding write of the last partition size brings the module back to
>>>> it's functional state.
>>>>
>>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>>>> Reported-by: Ross Green <[email protected]>
>>>> Signed-off-by: Emil Goode <[email protected]>
>>>> [[email protected]: improved commit log]
>>>
>>> Thanks, applied to wireless-drivers.git.
>>>
>>> Kalle Valo
>>
>> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
>> So the behaviour of firmware reset being called after the access of
>> the last partition timesout.
>>
>> Again tested patch with the new release - 4.5-rc4 and found everything
>> to work as expected again.
>>
>> So Hopefully for rc5 - Please!
>
> It takes some time to get patches into Linus' tree. And being in a
> conference and then getting sick is not really helping. I'm not sure if
> this patch makes to rc5 on time, but I'll try.
>
> --
> Kalle Valo
> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
> regression causing the wlcore to time out and go into recovery. Reverting the
> changes regarding write of the last partition size brings the module back to
> it's functional state.
>
> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
> Reported-by: Ross Green <[email protected]>
> Signed-off-by: Emil Goode <[email protected]>
> [[email protected]: improved commit log]
Thanks, applied to wireless-drivers.git.
Kalle Valo
On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <[email protected]> wrote:
>
>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>> regression causing the wlcore to time out and go into recovery. Reverting the
>> changes regarding write of the last partition size brings the module back to
>> it's functional state.
>>
>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>> Reported-by: Ross Green <[email protected]>
>> Signed-off-by: Emil Goode <[email protected]>
>> [[email protected]: improved commit log]
>
> Thanks, applied to wireless-drivers.git.
>
> Kalle Valo
I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
So the behaviour of firmware reset being called after the access of
the last partition timesout.
Again tested patch with the new release - 4.5-rc4 and found everything
to work as expected again.
So Hopefully for rc5 - Please!
please find attached a copy of the dmesg output for 4.5-rc4
Regards,
Ross Green
On Thu, Feb 25, 2016 at 1:13 PM, Ross Green <[email protected]> wrote:
> On Thu, Feb 25, 2016 at 11:11 AM, Emil Goode <[email protected]> wrote:
>> Hello Ross
>>
>> On Wed, Feb 24, 2016 at 04:40:50PM +1100, Ross Green wrote:
>>> On Wed, Feb 17, 2016 at 4:34 PM, Ross Green <[email protected]> wrote:
>>> > Appreciate your efforts!
>>> >
>>> > Just trying to make sure it does not get lost.
>>> > Introduced in rc1, not fixed by ... rc4.
>>> >
>>> > Anyway, I will continue to test, lots of other things still to chase
>>> > even in rc4!
>>> >
>>> > Regards,
>>> >
>>> > Ross Green
>>> >
>>> > On Wed, Feb 17, 2016 at 2:24 AM, Kalle Valo <[email protected]> wrote:
>>> >> Ross Green <[email protected]> writes:
>>> >>
>>> >>> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <[email protected]> wrote:
>>> >>>>
>>> >>>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>>> >>>>> regression causing the wlcore to time out and go into recovery. Reverting the
>>> >>>>> changes regarding write of the last partition size brings the module back to
>>> >>>>> it's functional state.
>>> >>>>>
>>> >>>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>>> >>>>> Reported-by: Ross Green <[email protected]>
>>> >>>>> Signed-off-by: Emil Goode <[email protected]>
>>> >>>>> [[email protected]: improved commit log]
>>> >>>>
>>> >>>> Thanks, applied to wireless-drivers.git.
>>> >>>>
>>> >>>> Kalle Valo
>>> >>>
>>> >>> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
>>> >>> So the behaviour of firmware reset being called after the access of
>>> >>> the last partition timesout.
>>> >>>
>>> >>> Again tested patch with the new release - 4.5-rc4 and found everything
>>> >>> to work as expected again.
>>> >>>
>>> >>> So Hopefully for rc5 - Please!
>>> >>
>>> >> It takes some time to get patches into Linus' tree. And being in a
>>> >> conference and then getting sick is not really helping. I'm not sure if
>>> >> this patch makes to rc5 on time, but I'll try.
>>> >>
>>> >> --
>>> >> Kalle Valo
>>>
>>> G'day all,
>>>
>>> I have tested Emil's patch with each 4.5-rc release.
>>>
>>> Seems to work fine with rc2, rc3, rc4.
>>> I tried it with rc5 and get the following output from dmesg see attachment.
>>>
>>> So it looks like there is a reset that it recovers from and then proceeds OK.
>>>
>>> I see the patch has been queued by David Miller so it might make it into rc6.
>>> That will be great. It still does not look quite as clean as it should
>>> be however, given the noise in the dmesg output from rc5
>>>
>>> Regards,
>>>
>>>
>>> Ross Green
>>
>> I'm unable to reproduce that ELP wakeup timeout with v4.5-rc5 on my pandaboard es.
>> Can you easily reproduce it and are you able to reproduce it with commit 3719c17e1816 reverted?
>>
>> However, I'm seeing another bug that occurs when the wlan is not configured to connect to
>> an AP directly after boot (dmesg attached). It is not related to any recent changes and goes back
>> before the 3.14 kernel. There seem to be an issue with the looped IRQ handling implementation.
>> A scan on 2GHZ is performed and the wlcore_fw_status() call in wlcore_irq_locked() returns
>> WL1271_ACX_INTR_HW_AVAILABLE, then nothing seem to happen until the delayed work queue
>> scan_complete_work starts executing after the 30 sec timeout runs out and the wlcore goes into
>> recovery. I guess a new scan should be initiated after wlcore_fw_status() return hw available,
>> does anyone have input on that?
>>
>> Best regards,
>>
>> Emil Goode
>
>
> Sorry Emil had not tried a reboot since getting that message. The wifi
> module did recover and associate properly after that. So I just kept
> on using the system.
>
> Trying to track down another problem that takes "AGES" before it shows
> up so just kept the system running. Hoping to get some debug regarding
> and RCU problem.
>
> I will check it again later when i get a chance to reboot.
>
> At least with your patch in place the system will keep functioning.
> Plus I had not noticed any problems running rc2, rc3, rc4 with your
> patch in place.
> Everything behaved pre the 4.5 changes.
>
> I'll get back to you with what I find. It does look however that there
> might be some other problems sitting there that possibly the new
> changes show up more. Some slightly different timing situations.
>
> Regards,
>
> Ross Green
G'day Emil,
Just tried a reboot of the pandaboard es with the patches applied to
the 4.5-rc5.
Everything worked fine!!!
So it might be a strange timing thing that happens "sometimes".
the wl processor is running its own software from the firmware
downloaded, there might be times when it accessed too soon.
So there are still a few things to watch with the changes that have
been been added during 4.5. I had assumed that this driver had been
fairly stable for some time,
but there might have always been a few problems lurking.
attached is a small section of the dmesg output, showing good working
order for the wl driver.
Regards,
Ross Green