2021-04-13 09:35:55

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7921: get rid of mt7921_dma_cleanup

> Remove mt7921_dma_cleanup routine since it is no longer used
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>
> ---
> .../net/wireless/mediatek/mt76/mt7921/dma.c | 23 -------------------
> .../wireless/mediatek/mt76/mt7921/mt7921.h | 1 -
> 2 files changed, 24 deletions(-)

Hi Felix,

please ignore this patch, we need mt7921_dma_cleanup unloading the module.

Regards,
Lorenzo

>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> index 992faf82ad09..14e694563a89 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> @@ -331,26 +331,3 @@ int mt7921_dma_init(struct mt7921_dev *dev)
>
> return 0;
> }
> -
> -void mt7921_dma_cleanup(struct mt7921_dev *dev)
> -{
> - /* disable */
> - mt76_clear(dev, MT_WFDMA0_GLO_CFG,
> - MT_WFDMA0_GLO_CFG_TX_DMA_EN |
> - MT_WFDMA0_GLO_CFG_RX_DMA_EN |
> - MT_WFDMA0_GLO_CFG_CSR_DISP_BASE_PTR_CHAIN_EN |
> - MT_WFDMA0_GLO_CFG_OMIT_TX_INFO |
> - MT_WFDMA0_GLO_CFG_OMIT_RX_INFO |
> - MT_WFDMA0_GLO_CFG_OMIT_RX_INFO_PFET2);
> -
> - /* reset */
> - mt76_clear(dev, MT_WFDMA0_RST,
> - MT_WFDMA0_RST_DMASHDL_ALL_RST |
> - MT_WFDMA0_RST_LOGIC_RST);
> -
> - mt76_set(dev, MT_WFDMA0_RST,
> - MT_WFDMA0_RST_DMASHDL_ALL_RST |
> - MT_WFDMA0_RST_LOGIC_RST);
> -
> - mt76_dma_cleanup(&dev->mt76);
> -}
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> index e3d83d3d954c..1e70c749bbf3 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> @@ -225,7 +225,6 @@ int mt7921_eeprom_get_target_power(struct mt7921_dev *dev,
> void mt7921_eeprom_init_sku(struct mt7921_dev *dev);
> int mt7921_dma_init(struct mt7921_dev *dev);
> void mt7921_dma_prefetch(struct mt7921_dev *dev);
> -void mt7921_dma_cleanup(struct mt7921_dev *dev);
> int mt7921_run_firmware(struct mt7921_dev *dev);
> int mt7921_mcu_init(struct mt7921_dev *dev);
> int mt7921_mcu_add_bss_info(struct mt7921_phy *phy,
> --
> 2.30.2
>


Attachments:
(No filename) (2.17 kB)
signature.asc (235.00 B)
Download all attachments