2023-09-15 03:42:04

by Víctor Gonzalo

Subject: [PATCH] wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata

The mwifiex_pcie driver is missing the MODULE_FIRMWARE macro to
add the firmware files needed to the module metadata.

Signed-off-by: Víctor Gonzalo <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
index 6697132ecc97..cd464453d5db 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -3449,3 +3449,9 @@ MODULE_AUTHOR("Marvell International Ltd.");
MODULE_DESCRIPTION("Marvell WiFi-Ex PCI-Express Driver version " PCIE_VERSION);
MODULE_VERSION(PCIE_VERSION);
MODULE_LICENSE("GPL v2");
+MODULE_FIRMWARE(PCIE8766_DEFAULT_FW_NAME);
+MODULE_FIRMWARE(PCIE8897_DEFAULT_FW_NAME);
+MODULE_FIRMWARE(PCIE8897_A0_FW_NAME);
+MODULE_FIRMWARE(PCIE8897_B0_FW_NAME);
+MODULE_FIRMWARE(PCIEUART8997_FW_NAME_V4);
+MODULE_FIRMWARE(PCIEUSB8997_FW_NAME_V4);
--
2.34.1

2023-09-20 23:17:47

by Brian Norris

Subject: Re: [PATCH] wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata

On Fri, Sep 15, 2023 at 12:19:38AM +0300, V?ctor Gonzalo wrote:
> The mwifiex_pcie driver is missing the MODULE_FIRMWARE macro to
> add the firmware files needed to the module metadata.
>
> Signed-off-by: V?ctor Gonzalo <[email protected]>
> ---
> drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++++++
> 1 file changed, 6 insertions(+)

FWIW, when reviewing the other sub-drivers, I noticed sdio.c is missing
an entry for SD8801_DEFAULT_FW_NAME. Mind sending a patch?

For this:

Acked-by: Brian Norris <[email protected]>

2023-09-21 19:33:46

by Kalle Valo

Subject: Re: [PATCH] wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata

Víctor Gonzalo <[email protected]> wrote:

> The mwifiex_pcie driver is missing the MODULE_FIRMWARE macro to
> add the firmware files needed to the module metadata.
>
> Signed-off-by: Víctor Gonzalo <[email protected]>
> Acked-by: Brian Norris <[email protected]>

Patch applied to wireless-next.git, thanks.

260323c3a3e3 wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches